8429 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Michael Eischer	24f4e780f1	backend: consistently use os package for filesystem access ... The go std library should be good enough to manage the files in the backend and cache folders.	2024-08-31 18:20:40 +02:00
Michael Eischer	ca1e5e10b6	add proper constants for node type	2024-08-31 18:20:01 +02:00
Michael Eischer	3b438e5c7c	Merge pull request #5023 from MichaelEischer/cleanup-archiver ... archiver: use FS interface nearly everywhere and cleanup exports	2024-08-31 18:14:47 +02:00
Michael Eischer	7bb92dc7bd	archiver: use ExtendedStat from FS interface ... With this change, NodeFromFileInfo is the last function that bypasses the FS interface in the archiver.	2024-08-31 18:05:09 +02:00
Michael Eischer	e79dca644e	fs: unexport DeviceID	2024-08-31 18:04:53 +02:00
Michael Eischer	70fbad6623	archiver: minimize imports	2024-08-31 18:04:37 +02:00
Michael Eischer	6fd5d5f2d5	archiver: move helper functions to combine rejects	2024-08-31 18:04:22 +02:00
Michael Eischer	f1585af0f2	move include/exclude options to filter package	2024-08-31 18:04:07 +02:00
Michael Eischer	5d58945718	cleanup include / exclude option setup	2024-08-31 18:03:53 +02:00
Michael Eischer	41c031a19e	backup: move RejectFuncs to archiver package	2024-08-31 18:03:35 +02:00
Michael Eischer	f9dbcd2531	backup: convert reject funcs to use FS interface ... Depending on parameters the paths in a snapshot do not directly correspond to real paths on the filesystem. Therefore, reject funcs must use the FS interface to work correctly.	2024-08-31 18:03:02 +02:00
Michael Eischer	c6fae0320e	archiver: hide implementation details	2024-08-31 17:52:45 +02:00
Michael Eischer	e5cdae9c84	Merge pull request #5022 from MichaelEischer/extract-fs-code ... Extract filesystem code from restic.Node	2024-08-31 17:52:11 +02:00
Michael Eischer	507842b614	fs: remove Open method from FS interface	2024-08-31 17:37:25 +02:00
Michael Eischer	263709da8c	fs: unexport isListxattrPermissionError	2024-08-31 17:37:25 +02:00
Michael Eischer	80ed863aab	repository: remove redundant cleanup code ... The temp files used by the packer manager are either delete after creation (unix) or marked as delete on close (windows). Thus, no explicit cleanup is necessary.	2024-08-31 17:37:25 +02:00
Michael Eischer	0ddb4441d7	fs: clean up helper functions	2024-08-31 17:37:25 +02:00
Michael Eischer	fc549c9462	cleanup imports	2024-08-31 17:37:25 +02:00
Michael Eischer	b9b32e5647	restic: extract Node filesystem code to fs package	2024-08-31 17:37:25 +02:00
Michael Eischer	a2e54eac64	restic: simplify nodeCreateFileAt ... The code to write the file content is never used.	2024-08-31 17:37:25 +02:00
Michael Eischer	5644079707	restic: prepare extraction of fs code from Node	2024-08-31 17:37:25 +02:00
Michael Eischer	3e0c081bed	Merge pull request #5020 from MichaelEischer/remove-legacy-formats ... Remove support for legacy index format and s3 layout	2024-08-31 17:37:09 +02:00
Michael Eischer	97f696b937	backend: remove dead code	2024-08-31 17:25:24 +02:00
Michael Eischer	af989aab4e	backend/layout: unexport fields and simplify rest layout	2024-08-31 17:25:24 +02:00
Michael Eischer	6024597028	drop support for s3legacy layout	2024-08-31 17:25:24 +02:00
Michael Eischer	943b6ccfba	index: remove support for legacy index format	2024-08-31 17:12:43 +02:00
Michael Eischer	a5533344f9	Merge pull request #5028 from MichaelEischer/windows-allow-specifying-volumes ... backup: support specifying volume instead of path on Windows	2024-08-31 16:43:20 +02:00
Michael Eischer	ddf35a60ad	Merge pull request #5026 from MichaelEischer/fix-handling-invalid-filenames ... cache: Fix handling of invalid filenames	2024-08-31 16:42:13 +02:00
Michael Eischer	4fcedb4bae	backup: support specifying volume instead of path on Windows ... "C:" (volume name) versus "C:\" (path)	2024-08-30 11:35:43 +02:00
Michael Eischer	a0f2dfbc19	Merge pull request #5019 from MichaelEischer/fix-windows-sd-race ... backup: Fix spurious "A Required Privilege Is Not Held by the Client" error	2024-08-29 16:59:06 +02:00
Michael Eischer	0aadfe32bb	Merge pull request #5018 from MichaelEischer/rest-retry-http2-goaway ... rest: improve handling of HTTP2 goaway	2024-08-29 16:58:04 +02:00
Michael Eischer	dab3e549af	Merge pull request #5017 from MichaelEischer/rewrite-data-loss ... rewrite: Document handling of "cannot encode tree" errors	2024-08-29 16:57:13 +02:00
Michael Eischer	5c238ea359	Merge pull request #5016 from MichaelEischer/s3-doc-rework ... Rework documentation for s3-compatible storages	2024-08-29 16:55:40 +02:00
Michael Eischer	2c85d2468a	Merge pull request #5015 from MichaelEischer/update-exit-code-docs ... Update exit code docs	2024-08-29 16:53:14 +02:00
Michael Eischer	7bbf75237d	Merge pull request #5014 from MichaelEischer/configurable-slow-request-timeout ... Make timeout for slow requests configurable	2024-08-29 16:52:24 +02:00
Michael Eischer	dd90e1926b	use OrderedListOnceBackend where possible	2024-08-29 16:35:48 +02:00
Michael Eischer	d19f706d50	Add temporary files repositories in integration tests ... This is intended to catch problems with temporary files stored in the backend, even if the responsible component forgets to test for those.	2024-08-29 16:33:18 +02:00
Michael Eischer	8eff4e0e5c	cache: correctly ignore files whose filename is no ID ... this can for example be the case for temporary files created by the backend implementation.	2024-08-29 16:32:15 +02:00
Michael Eischer	45d05eb691	add changelog for security descriptor race condition	2024-08-26 19:43:18 +02:00
Michael Eischer	9c70794886	fs: fix error handling for retried get/set of security descriptor ... The retry code path did not filter `ERROR_NOT_SUPPORTED`. Just call the original function a second time to correctly follow the low privilege code path.	2024-08-26 19:36:43 +02:00
Michael Eischer	6fbfccc2d3	fs: fix race condition in get/set security descriptor ... Calling `Load()` twice for an atomic variable can return different values each time. This resulted in trying to read the security descriptor with high privileges, but then not entering the code path to switch to low privileges when another thread has already done so concurrently.	2024-08-26 19:31:21 +02:00
Michael Eischer	1931beab8e	Merge pull request #5012 from MichaelEischer/fix-lock-retries ... lock: introduce short delay between failed locking retries	2024-08-26 18:10:30 +02:00
Michael Eischer	2296fdf668	lock: introduce short delay between failed locking retries ... Failed locking attempts were immediately retried up to three times without any delay between the retries. If a lock file is not found while checking for other locks, with the reworked backend retries there is no delay between those retries. This is a problem if a backend requires a few seconds to reflect file deletions in the file listings. To work around this problem, introduce a short exponentially increasing delay between the retries. The number of retries is now increased to 4. This results in delays of 5, 10 and 20 seconds between the retries.	2024-08-26 16:31:42 +02:00
Michael Eischer	89d216ca76	Merge pull request #5011 from MichaelEischer/fix-canceled-retry ... backend/retry: don't trip circuit breaker if context is canceled	2024-08-26 16:30:03 +02:00
Michael Eischer	5cffd40002	Merge pull request #5013 from MichaelEischer/group-cli-commands ... Group CLI commands and show features/options	2024-08-26 16:23:39 +02:00
Michael Eischer	e24dd5a162	backend/retry: don't trip circuit breaker if context is canceled ... When the context used for a load operation is canceled, then the result is always an error independent of whether the file could be retrieved from the backend. Do not false positively trip the circuit breaker in this case. The old behavior was problematic when trying to lock a repository. When `Lock.checkForOtherLocks` listed multiple lock files in parallel and one of them fails to load, then all other loads were canceled. This cancelation was remembered by the circuit breaker, such that locking retries would fail.	2024-08-26 16:22:21 +02:00
Michael Eischer	2063bf5de4	Merge pull request #5006 from MichaelEischer/restore-time-last ... restic: restore timestamps after extended attributes	2024-08-26 16:21:02 +02:00
Michael Eischer	36c4475ad9	rest: improve handling of HTTP2 goaway ... The HTTP client can only retry HTTP2 requests after receiving a GOAWAY response if it can rewind the body. As we use a custom data type, explicitly provide an implementation of `GetBody`.	2024-08-26 15:44:17 +02:00
Michael Eischer	dc5d3fc473	doc: full tree blob data structure is in the code	2024-08-26 14:41:09 +02:00
Michael Eischer	05077eaa20	doc: JSON encoder must be deterministic	2024-08-26 14:41:09 +02:00