rawtaz
d8da9c4401
Merge pull request #2577 from alrs/fix-internal-errs
...
internal: Fix code and test dropped errors
2020-02-12 23:41:54 +01:00
rawtaz
299f5971f2
Merge pull request #2560 from brualan/master
...
Two small improvements to code quality
2020-02-12 22:40:20 +01:00
Lars Lehtonen
72734d59b5
internal/archiver: fix dropped error
2020-02-12 13:37:37 -08:00
Lars Lehtonen
3ed54e762e
internal/backend/sftp: fix dropped test error
2020-02-12 13:36:21 -08:00
Lars Lehtonen
fea835b4e2
internal/repository: fix dropped test error
2020-02-12 13:33:54 -08:00
Lars Lehtonen
16b321b140
internal/restic: fix dropped test error
2020-02-12 13:32:45 -08:00
Michael Eischer
760863e7f9
archiver: Fix TestRacyFileSwap on windows
2020-02-11 21:09:47 +01:00
Michael Eischer
a135699397
Close file if file type has changed after initial stat
2020-02-11 21:09:47 +01:00
Lars Lehtonen
57815d9cd6
restic/internal/ui: fix gofmt nit that popped up in Go 1.13
2020-02-10 11:06:47 -08:00
Daniel Hoffend
e7cdf2acbb
fix backup --json total_bytes_processed output
...
Closes #2429
2020-02-09 02:02:45 +01:00
Alexander Bruyako
38ddfbc4d3
simpler error return
2020-01-27 18:41:46 +03:00
Alexander Bruyako
da48b925ff
remove unnecessary error return
...
I was running "golangci-lint" and found this two warnings
internal/checker/checker.go:135:18: (*Checker).LoadIndex$3 - result 0 (error) is always nil (unparam)
final := func() error {
^
internal/repository/repository.go:457:18: (*Repository).LoadIndex$3 - result 0 (error) is always nil (unparam)
final := func() error {
^
It turns out that these functions are used only in "RunWorkers(...)",
which is used only two times in whole project right after this "final"
functions.
And because these "final" functions always return "nil", I've
descided, that it would be better to remove requriments for "final" func
to return error to avoid magick "return nil" at their end.
2020-01-27 18:28:21 +03:00
rawtaz
d70a4a9350
Merge pull request #2373 from vrusinov/issue-2372
...
Ignore username difference in TestMetadataChanged
2020-01-05 21:07:34 +01:00
Ward Vandewege
69a0d0ee90
fix typos
2019-12-21 21:00:28 -05:00
streambinder
97e5ce4344
internal: backend: sftp: support user@domain parsing as user
2019-12-19 13:15:37 +01:00
rawtaz
da4473aba6
Merge pull request #2391 from kastenhq/refresh-lock-time
...
Update Lock.Time in lock.Refresh()
2019-11-26 21:44:29 +01:00
rawtaz
6e85a58045
Merge pull request #2465 from whs-dot-hk/fix-test-metadata-changed
...
Fix test metadata changed
2019-11-26 21:42:42 +01:00
rawtaz
e14c4b1737
Merge pull request #2484 from restic/add-s3-region
...
s3: Allow specifying region
2019-11-22 15:51:17 +01:00
Alexander Neumann
409909a7f5
Add option description for Region
2019-11-22 15:09:09 +01:00
mdauphin
df500a372d
Add AWS_REGION env var to specify s3 region
2019-11-22 15:04:48 +01:00
Alexander Neumann
a6e8af7e0f
Update minio-go
2019-11-22 14:50:46 +01:00
rawtaz
41fe9318b1
Merge pull request #2425 from thiell/restic_cache_dir_env
...
Add support for $RESTIC_CACHE_DIR
2019-11-20 21:18:57 +01:00
Leo R. Lundgren
4d2aa18273
Accept both singular and plural for --group-by ( #2330 )
2019-11-20 19:25:48 +01:00
rawtaz
26d1f9f4ba
Merge pull request #2307 from gary-kim/fix-2306-password-retries
...
Allow multiple retries for interactive password input
2019-11-20 18:30:20 +01:00
whs
7cacba0394
Assume WithAtime default to false
2019-11-06 16:38:46 +08:00
Stephane Thiell
0e897ef7b8
Add support for $RESTIC_CACHE_DIR
...
Add support for restic-specific $RESTIC_CACHE_DIR environment variable
to override the cache directory like --cache-dir would have.
2019-09-26 15:59:56 -07:00
Eric Hamilton
1596d06f8e
Update Lock.Time in lock.Refresh()
2019-09-04 11:38:35 -07:00
Vladimir Rusinov
db20c0b8d0
Ignore username difference in TestMetadataChanged.
...
In some (rare) cases "fake" UID 51234 may exist in a system running a
test. When this is the case, `cmp.Equal(want, node3)` will fail based on
difference between empty string and an actual username present in a
system.
Fixes github issue #2372
2019-08-13 22:25:00 +01:00
Alexander Neumann
01c51b3449
Merge pull request #2321 from restic/fix-index-error-handling
...
Check errors returned by LoadIndex()
2019-07-27 09:37:18 +02:00
Alexandr Bruyako
e19622e4b1
start using fileMode const
2019-07-01 00:26:00 +03:00
Alexandr Bruyako
38ea7ed4f6
remove unused code
2019-07-01 00:24:45 +03:00
Alexandr Bruyako
76d1866444
avoiding unnecessary type conversions
2019-06-30 23:58:00 +03:00
Alexandr Bruyako
8b22fe29cf
improved slice copying
2019-06-30 23:56:36 +03:00
Alexandr Bruyako
02014be76c
simplified prefix removal, removed unnecessary if-else statements
2019-06-30 23:34:47 +03:00
Alexandr Bruyako
16eeed2ad5
simplified string sorting by using a more suitable function
2019-06-30 23:20:32 +03:00
Alexander Neumann
88716794e3
Check errors returned by LoadIndex()
...
Bug was reported in the forum here: https://forum.restic.net/t/check-rebuild-index-prune/1848/13
2019-06-30 21:34:53 +02:00
Gary Kim
fea2464d4d
Allow multiple retries for interactive password input
...
Restic used to quit if the repository password was typed incorrectly once.
Restic will now ask the user again for the repository password if typed incorrectly.
The user will now get three tries to input the correct password before restic quits.
2019-06-13 20:11:02 +08:00
Garry McNulty
8066195e6e
fs: Handle absolute pathname for --stdin-filename
...
Return valid directory info from Lstat() for parent directories of the
specified filename. Previously only "/" and "." were valid directories.
Also set directory mode as this is checked by archiver.
Closes #2063
2019-05-08 15:21:27 +02:00
Garry McNulty
f7f14cf8c9
fs: Add file info base name check in reader tests ( #2063 )
2019-05-08 15:21:27 +02:00
Garry McNulty
5096f3b491
fs: Update directory check in reader tests ( #2063 )
2019-05-08 15:21:27 +02:00
Alexander Neumann
920d458a4a
archiver: Use untyped constants for testing FileInfo
2019-05-05 14:57:38 +02:00
Alexander Neumann
b016dc2ff0
archiver/Windows: Skip test new-content-same-filestamp
2019-05-05 14:02:11 +02:00
Alexander Neumann
355db0bc29
windows: Use LastWriteTime for ctime and mtime
...
Windows does not have a concept of a `change time` in the sense as Unix
has it: the field `CreationTime` of the `Win32FileAttributeData` struct
is not updated when attributes or content is changed. So from now on
we're using the `LastWriteTime` as the `change time` on Windows.
2019-05-05 14:02:11 +02:00
Alexander Neumann
6e2fe73189
archiver: Move tests back into the same file
...
Move all Archiver tests back into `archiver_test.go` and add some tiny
helpers to mock what `lstat` returns (for Windows and Unix separately).
2019-05-05 14:02:11 +02:00
Alexander Neumann
303a5dab6a
archiver: Clarify value in test struct
...
Since I could not remember what the value for `Check` means this commit
renames it to `SameFile`: when set to true, the test should make sure
that `FileChanged` should return false (=file is unmodified).
2019-05-05 12:57:00 +02:00
Gábor Lipták
bce6438d22
Don't run TestMetadataChanged test on Windows
...
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
2019-04-27 21:23:47 -04:00
Alexander Neumann
919dd2ac84
Merge pull request #2252 from restic/fix-2249
...
Read fresh metadata for unmodified files
2019-04-25 09:15:50 +02:00
Alexander Neumann
870bc5108e
Merge pull request #2253 from restic/fix-2174
...
Make sure timestamps are valid
2019-04-25 09:14:43 +02:00
Alexander Neumann
a6481b3707
Merge pull request #2212 from cbane/check-ctime
...
Examine file ctime when checking if files have changed.
2019-04-25 08:58:27 +02:00
Courtney Bane
0ebfc55ee3
Use existing setTimestamp function for ctime test and improve error checking.
2019-04-24 20:53:08 -05:00