mirror of
https://github.com/octoleo/restic.git
synced 2024-12-23 03:18:55 +00:00
8d0ba55ecd
When the backup is interrupted for some reason while the scanner is still active this could lead to a deadlock. Interruptions are triggered by canceling the context object used by both the backup progress UI and the scanner. It is possible that a context is canceled between the respective check in the scanner and it calling the `ReportTotal` method of the UI. The latter method sends a message to the UI goroutine. However, a canceled context will also stop that goroutine, which can cause the channel send operation to block indefinitely. This is resolved by adding a `closed` channel which is closed once the UI goroutine is stopped and serves as an escape hatch for reported UI updates. This change covers not just the ReportTotal method but all potentially affected methods of the progress UI implementation.
8 lines
277 B
Plaintext
8 lines
277 B
Plaintext
Bugfix: Fix rare cases of backup command hanging forever
|
|
|
|
We've fixed an issue with the backup progress reporting which could cause
|
|
restic to hang forever right before finishing a backup.
|
|
|
|
https://github.com/restic/restic/issues/2834
|
|
https://github.com/restic/restic/pull/2963
|