mirror of
https://github.com/octoleo/restic.git
synced 2024-11-25 22:27:35 +00:00
b4de902596
After reading and chunking all data in a file, the FutureFile still has to wait until the FutureBlobs are completed. This was done synchronously which results in blocking the file saver and prevents the next file from being read. By replacing the FutureBlob with a callback, it becomes possible to complete the FutureFile asynchronously.
159 lines
3.3 KiB
Go
159 lines
3.3 KiB
Go
package archiver
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"runtime"
|
|
"testing"
|
|
|
|
"github.com/restic/restic/internal/errors"
|
|
"github.com/restic/restic/internal/restic"
|
|
"github.com/restic/restic/internal/test"
|
|
"golang.org/x/sync/errgroup"
|
|
)
|
|
|
|
func treeSaveHelper(ctx context.Context, t restic.BlobType, buf *Buffer, cb func(res SaveBlobResponse)) {
|
|
cb(SaveBlobResponse{
|
|
id: restic.NewRandomID(),
|
|
known: false,
|
|
length: len(buf.Data),
|
|
sizeInRepo: len(buf.Data),
|
|
})
|
|
}
|
|
|
|
func setupTreeSaver() (context.Context, context.CancelFunc, *TreeSaver, func() error) {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
wg, ctx := errgroup.WithContext(ctx)
|
|
|
|
errFn := func(snPath string, err error) error {
|
|
return err
|
|
}
|
|
|
|
b := NewTreeSaver(ctx, wg, uint(runtime.NumCPU()), treeSaveHelper, errFn)
|
|
|
|
shutdown := func() error {
|
|
b.TriggerShutdown()
|
|
return wg.Wait()
|
|
}
|
|
|
|
return ctx, cancel, b, shutdown
|
|
}
|
|
|
|
func TestTreeSaver(t *testing.T) {
|
|
ctx, cancel, b, shutdown := setupTreeSaver()
|
|
defer cancel()
|
|
|
|
var results []FutureNode
|
|
|
|
for i := 0; i < 20; i++ {
|
|
node := &restic.Node{
|
|
Name: fmt.Sprintf("file-%d", i),
|
|
}
|
|
|
|
fb := b.Save(ctx, join("/", node.Name), node.Name, node, nil, nil)
|
|
results = append(results, fb)
|
|
}
|
|
|
|
for _, tree := range results {
|
|
tree.take(ctx)
|
|
}
|
|
|
|
err := shutdown()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestTreeSaverError(t *testing.T) {
|
|
var tests = []struct {
|
|
trees int
|
|
failAt int
|
|
}{
|
|
{1, 1},
|
|
{20, 2},
|
|
{20, 5},
|
|
{20, 15},
|
|
{200, 150},
|
|
}
|
|
|
|
errTest := errors.New("test error")
|
|
|
|
for _, test := range tests {
|
|
t.Run("", func(t *testing.T) {
|
|
ctx, cancel, b, shutdown := setupTreeSaver()
|
|
defer cancel()
|
|
|
|
var results []FutureNode
|
|
|
|
for i := 0; i < test.trees; i++ {
|
|
node := &restic.Node{
|
|
Name: fmt.Sprintf("file-%d", i),
|
|
}
|
|
nodes := []FutureNode{
|
|
newFutureNodeWithResult(futureNodeResult{node: &restic.Node{
|
|
Name: fmt.Sprintf("child-%d", i),
|
|
}}),
|
|
}
|
|
if (i + 1) == test.failAt {
|
|
nodes = append(nodes, newFutureNodeWithResult(futureNodeResult{
|
|
err: errTest,
|
|
}))
|
|
}
|
|
|
|
fb := b.Save(ctx, join("/", node.Name), node.Name, node, nodes, nil)
|
|
results = append(results, fb)
|
|
}
|
|
|
|
for _, tree := range results {
|
|
tree.take(ctx)
|
|
}
|
|
|
|
err := shutdown()
|
|
if err == nil {
|
|
t.Errorf("expected error not found")
|
|
}
|
|
if err != errTest {
|
|
t.Fatalf("unexpected error found: %v", err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestTreeSaverDuplicates(t *testing.T) {
|
|
for _, identicalNodes := range []bool{true, false} {
|
|
t.Run("", func(t *testing.T) {
|
|
ctx, cancel, b, shutdown := setupTreeSaver()
|
|
defer cancel()
|
|
|
|
node := &restic.Node{
|
|
Name: "file",
|
|
}
|
|
nodes := []FutureNode{
|
|
newFutureNodeWithResult(futureNodeResult{node: &restic.Node{
|
|
Name: "child",
|
|
}}),
|
|
}
|
|
if identicalNodes {
|
|
nodes = append(nodes, newFutureNodeWithResult(futureNodeResult{node: &restic.Node{
|
|
Name: "child",
|
|
}}))
|
|
} else {
|
|
nodes = append(nodes, newFutureNodeWithResult(futureNodeResult{node: &restic.Node{
|
|
Name: "child",
|
|
Size: 42,
|
|
}}))
|
|
}
|
|
|
|
fb := b.Save(ctx, join("/", node.Name), node.Name, node, nodes, nil)
|
|
fb.take(ctx)
|
|
|
|
err := shutdown()
|
|
if identicalNodes {
|
|
test.Assert(t, err == nil, "unexpected error found: %v", err)
|
|
} else {
|
|
test.Assert(t, err != nil, "expected error not found")
|
|
}
|
|
})
|
|
}
|
|
}
|