mirror of
https://github.com/octoleo/restic.git
synced 2024-11-30 08:44:02 +00:00
f7587be28f
Bug #1681 suggests that restic should not be nice to user and should refrain from creating a mountpoint if it does not exist. Nevertheless, it currently opens the repository before checking for the mountpoint's existence. In the case of large or remote repositories, this process can be time-consuming, delaying the inevitable outcome. /restic mount --repo=REMOTE --verbose /tmp/backup repository 33f14e42 opened (version 2, compression level max) [0:38] 100.00% 162 / 162 index files loaded Mountpoint /tmp/backup doesn't exist stat /tmp/backup: no such file or directory real 0m39.534s user 1m53.961s sys 0m3.044s In this scenario, 40 seconds could have been saved if the nonexistence of the path had been verified beforehand. This patch relocates the mountpoint check to the beginning of the runMount function, preceding the opening of the repository. /restic mount --repo=REMOTE --verbose /tmp/backup Mountpoint /tmp/backup doesn't exist stat /tmp/backup: no such file or directory real 0m0.136s user 0m0.018s sys 0m0.027s Signed-off-by: Sébastien Gross <seb•ɑƬ•chezwam•ɖɵʈ•org>
8 lines
264 B
Plaintext
8 lines
264 B
Plaintext
Enhancement: `mount` tests mountpoint existence before opening the repository
|
|
|
|
The restic `mount` command now checks for the existence of the
|
|
mountpoint before opening the repository, leading to quicker error
|
|
detection.
|
|
|
|
https://github.com/restic/restic/pull/4590
|