restic/pull-4958 at 7739aa685c16acf9aac325e96f24ae5db92d4c1e - restic - Vast Development Method

octoleo/restic

mirror of https://github.com/octoleo/restic.git synced 2024-11-30 08:44:02 +00:00

Michael Terry 6a97833337 restore: clean up error handling when restoring metadata

- Fix a logic error that instead of reporting the *first*
  metadata-setting error that appears, we were instead reporting the
  *last* error (and only if the lchown call failed!).
- Don't show any errors when setting metadata for files in non-root
  mode (things like timestamps, attributes). Previously, only lchown
  errors were skipped. But other kinds of attribute errors make sense
  to skip as well. The code path happened to work correctly before
  because of the above logic error. But once that was fixed, this
  change needed to happen too.

2024-07-30 19:27:34 -04:00

8 lines

308 B

Plaintext

Raw Blame History

 Bugfix: Don't ignore metadata-setting errors during restore
 Restic was accidentally ignoring errors when setting timestamps,
 attributes, or file modes during restore. It will now report those
 errors (unless it's just a permission error when not running as root).
 https://github.com/restic/restic/pull/4958