mirror of
https://github.com/octoleo/restic.git
synced 2024-11-16 18:15:20 +00:00
b8acad4da0
When rclone fails during the connection setup this currently often results in a context canceled error. Replace this error with the exit code from rclone.
57 lines
1.1 KiB
Go
57 lines
1.1 KiB
Go
package rclone
|
|
|
|
import (
|
|
"context"
|
|
"os/exec"
|
|
"testing"
|
|
|
|
"github.com/restic/restic/internal/errors"
|
|
"github.com/restic/restic/internal/restic"
|
|
rtest "github.com/restic/restic/internal/test"
|
|
)
|
|
|
|
// restic should detect rclone exiting.
|
|
func TestRcloneExit(t *testing.T) {
|
|
dir, cleanup := rtest.TempDir(t)
|
|
defer cleanup()
|
|
|
|
cfg := NewConfig()
|
|
cfg.Remote = dir
|
|
be, err := Open(cfg, nil)
|
|
var e *exec.Error
|
|
if errors.As(err, &e) && e.Err == exec.ErrNotFound {
|
|
t.Skipf("program %q not found", e.Name)
|
|
return
|
|
}
|
|
rtest.OK(t, err)
|
|
defer func() {
|
|
// ignore the error as the test will kill rclone (see below)
|
|
_ = be.Close()
|
|
}()
|
|
|
|
err = be.cmd.Process.Kill()
|
|
rtest.OK(t, err)
|
|
t.Log("killed rclone")
|
|
|
|
for i := 0; i < 10; i++ {
|
|
_, err = be.Stat(context.TODO(), restic.Handle{
|
|
Name: "foo",
|
|
Type: restic.PackFile,
|
|
})
|
|
rtest.Assert(t, err != nil, "expected an error")
|
|
}
|
|
}
|
|
|
|
// restic should detect rclone startup failures
|
|
func TestRcloneFailedStart(t *testing.T) {
|
|
cfg := NewConfig()
|
|
// exits with exit code 1
|
|
cfg.Program = "false"
|
|
_, err := Open(cfg, nil)
|
|
var e *exec.ExitError
|
|
if !errors.As(err, &e) {
|
|
// unexpected error
|
|
rtest.OK(t, err)
|
|
}
|
|
}
|