2
2
mirror of https://github.com/octoleo/restic.git synced 2024-06-18 08:42:22 +00:00
restic/cmd/restic/cmd_repair_snapshots.go
Michael Eischer 8c4caf09a8 repair snapshots: Do not rename repaired files
The files in a tree must be sorted in lexical order. However, this
cannot be guaranteed when appending a filename suffix. For two files

file, file.rep

where "file" is broken, this would result in

file.repaired, file.rep

which is no longer sorted.

In addition, adding a filename suffix is also prone to filename
collisions which would require a rather complex search for a
collision-free name in order to work reliably.
2023-05-01 15:19:36 +02:00

297 lines
8.2 KiB
Go

package main
import (
"context"
"github.com/restic/restic/internal/backend"
"github.com/restic/restic/internal/debug"
"github.com/restic/restic/internal/restic"
"golang.org/x/sync/errgroup"
"github.com/spf13/cobra"
)
var cmdRepairSnapshots = &cobra.Command{
Use: "snapshots [flags] [snapshot ID] [...]",
Short: "Repair snapshots",
Long: `
The "repair snapshots" command allows to repair broken snapshots.
It scans the given snapshots and generates new ones where
damaged tress and file contents are removed.
If the broken snapshots are deleted, a prune run will
be able to refit the repository.
The command depends on a good state of the index, so if
there are inaccurancies in the index, make sure to run
"repair index" before!
WARNING:
========
Repairing and deleting broken snapshots causes data loss!
It will remove broken dirs and modify broken files in
the modified snapshots.
If the contents of directories and files are still available,
the better option is to redo a backup which in that case is
able to "heal" already present snapshots.
Only use this command if you need to recover an old and
broken snapshot!
EXIT STATUS
===========
Exit status is 0 if the command was successful, and non-zero if there was any error.
`,
DisableAutoGenTag: true,
RunE: func(cmd *cobra.Command, args []string) error {
return runRepairSnapshots(cmd.Context(), globalOptions, repairSnapshotOptions, args)
},
}
// RepairOptions collects all options for the repair command.
type RepairOptions struct {
DryRun bool
Forget bool
restic.SnapshotFilter
}
var repairSnapshotOptions RepairOptions
func init() {
cmdRepair.AddCommand(cmdRepairSnapshots)
flags := cmdRepairSnapshots.Flags()
flags.BoolVarP(&repairSnapshotOptions.DryRun, "dry-run", "n", false, "do not do anything, just print what would be done")
flags.BoolVarP(&repairSnapshotOptions.Forget, "forget", "", false, "remove original snapshots after creating new ones")
initMultiSnapshotFilter(flags, &repairSnapshotOptions.SnapshotFilter, true)
}
func runRepairSnapshots(ctx context.Context, gopts GlobalOptions, opts RepairOptions, args []string) error {
repo, err := OpenRepository(ctx, globalOptions)
if err != nil {
return err
}
if !opts.DryRun {
var lock *restic.Lock
var err error
lock, ctx, err = lockRepoExclusive(ctx, repo, gopts.RetryLock, gopts.JSON)
defer unlockRepo(lock)
if err != nil {
return err
}
} else {
repo.SetDryRun()
}
snapshotLister, err := backend.MemorizeList(ctx, repo.Backend(), restic.SnapshotFile)
if err != nil {
return err
}
if err := repo.LoadIndex(ctx); err != nil {
return err
}
// get snapshots to check & repair
var snapshots []*restic.Snapshot
for sn := range FindFilteredSnapshots(ctx, snapshotLister, repo, &opts.SnapshotFilter, args) {
snapshots = append(snapshots, sn)
}
return repairSnapshots(ctx, opts, repo, snapshots)
}
func repairSnapshots(ctx context.Context, opts RepairOptions, repo restic.Repository, snapshots []*restic.Snapshot) error {
replaces := make(idMap)
seen := restic.NewIDSet()
deleteSn := restic.NewIDSet()
Verbosef("check and repair %d snapshots\n", len(snapshots))
bar := newProgressMax(!globalOptions.Quiet, uint64(len(snapshots)), "snapshots")
wg, ctx := errgroup.WithContext(ctx)
repo.StartPackUploader(ctx, wg)
wg.Go(func() error {
for _, sn := range snapshots {
debug.Log("process snapshot %v", sn.ID())
Printf("%v:\n", sn)
newID, changed, lErr, err := repairTree(ctx, opts, repo, "/", sn.Tree, replaces, seen)
switch {
case err != nil:
return err
case lErr:
Printf("the root tree is damaged -> delete snapshot.\n")
deleteSn.Insert(*sn.ID())
case changed:
err = changeSnapshot(ctx, opts.DryRun, repo, sn, newID)
if err != nil {
return err
}
deleteSn.Insert(*sn.ID())
default:
Printf("is ok.\n")
}
debug.Log("processed snapshot %v", sn.ID())
bar.Add(1)
}
bar.Done()
return repo.Flush(ctx)
})
err := wg.Wait()
if err != nil {
return err
}
if len(deleteSn) > 0 && opts.Forget {
Verbosef("delete %d snapshots...\n", len(deleteSn))
if !opts.DryRun {
DeleteFiles(ctx, globalOptions, repo, deleteSn, restic.SnapshotFile)
}
}
return nil
}
// changeSnapshot creates a modified snapshot:
// - set the tree to newID
// - add the rag opts.AddTag
// - preserve original ID
// if opts.DryRun is set, it doesn't change anything but only
func changeSnapshot(ctx context.Context, dryRun bool, repo restic.Repository, sn *restic.Snapshot, newID *restic.ID) error {
sn.AddTags([]string{"repaired"})
// Always set the original snapshot id as this essentially a new snapshot.
sn.Original = sn.ID()
sn.Tree = newID
if !dryRun {
newID, err := restic.SaveSnapshot(ctx, repo, sn)
if err != nil {
return err
}
Printf("snapshot repaired -> %v created.\n", newID.Str())
} else {
Printf("would have repaired snapshot %v.\n", sn.ID().Str())
}
return nil
}
type idMap map[restic.ID]restic.ID
// repairTree checks and repairs a tree and all its subtrees
// Three error cases are checked:
// - tree is a nil tree (-> will be replaced by an empty tree)
// - trees which cannot be loaded (-> the tree contents will be removed)
// - files whose contents are not fully available (-> file will be modified)
// In case of an error, the changes made depends on:
// - opts.Append: string to append to "repared" names; if empty files will not repaired but deleted
// - opts.DryRun: if set to true, only print out what to but don't change anything
// Returns:
// - the new ID
// - whether the ID changed
// - whether there was a load error when loading this tre
// - error for other errors (these are errors when saving a tree)
func repairTree(ctx context.Context, opts RepairOptions, repo restic.Repository, path string, treeID *restic.ID, replaces idMap, seen restic.IDSet) (*restic.ID, bool, bool, error) {
// handle and repair nil trees
if treeID == nil {
empty, err := emptyTree(ctx, repo, opts.DryRun)
Printf("repaired nil tree '%v'\n", path)
return &empty, true, false, err
}
// check if tree was already changed
newID, ok := replaces[*treeID]
if ok {
return &newID, true, false, nil
}
// check if tree was seen but not changed
if seen.Has(*treeID) {
return treeID, false, false, nil
}
tree, err := restic.LoadTree(ctx, repo, *treeID)
if err != nil {
// mark as load error
return &newID, false, true, nil
}
var newNodes []*restic.Node
changed := false
for _, node := range tree.Nodes {
switch node.Type {
case "file":
ok := true
var newContent restic.IDs
var newSize uint64
// check all contents and remove if not available
for _, id := range node.Content {
if size, found := repo.LookupBlobSize(id, restic.DataBlob); !found {
ok = false
} else {
newContent = append(newContent, id)
newSize += uint64(size)
}
}
if !ok {
changed = true
if newSize == 0 {
Printf("removed defective file '%v'\n", path+node.Name)
continue
}
Printf("repaired defective file '%v'\n", path+node.Name)
node.Content = newContent
node.Size = newSize
}
case "dir":
// rewrite if necessary
newID, c, lErr, err := repairTree(ctx, opts, repo, path+node.Name+"/", node.Subtree, replaces, seen)
switch {
case err != nil:
return newID, true, false, err
case lErr:
// If we get an error, we remove this subtree
changed = true
Printf("replaced defective dir '%v'", path+node.Name)
empty, err := emptyTree(ctx, repo, opts.DryRun)
if err != nil {
return newID, true, false, err
}
node.Subtree = &empty
case c:
node.Subtree = newID
changed = true
}
}
newNodes = append(newNodes, node)
}
if !changed {
seen.Insert(*treeID)
return treeID, false, false, nil
}
tree.Nodes = newNodes
if !opts.DryRun {
newID, err = restic.SaveTree(ctx, repo, tree)
if err != nil {
return &newID, true, false, err
}
Printf("modified tree %v, new id: %v\n", treeID.Str(), newID.Str())
} else {
Printf("would have modified tree %v\n", treeID.Str())
}
replaces[*treeID] = newID
return &newID, true, false, nil
}
func emptyTree(ctx context.Context, repo restic.Repository, dryRun bool) (restic.ID, error) {
if !dryRun {
return restic.SaveTree(ctx, repo, &restic.Tree{})
}
return restic.ID{}, nil
}