Michael Eischer ce89018902 Fix data race in blob_saver ... After the `BlobSaver` job is submitted, the buffer can be released and reused by another `FileSaver` even before `BlobSaver.Save` returns. That FileSaver will the change `buf.Data` leading to wrong backup statistics. Found by `go test -race ./...`: WARNING: DATA RACE Write at 0x00c0000784a0 by goroutine 41: github.com/restic/restic/internal/archiver.(*FileSaver).saveFile() /home/michael/Projekte/restic/restic/internal/archiver/file_saver.go:176 +0x789 github.com/restic/restic/internal/archiver.(*FileSaver).worker() /home/michael/Projekte/restic/restic/internal/archiver/file_saver.go:242 +0x2af github.com/restic/restic/internal/archiver.NewFileSaver.func2() /home/michael/Projekte/restic/restic/internal/archiver/file_saver.go:88 +0x5d golang.org/x/sync/errgroup.(*Group).Go.func1() /home/michael/go/pkg/mod/golang.org/x/sync@v0.0.0-20210220032951-036812b2e83c/errgroup/errgroup.go:57 +0x91 Previous read at 0x00c0000784a0 by goroutine 29: github.com/restic/restic/internal/archiver.(*BlobSaver).Save() /home/michael/Projekte/restic/restic/internal/archiver/blob_saver.go:57 +0x1dd github.com/restic/restic/internal/archiver.(*BlobSaver).Save-fm() <autogenerated>:1 +0xac github.com/restic/restic/internal/archiver.(*FileSaver).saveFile() /home/michael/Projekte/restic/restic/internal/archiver/file_saver.go:191 +0x855 github.com/restic/restic/internal/archiver.(*FileSaver).worker() /home/michael/Projekte/restic/restic/internal/archiver/file_saver.go:242 +0x2af github.com/restic/restic/internal/archiver.NewFileSaver.func2() /home/michael/Projekte/restic/restic/internal/archiver/file_saver.go:88 +0x5d golang.org/x/sync/errgroup.(*Group).Go.func1() /home/michael/go/pkg/mod/golang.org/x/sync@v0.0.0-20210220032951-036812b2e83c/errgroup/errgroup.go:57 +0x91		2022-07-03 14:47:53 +02:00
..
archiver	Fix data race in blob_saver	2022-07-03 14:47:53 +02:00
backend	Merge pull request #3470 from MichaelEischer/sanitize-debug-log	2022-07-02 19:00:54 +02:00
bloblru	bloblru: Fix comment for New function	2022-03-28 22:25:25 +02:00
cache	cache: Don't Lstat before creating the tag file	2022-05-10 18:52:39 +02:00
checker	adapt workers based on whether an operation is CPU or IO-bound	2022-07-03 12:19:26 +02:00
crypto
debug	redact swift auth token in debug output	2022-07-02 18:47:35 +02:00
dump	Refactor internal/dump + concurrent load/write	2021-11-01 23:01:55 +01:00
errors	all: Move away from pkg/errors, easy cases	2022-06-14 08:36:38 +02:00
filter	Add tests for validating exclude patterns	2022-05-11 22:41:00 +02:00
fs	Add simple test for fs.TempFile on windows	2022-04-09 23:37:58 +02:00
fuse	copy/find/ls/recover/stats: Memorize snapshot listing before index	2022-04-09 12:26:30 +02:00
hashing	hashing: Fix up comments	2022-05-11 21:36:10 +02:00
limiter	cmd/restic, limiter: Move config knowledge to internal packages	2022-06-22 18:29:58 +02:00
migrations	migrate: Cleanup option to request repository check	2022-06-04 23:45:00 +02:00
mock	upgrade_repo_v2: Use atomic replace for supported backends	2022-05-09 22:31:30 +02:00
options	Don't crash if SecretString is uninitialized	2022-07-02 19:44:28 +02:00
pack	repository: Rework blob saving to use an async pack uploader	2022-07-02 22:42:34 +02:00
repository	adapt workers based on whether an operation is CPU or IO-bound	2022-07-03 12:19:26 +02:00
restic	adapt workers based on whether an operation is CPU or IO-bound	2022-07-03 12:19:26 +02:00
restorer	adapt workers based on whether an operation is CPU or IO-bound	2022-07-03 12:19:26 +02:00
selfupdate	Refactor file handing for self-update.	2022-04-09 21:40:33 +02:00
test	all: Move away from pkg/errors, easy cases	2022-06-14 08:36:38 +02:00
textfile
ui	Print number of bytes added to the repo	2022-07-02 18:55:12 +02:00
walker	adapt workers based on whether an operation is CPU or IO-bound	2022-07-03 12:19:26 +02:00