2
2
mirror of https://github.com/octoleo/restic.git synced 2024-12-23 03:18:55 +00:00
restic/internal
Michael Pratt 9fa4f5eb6b gs: disable resumable uploads
By default, the GCS Go packages have an internal "chunk size" of 8MB,
used for blob uploads.

Media().Do() will buffer a full 8MB from the io.Reader (or less if EOF
is reached) then write that full 8MB to the network all at once.

This behavior does not play nicely with --limit-upload, which only
limits the Reader passed to Media. While the long-term average upload
rate will be correctly limited, the actual network bandwidth will be
very spikey.

e.g., if an 8MB/s connection is limited to 1MB/s, Media().Do() will
spend 8s reading from the rate-limited reader (performing no network
requests), then 1s writing to the network at 8MB/s.

This is bad for network connections hurt by full-speed uploads,
particularly when writing 8MB will take several seconds.

Disable resumable uploads entirely by setting the chunk size to zero.
This causes the io.Reader to be passed further down the request stack,
where there is less (but still some) buffering.

My connection is around 1.5MB/s up, with nominal ~15ms ping times to
8.8.8.8.

Without this change, --limit-upload 1024 results in several seconds of
~200ms ping times (uploading), followed by several seconds of ~15ms ping
times (reading from rate-limited reader). A bandwidth monitor reports
this as several seconds of ~1.5MB/s followed by several seconds of
0.0MB/s.

With this change, --limit-upload 1024 results in ~20ms ping times and
the bandwidth monitor reports a constant ~1MB/s.

I've elected to make this change unconditional of --limit-upload because
the resumable uploads shouldn't be providing much benefit anyways, as
restic already uploads mostly small blobs and already has a retry
mechanism.

--limit-download is not affected by this problem, as Get().Download()
returns the real http.Response.Body without any internal buffering.

Updates #1216
2017-10-17 21:12:04 -07:00
..
archiver Remove all dot-imports 2017-10-02 15:06:39 +02:00
backend gs: disable resumable uploads 2017-10-17 21:12:04 -07:00
cache cache: Refuse to cache truncated files 2017-10-05 20:40:02 +02:00
checker tests updated 2017-09-09 13:26:35 +02:00
crypto Remove all dot-imports 2017-10-02 15:06:39 +02:00
debug Run goimports 2017-07-23 14:21:03 +02:00
errors Moves files 2017-07-23 14:19:13 +02:00
filter filter: document recursive wildcards 2017-09-04 14:38:48 -07:00
fs local: Fix creating data dirs 2017-09-11 21:48:25 +02:00
fuse fuse: bugfix: ignore empty tags 2017-10-16 16:22:08 +02:00
hashing Moves files 2017-07-23 14:19:13 +02:00
index Move restic package to internal/restic 2017-07-24 17:43:32 +02:00
limiter Basic rate limiting implementation. 2017-10-11 20:01:20 -07:00
list Move restic package to internal/restic 2017-07-24 17:43:32 +02:00
migrations Move restic package to internal/restic 2017-07-24 17:43:32 +02:00
mock Move restic package to internal/restic 2017-07-24 17:43:32 +02:00
options Run goimports 2017-07-23 14:21:03 +02:00
pack Remove all dot-imports 2017-10-02 15:06:39 +02:00
pipe Remove all dot-imports 2017-10-02 15:06:39 +02:00
repository Remove Deleter interface 2017-10-14 16:04:29 +02:00
restic Remove Deleter interface 2017-10-14 16:04:29 +02:00
test internal: check error before deferring file Close() 2017-08-13 19:28:13 +02:00
walk Remove all dot-imports 2017-10-02 15:06:39 +02:00
worker Run goimports 2017-07-23 14:21:03 +02:00