mirror of
https://github.com/octoleo/restic.git
synced 2024-11-27 15:26:37 +00:00
a0885d5d69
Since 0.15 (#4020), inodes are generated as hashes of names, xor'd with the parent inode. That means that the inode of a/b/b is h(a/b/b) = h(a) ^ h(b) ^ h(b) = h(a). I.e., the grandchild has the same inode as the grandparent. GNU find trips over this because it thinks it has encountered a loop in the filesystem, and fails to search a/b/b. This happens more generally when the same name occurs an even number of times. Fix this by multiplying the parent by a large prime, so the combining operation is not longer symmetric in its arguments. This is what the FNV hash does, which we used prior to 0.15. The hash is now h(a/b/b) = h(b) ^ p*(h(b) ^ p*h(a)) Note that we already ensure that h(x) is never zero. Collisions can still occur, but they should be much less likely to occur within a single path. Fixes #4253.
47 lines
1.2 KiB
Go
47 lines
1.2 KiB
Go
//go:build darwin || freebsd || linux
|
|
// +build darwin freebsd linux
|
|
|
|
package fuse
|
|
|
|
import (
|
|
"encoding/binary"
|
|
|
|
"github.com/cespare/xxhash/v2"
|
|
"github.com/restic/restic/internal/restic"
|
|
)
|
|
|
|
const prime = 11400714785074694791 // prime1 from xxhash.
|
|
|
|
// inodeFromName generates an inode number for a file in a meta dir.
|
|
func inodeFromName(parent uint64, name string) uint64 {
|
|
inode := prime*parent ^ xxhash.Sum64String(cleanupNodeName(name))
|
|
|
|
// Inode 0 is invalid and 1 is the root. Remap those.
|
|
if inode < 2 {
|
|
inode += 2
|
|
}
|
|
return inode
|
|
}
|
|
|
|
// inodeFromNode generates an inode number for a file within a snapshot.
|
|
func inodeFromNode(parent uint64, node *restic.Node) (inode uint64) {
|
|
if node.Links > 1 && node.Type != "dir" {
|
|
// If node has hard links, give them all the same inode,
|
|
// irrespective of the parent.
|
|
var buf [16]byte
|
|
binary.LittleEndian.PutUint64(buf[:8], node.DeviceID)
|
|
binary.LittleEndian.PutUint64(buf[8:], node.Inode)
|
|
inode = xxhash.Sum64(buf[:])
|
|
} else {
|
|
// Else, use the name and the parent inode.
|
|
// node.{DeviceID,Inode} may not even be reliable.
|
|
inode = prime*parent ^ xxhash.Sum64String(cleanupNodeName(node.Name))
|
|
}
|
|
|
|
// Inode 0 is invalid and 1 is the root. Remap those.
|
|
if inode < 2 {
|
|
inode += 2
|
|
}
|
|
return inode
|
|
}
|