From 0623f3603fc93256e2aa702b138ab5b2dd80bc0a Mon Sep 17 00:00:00 2001
From: Andrew Gaul <andrew@gaul.org>
Date: Mon, 21 Aug 2023 10:53:49 +0900
Subject: [PATCH] Replace uses of emplace with operator=(&&)

emplace does not overwrite the value if the key already exists.  C++17 has
insert_or_assign but C++11 only has operator= which invokes the default
constructor.  Follows on to 6781ef5bd1a86b39469366307b582f342c945c71.
---
 src/cache.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/cache.cpp b/src/cache.cpp
index 387d877..64c4ecb 100644
--- a/src/cache.cpp
+++ b/src/cache.cpp
@@ -389,10 +389,10 @@ bool StatCache::AddStat(const std::string& key, const headers_t& meta, bool forc
     // add
     AutoLock lock(&StatCache::stat_cache_lock);
 
-    std::pair<stat_cache_t::iterator, bool> pair = stat_cache.emplace(key, std::move(ent));
+    const auto& value = stat_cache[key] = std::move(ent);
 
     // check symbolic link cache
-    if(!S_ISLNK(pair.first->second.stbuf.st_mode)){
+    if(!S_ISLNK(value.stbuf.st_mode)){
         if(symlink_cache.end() != symlink_cache.find(key)){
             // if symbolic link cache has key, thus remove it.
             DelSymlink(key.c_str(), AutoLock::ALREADY_LOCKED);
@@ -491,7 +491,7 @@ bool StatCache::AddNoObjectCache(const std::string& key)
     // add
     AutoLock lock(&StatCache::stat_cache_lock);
 
-    stat_cache.emplace(key, std::move(ent));
+    stat_cache[key] = std::move(ent);
 
     // check symbolic link cache
     if(symlink_cache.end() != symlink_cache.find(key)){
@@ -677,7 +677,7 @@ bool StatCache::AddSymlink(const std::string& key, const std::string& value)
     // add
     AutoLock lock(&StatCache::stat_cache_lock);
 
-    symlink_cache.emplace(key, std::move(ent));
+    symlink_cache[key] = std::move(ent);
 
     return true;
 }