octoleo/s3fs-fuse
1
0
Fork 0
mirror of https://github.com/s3fs-fuse/s3fs-fuse.git synced 2025-01-03 05:00:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address clang-tidy 17 warnings (#2362)

Browse Source
This commit is contained in:
Andrew Gaul 2023-11-12 11:48:08 +09:00 committed by GitHub
parent 807ec1f6f7
commit 0cd73e406d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.clang-tidy
View File

@ -36,6 +36,7 @@ Checks: '
-google-runtime-references, -google-runtime-references,
misc-*, misc-*,
-misc-const-correctness, -misc-const-correctness,
-misc-include-cleaner,
-misc-no-recursion, -misc-no-recursion,
-misc-redundant-expression, -misc-redundant-expression,
-misc-unused-parameters, -misc-unused-parameters,
@ -52,6 +53,7 @@ Checks: '
-modernize-use-trailing-return-type, -modernize-use-trailing-return-type,
-modernize-use-using, -modernize-use-using,
performance-*, performance-*,
-performance-avoid-endl,
-performance-no-int-to-ptr, -performance-no-int-to-ptr,
portability-*, portability-*,
readability-*, readability-*,

5
src/curl.cpp
View File

@ -2139,7 +2139,10 @@ bool S3fsCurl::RemakeHandle()
// rewind file // rewind file
struct stat st; struct stat st;
if(b_infile){ if(b_infile){
rewind(b_infile); if(-1 == fseek(b_infile, 0, SEEK_SET)){
S3FS_PRN_WARN("Could not reset position(fd=%d)", fileno(b_infile));
return false;
}
if(-1 == fstat(fileno(b_infile), &st)){ if(-1 == fstat(fileno(b_infile), &st)){
S3FS_PRN_WARN("Could not get file stat(fd=%d)", fileno(b_infile)); S3FS_PRN_WARN("Could not get file stat(fd=%d)", fileno(b_infile));
return false; return false;

10
src/s3fs.cpp
View File

@ -206,8 +206,8 @@ class MpStatFlag
{ {
private: private:
mutable pthread_mutex_t flag_lock; mutable pthread_mutex_t flag_lock;
bool is_lock_init; bool is_lock_init = false;
bool has_mp_stat; bool has_mp_stat = false;
public: public:
MpStatFlag(); MpStatFlag();
@ -221,7 +221,7 @@ class MpStatFlag
bool Set(bool flag); bool Set(bool flag);
}; };
MpStatFlag::MpStatFlag() : is_lock_init(false), has_mp_stat(false) MpStatFlag::MpStatFlag()
{ {
pthread_mutexattr_t attr; pthread_mutexattr_t attr;
pthread_mutexattr_init(&attr); pthread_mutexattr_init(&attr);
@ -273,7 +273,7 @@ class SyncFiller
{ {
private: private:
mutable pthread_mutex_t filler_lock; mutable pthread_mutex_t filler_lock;
bool is_lock_init; bool is_lock_init = false;
void* filler_buff; void* filler_buff;
fuse_fill_dir_t filler_func; fuse_fill_dir_t filler_func;
std::set<std::string> filled; std::set<std::string> filled;
@ -290,7 +290,7 @@ class SyncFiller
int SufficiencyFill(const std::vector<std::string>& pathlist); int SufficiencyFill(const std::vector<std::string>& pathlist);
}; };
SyncFiller::SyncFiller(void* buff, fuse_fill_dir_t filler) : is_lock_init(false), filler_buff(buff), filler_func(filler) SyncFiller::SyncFiller(void* buff, fuse_fill_dir_t filler) : filler_buff(buff), filler_func(filler)
{ {
if(!filler_buff || !filler_func){ if(!filler_buff || !filler_func){
S3FS_PRN_CRIT("Internal error: SyncFiller constructor parameter is critical value."); S3FS_PRN_CRIT("Internal error: SyncFiller constructor parameter is critical value.");