From 37cf324c52c5331fe629b8f5befe62bcfef6e2ef Mon Sep 17 00:00:00 2001 From: Andrew Gaul Date: Sat, 28 Sep 2024 11:37:25 +0900 Subject: [PATCH] Return non-zero exit code on Valgrind errors (#2527) Previously this ignored use-after-frees and other errors. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6b32f59..4a31c3a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -279,7 +279,7 @@ jobs: echo "CXXFLAGS=${COMMON_CXXFLAGS} -O1 -fsanitize=undefined,implicit-conversion,local-bounds,unsigned-integer-overflow" elif [ "${{ matrix.checktype }}" = "valgrind" ]; then echo "CXXFLAGS=${COMMON_CXXFLAGS} -O1" - echo 'VALGRIND=--leak-check=full' + echo 'VALGRIND="--leak-check=full --error-exitcode=1"' echo 'RETRIES=100' echo 'S3_URL=http://127.0.0.1:8081' fi