Address cppcheck 2.10 warnings (#2163)

Disable newer cppcheck until we can diagnose this further.
References #2162.

.github/workflows/ci.yml

@@ -101,8 +101,8 @@ jobs:
 
       - name: Cppcheck
         run: |
-          # work around resource leak false positives on older Linux distributions
+          # work around resource leak false positives on older and newer Linux distributions
-          if cppcheck --version | awk '{if ($2 <= 1.86) { exit(1) } }'; then
+          if cppcheck --version | awk '{if ($2 <= 1.86 || $2 >= 2.10) { exit(1) } }'; then
             make cppcheck
           fi
 

Makefile.am

@@ -44,6 +44,7 @@ cppcheck:
             --enable=warning,style,information,missingInclude \
             --suppress=missingIncludeSystem \
             --suppress=unmatchedSuppression \
+            --suppress=useStlAlgorithm \
             src/ test/
 
 #

src/addhead.cpp

@@ -151,9 +151,7 @@ bool AdditionalHeader::Load(const char* file)
         addheadlist.push_back(paddhead);
 
         // set flag
-        if(!is_enable){
+        is_enable = true;
-            is_enable = true;
-        }
     }
     return true;
 }

src/fdcache.cpp

@@ -320,7 +320,7 @@ bool FdManager::HaveLseekHole()
         }
         FdManager::checked_lseek   = true;
         FdManager::have_lseek_hole = false;
-        return FdManager::have_lseek_hole;
+        return false;
     }
 
     // check SEEK_DATA/SEEK_HOLE options