Remove more unneeded headers identified by IWYU (#2011)

src/bodydata.cpp

@@ -20,9 +20,9 @@
 
 #include <cstdio>
 #include <cstdlib>
+#include <cstring>
 
-#include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "bodydata.h"
 
 //-------------------------------------------------------------------

src/cache.cpp

@@ -18,14 +18,13 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
-#include <cerrno>
-#include <cstdio>
-#include <cstdlib>
-
 #include <algorithm>
+#include <cerrno>
+#include <cstdlib>
+#include <vector>
 
-#include "common.h"
 #include "s3fs.h"
+#include "s3fs_logger.h"
 #include "s3fs_util.h"
 #include "cache.h"
 #include "autolock.h"
@@ -571,7 +570,7 @@ bool StatCache::TruncateCache()
             erase_iters.push_back(iter);
         }
         if(erase_count < erase_iters.size()){
-            sort(erase_iters.begin(), erase_iters.end(), sort_statiterlist());
+            std::sort(erase_iters.begin(), erase_iters.end(), sort_statiterlist());
             while(erase_count < erase_iters.size()){
                 erase_iters.pop_back();
             }

src/cache.h

@@ -21,6 +21,8 @@
 #ifndef S3FS_CACHE_H_
 #define S3FS_CACHE_H_
 
+#include <cstring>
+
 #include "metaheader.h"
 
 //-------------------------------------------------------------------

src/common.h

@@ -21,11 +21,10 @@
 #ifndef S3FS_COMMON_H_
 #define S3FS_COMMON_H_
 
-#include <fcntl.h>
+#include <sys/types.h>
 
 #include "../config.h"
 #include "types.h"
-#include "s3fs_logger.h"
 
 //-------------------------------------------------------------------
 // Global variables

src/common_auth.cpp

@@ -21,8 +21,6 @@
 #include <cstdio>
 #include <string>
 
-#include "common.h"
-#include "s3fs.h"
 #include "s3fs_auth.h"
 #include "string_util.h"
 

src/curl.cpp

@@ -29,11 +29,14 @@
 
 #include "common.h"
 #include "s3fs.h"
+#include "s3fs_logger.h"
 #include "curl.h"
 #include "curl_multi.h"
 #include "curl_util.h"
 #include "s3fs_auth.h"
 #include "autolock.h"
+#include "curl_handlerpool.h"
+#include "s3fs_cred.h"
 #include "s3fs_util.h"
 #include "string_util.h"
 #include "addhead.h"

src/curl.h

@@ -26,12 +26,10 @@
 #include <map>
 #include <vector>
 
-#include "common.h"
-#include "curl_handlerpool.h"
+#include "autolock.h"
 #include "bodydata.h"
 #include "metaheader.h"
 #include "fdcache_page.h"
-#include "s3fs_cred.h"
 
 //----------------------------------------------
 // Avoid dependency on libcurl version
@@ -76,6 +74,8 @@ typedef std::map<CURL*, progress_t> curlprogress_t;
 //----------------------------------------------
 // class S3fsCurl
 //----------------------------------------------
+class CurlHandlerPool;
+class S3fsCred;
 class S3fsCurl;
 class Semaphore;
 

src/curl_handlerpool.cpp

@@ -20,8 +20,7 @@
 
 #include <cstdio>
 
-#include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "curl_handlerpool.h"
 #include "autolock.h"
 

src/curl_multi.cpp

@@ -21,9 +21,10 @@
 #include <cstdio>
 #include <cstdlib>
 #include <cerrno>
+#include <vector>
 
-#include "common.h"
 #include "s3fs.h"
+#include "s3fs_logger.h"
 #include "curl_multi.h"
 #include "curl.h"
 #include "autolock.h"

src/curl_util.cpp

@@ -23,7 +23,7 @@
 #include <curl/curl.h>
 
 #include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "curl_util.h"
 #include "string_util.h"
 #include "s3fs_auth.h"

src/fdcache.cpp

@@ -23,13 +23,12 @@
 #include <cerrno>
 #include <climits>
 #include <unistd.h>
-#include <sys/types.h>
 #include <dirent.h>
+#include <sys/stat.h>
+#include <sys/statvfs.h>
 
-#include "common.h"
-#include "s3fs.h"
 #include "fdcache.h"
-#include "fdcache_pseudofd.h"
+#include "fdcache_stat.h"
 #include "s3fs_util.h"
 #include "s3fs_logger.h"
 #include "s3fs_cred.h"

src/fdcache_auto.cpp

@@ -20,8 +20,7 @@
 
 #include <cstdio>
 
-#include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "fdcache_auto.h"
 #include "fdcache.h"
 

src/fdcache_auto.h

@@ -21,8 +21,12 @@
 #ifndef S3FS_FDCACHE_AUTO_H_
 #define S3FS_FDCACHE_AUTO_H_
 
+#include <fcntl.h>
+
 #include "autolock.h"
-#include "fdcache_entity.h"
+#include "metaheader.h"
+
+class FdEntity;
 
 //------------------------------------------------
 // class AutoFdEntity

src/fdcache_entity.cpp

@@ -23,16 +23,19 @@
 #include <cerrno>
 #include <unistd.h>
 #include <limits.h>
-#include <sys/time.h>
+#include <sys/stat.h>
 
 #include "common.h"
-#include "s3fs.h"
 #include "fdcache_entity.h"
+#include "fdcache_stat.h"
+#include "fdcache_untreated.h"
 #include "fdcache.h"
 #include "string_util.h"
+#include "s3fs_logger.h"
 #include "s3fs_util.h"
 #include "autolock.h"
 #include "curl.h"
+#include "s3fs_cred.h"
 
 //------------------------------------------------
 // Symbols

src/fdcache_entity.h

@@ -21,6 +21,8 @@
 #ifndef S3FS_FDCACHE_ENTITY_H_
 #define S3FS_FDCACHE_ENTITY_H_
 
+#include <fcntl.h>
+
 #include "autolock.h"
 #include "fdcache_page.h"
 #include "fdcache_fdinfo.h"

src/fdcache_fdinfo.cpp

@@ -21,10 +21,11 @@
 #include <cstdio>
 #include <cstdlib>
 #include <errno.h>
+#include <sys/stat.h>
 #include <unistd.h>
 
 #include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "fdcache_fdinfo.h"
 #include "fdcache_pseudofd.h"
 #include "fdcache_entity.h"

src/fdcache_fdinfo.h

@@ -21,12 +21,13 @@
 #ifndef S3FS_FDCACHE_FDINFO_H_
 #define S3FS_FDCACHE_FDINFO_H_
 
-#include "fdcache_untreated.h"
 #include "psemaphore.h"
 #include "metaheader.h"
 #include "autolock.h"
+#include "types.h"
 
 class FdEntity;
+class UntreatedParts;
 
 //------------------------------------------------
 // Structure of parameters to pass to thread

src/fdcache_page.cpp

@@ -22,10 +22,12 @@
 #include <cerrno>
 #include <unistd.h>
 #include <sstream>
+#include <sys/stat.h>
 
 #include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "fdcache_page.h"
+#include "fdcache_stat.h"
 #include "string_util.h"
 
 //------------------------------------------------

src/fdcache_page.h

@@ -24,8 +24,6 @@
 #include <list>
 #include <sys/types.h>
 
-#include "fdcache_stat.h"
-
 //------------------------------------------------
 // Symbols
 //------------------------------------------------
@@ -68,6 +66,7 @@ typedef std::list<struct fdpage> fdpage_list_t;
 //------------------------------------------------
 // Class PageList
 //------------------------------------------------
+class CacheFileStat;
 class FdEntity;
 
 // cppcheck-suppress copyCtorAndEqOperator

src/fdcache_pseudofd.cpp

@@ -18,11 +18,11 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
-#include <cstdlib>
 #include <algorithm>
+#include <cstdlib>
+#include <vector>
 
-#include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "fdcache_pseudofd.h"
 #include "autolock.h"
 

src/fdcache_stat.cpp

@@ -21,9 +21,9 @@
 #include <cerrno>
 #include <unistd.h>
 #include <sys/file.h>
+#include <sys/stat.h>
 
-#include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "fdcache_stat.h"
 #include "fdcache.h"
 #include "s3fs_util.h"

src/fdcache_untreated.cpp

@@ -20,8 +20,7 @@
 
 #include <cstdlib>
 
-#include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "fdcache_untreated.h"
 #include "autolock.h"
 

src/gnutls_auth.cpp

@@ -41,6 +41,7 @@
 #include "common.h"
 #include "s3fs.h"
 #include "s3fs_auth.h"
+#include "s3fs_logger.h"
 
 //-------------------------------------------------------------------
 // Utility Function for version

src/metaheader.cpp

@@ -19,10 +19,10 @@
  */
 
 #include <unistd.h>
+#include <sys/stat.h>
 #include <sys/types.h>
 
 #include "common.h"
-#include "s3fs.h"
 #include "metaheader.h"
 #include "string_util.h"
 

src/metaheader.h

@@ -22,6 +22,7 @@
 #define S3FS_METAHEADER_H_
 
 #include <string>
+#include <strings.h>
 #include <map>
 
 //-------------------------------------------------------------------

src/mpu_util.cpp

@@ -21,8 +21,8 @@
 #include <cstdio>
 #include <cstdlib>
 
-#include "common.h"
 #include "s3fs.h"
+#include "s3fs_logger.h"
 #include "mpu_util.h"
 #include "curl.h"
 #include "s3fs_xml.h"

src/mvnode.cpp

@@ -20,8 +20,8 @@
 
 #include <cstdio>
 #include <cstdlib>
+#include <cstring>
 
-#include "common.h"
 #include "s3fs.h"
 #include "mvnode.h"
 

src/nss_auth.cpp

@@ -37,6 +37,7 @@
 #include "common.h"
 #include "s3fs.h"
 #include "s3fs_auth.h"
+#include "s3fs_logger.h"
 
 //-------------------------------------------------------------------
 // Utility Function for version

src/openssl_auth.cpp

@@ -23,12 +23,7 @@
 #include <cerrno>
 #include <pthread.h>
 #include <unistd.h>
-#include <syslog.h>
-#include <sys/types.h>
 #include <sys/stat.h>
-#include <cstring>
-#include <openssl/bio.h>
-#include <openssl/buffer.h>
 #include <openssl/evp.h>
 #include <openssl/hmac.h>
 #include <openssl/md5.h>
@@ -36,11 +31,9 @@
 #include <openssl/crypto.h>
 #include <openssl/err.h>
 #include <string>
-#include <map>
 
-#include "common.h"
-#include "s3fs.h"
 #include "s3fs_auth.h"
+#include "s3fs_logger.h"
 
 //-------------------------------------------------------------------
 // Utility Function for version

src/s3fs.cpp

@@ -23,15 +23,16 @@
 #include <errno.h>
 #include <unistd.h>
 #include <dirent.h>
-#include <pwd.h>
 #include <sys/types.h>
 #include <getopt.h>
 
 #include "common.h"
 #include "s3fs.h"
+#include "s3fs_logger.h"
 #include "metaheader.h"
 #include "fdcache.h"
 #include "fdcache_auto.h"
+#include "fdcache_stat.h"
 #include "curl.h"
 #include "curl_multi.h"
 #include "s3objlist.h"
@@ -40,9 +41,9 @@
 #include "addhead.h"
 #include "sighandlers.h"
 #include "s3fs_xml.h"
-#include "s3fs_util.h"
 #include "string_util.h"
 #include "s3fs_auth.h"
+#include "s3fs_cred.h"
 #include "s3fs_help.h"
 #include "s3fs_util.h"
 #include "mpu_util.h"

src/s3fs_cred.cpp

@@ -21,13 +21,14 @@
 #include <errno.h>
 #include <unistd.h>
 #include <pwd.h>
+#include <sys/stat.h>
 #include <sys/types.h>
 #include <fstream>
 #include <sstream>
 
 #include "common.h"
-#include "s3fs.h"
 #include "s3fs_cred.h"
+#include "s3fs_logger.h"
 #include "curl.h"
 #include "string_util.h"
 #include "metaheader.h"

src/s3fs_global.cpp

@@ -18,7 +18,6 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
-#include <sys/types.h>
 #include <string>
 
 //-------------------------------------------------------------------

src/s3fs_help.cpp

@@ -23,7 +23,6 @@
 #include <string>
 
 #include "common.h"
-#include "s3fs.h"
 #include "s3fs_help.h"
 #include "s3fs_auth.h"
 

src/s3fs_logger.h

@@ -27,6 +27,8 @@
 #include <syslog.h>
 #include <sys/time.h>
 
+#include "common.h"
+
 #ifdef CLOCK_MONOTONIC_COARSE
 #define S3FS_CLOCK_MONOTONIC    CLOCK_MONOTONIC_COARSE
 #else

src/s3fs_util.cpp

@@ -26,14 +26,13 @@
 #include <pwd.h>
 #include <libgen.h>
 #include <dirent.h>
-#include <sys/types.h>
+#include <sys/stat.h>
 #include <sys/utsname.h>
 
 #include <string>
 #include <sstream>
 
-#include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "s3fs_util.h"
 #include "string_util.h"
 #include "s3fs_help.h"

src/s3fs_xml.cpp

@@ -24,6 +24,7 @@
 
 #include "common.h"
 #include "s3fs.h"
+#include "s3fs_logger.h"
 #include "s3fs_xml.h"
 #include "s3fs_util.h"
 #include "s3objlist.h"

src/sighandlers.cpp

@@ -22,8 +22,7 @@
 #include <csignal>
 #include <pthread.h>
 
-#include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "sighandlers.h"
 #include "fdcache.h"
 

src/string_util.cpp

@@ -18,7 +18,6 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
-#include <cstdio>
 #include <cstdlib>
 #include <cstring>
 #include <cerrno>
@@ -27,8 +26,7 @@
 
 #include <sstream>
 
-#include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "string_util.h"
 
 //-------------------------------------------------------------------

src/string_util.h

@@ -21,6 +21,8 @@
 #ifndef S3FS_STRING_UTIL_H_
 #define S3FS_STRING_UTIL_H_
 
+#include <cstring>
+
 //
 // A collection of string utilities for manipulating URLs and HTTP responses.
 //

src/test_page_list.cpp

@@ -18,7 +18,8 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
  */
 
-#include "fdcache.h"
+#include "fdcache_page.h"
+#include "fdcache_stat.h"
 #include "test_util.h"
 
 bool CacheFileStat::Open() { return false; }

src/test_string_util.cpp

@@ -23,8 +23,7 @@
 #include <stdint.h>
 #include <string>
 
-#include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "string_util.h"
 #include "test_util.h"
 

src/threadpoolman.cpp

@@ -21,9 +21,9 @@
 #include <cstdio>
 #include <cstdlib>
 #include <errno.h>
+#include <stdint.h>
 
-#include "common.h"
-#include "s3fs.h"
+#include "s3fs_logger.h"
 #include "threadpoolman.h"
 #include "autolock.h"