octoleo/s3fs-fuse
1
0
Fork 0
mirror of https://github.com/s3fs-fuse/s3fs-fuse.git synced 2024-12-22 08:48:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prefer C++-style casts over C-style casts (#2599)

Browse Source 
The former are easier to identify.  Found via clang-tidy.

Co-authored-by: Takeshi Nakatani <ggtakec@gmail.com>
This commit is contained in:
Andrew Gaul 2024-12-01 10:29:08 +09:00 committed by GitHub
parent d13396127c
commit 65e4aef2a1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.clang-tidy
View File

@ -37,7 +37,6 @@ Checks: '
-cppcoreguidelines-special-member-functions, -cppcoreguidelines-special-member-functions,
-fuchsia-*, -fuchsia-*,
-google-build-using-namespace, -google-build-using-namespace,
-google-readability-casting,
-google-readability-function-size, -google-readability-function-size,
-google-readability-todo, -google-readability-todo,
-google-runtime-int, -google-runtime-int,

4
src/curl.cpp
View File

@ -499,7 +499,7 @@ size_t S3fsCurl::UploadReadCallback(void* ptr, size_t size, size_t nmemb, void*
return 0; return 0;
} }
// read size // read size
ssize_t copysize = (size * nmemb) < (size_t)pCurl->partdata.size ? (size * nmemb) : (size_t)pCurl->partdata.size; ssize_t copysize = (size * nmemb) < static_cast<size_t>(pCurl->partdata.size) ? (size * nmemb) : static_cast<size_t>(pCurl->partdata.size);
ssize_t readbytes; ssize_t readbytes;
ssize_t totalread; ssize_t totalread;
// read and set // read and set
@ -537,7 +537,7 @@ size_t S3fsCurl::DownloadWriteCallback(void* ptr, size_t size, size_t nmemb, voi
} }
// write size // write size
ssize_t copysize = (size * nmemb) < (size_t)pCurl->partdata.size ? (size * nmemb) : (size_t)pCurl->partdata.size; ssize_t copysize = (size * nmemb) < static_cast<size_t>(pCurl->partdata.size) ? (size * nmemb) : static_cast<size_t>(pCurl->partdata.size);
ssize_t writebytes; ssize_t writebytes;
ssize_t totalwrite; ssize_t totalwrite;

10
src/s3fs.cpp
View File

@ -2039,10 +2039,10 @@ static int s3fs_chown(const char* _path, uid_t uid, gid_t gid)
return result; return result;
} }
if((uid_t)(-1) == uid){ if(static_cast<uid_t>(-1) == uid){
uid = stbuf.st_uid; uid = stbuf.st_uid;
} }
if((gid_t)(-1) == gid){ if(static_cast<gid_t>(-1) == gid){
gid = stbuf.st_gid; gid = stbuf.st_gid;
} }
if(S_ISDIR(stbuf.st_mode)){ if(S_ISDIR(stbuf.st_mode)){
@ -2161,10 +2161,10 @@ static int s3fs_chown_nocopy(const char* _path, uid_t uid, gid_t gid)
return result; return result;
} }
if((uid_t)(-1) == uid){ if(static_cast<uid_t>(-1) == uid){
uid = stbuf.st_uid; uid = stbuf.st_uid;
} }
if((gid_t)(-1) == gid){ if(static_cast<gid_t>(-1) == gid){
gid = stbuf.st_gid; gid = stbuf.st_gid;
} }
@ -2749,7 +2749,7 @@ static int s3fs_open(const char* _path, struct fuse_file_info* fi)
FdEntity* ent; FdEntity* ent;
headers_t meta; headers_t meta;
if((unsigned int)fi->flags & O_TRUNC){ if(static_cast<unsigned int>(fi->flags) & O_TRUNC){
if(0 != st.st_size){ if(0 != st.st_size){
st.st_size = 0; st.st_size = 0;
needs_flush = true; needs_flush = true;

2
test/truncate_read_file.cc
View File

@ -51,7 +51,7 @@ int main(int argc, const char *argv[])
// truncate // truncate
if(0 != ftruncate(fd, size)){ if(0 != ftruncate(fd, size)){
fprintf(stderr, "[ERROR] Could not truncate file(%s) to %lld byte.\n", filepath, (long long)size); fprintf(stderr, "[ERROR] Could not truncate file(%s) to %lld byte.\n", filepath, static_cast<long long>(size));
close(fd); close(fd);
exit(EXIT_FAILURE); exit(EXIT_FAILURE);
} }