Fixed errors in cache.cpp from cppcheck 2.11.1

This commit is contained in:
Takeshi Nakatani 2023-08-20 04:01:39 +00:00
parent 8d04ee3e01
commit 9a1b6f3787

View File

@ -508,13 +508,11 @@ void StatCache::ChangeNoTruncateFlag(const std::string& key, bool no_truncate)
if(stat_cache.end() != iter){ if(stat_cache.end() != iter){
stat_cache_entry* ent = &iter->second; stat_cache_entry* ent = &iter->second;
if(ent){ if(no_truncate){
if(no_truncate){ ++(ent->notruncate);
++(ent->notruncate); }else{
}else{ if(0L < ent->notruncate){
if(0L < ent->notruncate){ --(ent->notruncate);
--(ent->notruncate);
}
} }
} }
} }
@ -531,8 +529,8 @@ bool StatCache::TruncateCache()
// 1) erase over expire time // 1) erase over expire time
if(IsExpireTime){ if(IsExpireTime){
for(stat_cache_t::iterator iter = stat_cache.begin(); iter != stat_cache.end(); ){ for(stat_cache_t::iterator iter = stat_cache.begin(); iter != stat_cache.end(); ){
stat_cache_entry* entry = &iter->second; const stat_cache_entry* entry = &iter->second;
if(!entry || (0L == entry->notruncate && IsExpireStatCacheTime(entry->cache_date, ExpireTime))){ if(0L == entry->notruncate && IsExpireStatCacheTime(entry->cache_date, ExpireTime)){
iter = stat_cache.erase(iter); iter = stat_cache.erase(iter);
}else{ }else{
++iter; ++iter;
@ -551,7 +549,7 @@ bool StatCache::TruncateCache()
for(stat_cache_t::iterator iter = stat_cache.begin(); iter != stat_cache.end() && 0 < erase_count; ++iter){ for(stat_cache_t::iterator iter = stat_cache.begin(); iter != stat_cache.end() && 0 < erase_count; ++iter){
// check no truncate // check no truncate
const stat_cache_entry* ent = &iter->second; const stat_cache_entry* ent = &iter->second;
if(ent && 0L < ent->notruncate){ if(0L < ent->notruncate){
// skip for no truncate entry and keep extra counts for this entity. // skip for no truncate entry and keep extra counts for this entity.
if(0 < erase_count){ if(0 < erase_count){
--erase_count; // decrement --erase_count; // decrement