octoleo/s3fs-fuse
1
0
Fork 0
mirror of https://github.com/s3fs-fuse/s3fs-fuse.git synced 2025-01-23 05:48:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Consume return code from get_object_attribute (#1976)

Browse Source 
Found via clang-analyzer.
This commit is contained in:
Andrew Gaul 2022-07-09 16:45:23 +09:00 committed by GitHub
parent 4d303caa62
commit e7ed01b35f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/s3fs.cpp
View File

@ -721,7 +721,6 @@ static int get_local_fent(AutoFdEntity& autoent, FdEntity **entity, const char*
//
// create or update s3 meta
// ow_sse_flg is for over writing sse header by use_sse option.
// @return fuse return code
//
int put_headers(const char* path, headers_t& meta, bool is_copy, bool use_st_size)
@ -733,11 +732,12 @@ int put_headers(const char* path, headers_t& meta, bool is_copy, bool use_st_siz
S3FS_PRN_INFO2("[path=%s]", path);
// files larger than 5GB must be modified via the multipart interface
// *** If there is not target object(a case of move command),
// get_object_attribute() returns error with initializing buf.
// call use_st_size as false when the file does not exist(ex. rename object)
if(use_st_size){
struct stat buf;
(void)get_object_attribute(path, &buf);
if(0 != (result = get_object_attribute(path, &buf))){
return result;
}
size = buf.st_size;
}else{
size = get_size(meta);
@ -2297,7 +2297,9 @@ static int s3fs_open(const char* _path, struct fuse_file_info* fi)
AutoFdEntity autoent;
FdEntity* ent;
headers_t meta;
get_object_attribute(path, NULL, &meta, true, NULL, true); // no truncate cache
if(0 != (result = get_object_attribute(path, NULL, &meta, true, NULL, true))){ // no truncate cache
return result;
}
if(NULL == (ent = autoent.Open(path, &meta, st.st_size, st.st_mtime, fi->flags, false, true, false, AutoLock::NONE))){
StatCache::getStatCacheData()->DelStat(path);
return -EIO;