From eab26a1e0151889b4dd4de75f37fd5f8b8d5f4ac Mon Sep 17 00:00:00 2001 From: Takeshi Nakatani Date: Wed, 7 Jun 2023 15:55:18 +0000 Subject: [PATCH] Fixed test setting for macOS --- test/integration-test-common.sh | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/test/integration-test-common.sh b/test/integration-test-common.sh index b3c4cf7..6ab53f3 100644 --- a/test/integration-test-common.sh +++ b/test/integration-test-common.sh @@ -168,7 +168,7 @@ function start_s3proxy { if [ -z "${CHAOS_HTTP_PROXY}" ] && [ -z "${CHAOS_HTTP_PROXY_OPT}" ]; then S3PROXY_CACERT_FILE="/tmp/keystore.pem" rm -f /tmp/keystore.jks "${S3PROXY_CACERT_FILE}" - echo -e 'password\npassword\n\n\n\n\n\n\nyes' | keytool -genkey -keystore /tmp/keystore.jks -keyalg RSA -keysize 2048 -validity 365 -ext SAN=IP:127.0.0.1 + printf 'password\npassword\n\n\n\n\n\n\ny' | keytool -genkey -keystore /tmp/keystore.jks -keyalg RSA -keysize 2048 -validity 365 -ext SAN=IP:127.0.0.1 echo password | keytool -exportcert -keystore /tmp/keystore.jks -rfc -file "${S3PROXY_CACERT_FILE}" else S3PROXY_CACERT_FILE="" @@ -258,6 +258,16 @@ function start_s3fs { local VIA_STDBUF_CMDLINE="${STDBUF_BIN} -oL -eL" fi + # [NOTE] + # On macOS we may get a VERIFY error for the self-signed certificate used by s3proxy. + # We can specify NO_CHECK_CERT=1 to avoid this. + # + if [ -n "${NO_CHECK_CERT}" ] && [ "${NO_CHECK_CERT}" -eq 1 ]; then + local NO_CHECK_CERT_OPT="-o no_check_certificate" + else + local NO_CHECK_CERT_OPT="" + fi + # Common s3fs options: # # TODO: Allow all these options to be overridden with env variables @@ -292,6 +302,7 @@ function start_s3fs { ${AUTH_OPT} \ ${DIRECT_IO_OPT} \ ${S3FS_HTTP_PROXY_OPT} \ + ${NO_CHECK_CERT_OPT} \ -o stat_cache_expire=1 \ -o stat_cache_interval_expire=1 \ -o dbglevel="${DBGLEVEL:=info}" \