Commit Graph

2260 Commits

Author SHA1 Message Date
Naoki Ikeguchi
4fe2652c6c
Fix Windows compilation (#2506)
* docs: Fix Windows compile instructions

Signed-off-by: Naoki Ikeguchi <me@s6n.jp>

* fix: Use fallocate stub on MSYS2

Signed-off-by: Naoki Ikeguchi <me@s6n.jp>

---------

Signed-off-by: Naoki Ikeguchi <me@s6n.jp>
2024-07-27 09:54:38 +09:00
Andrew Gaul
fcb5aa77fb
Fix minor issues when compiling with MSYS (#2505)
References #2503.
2024-07-27 09:43:16 +09:00
Andrew Gaul
411e42384e
Acquire lock before logging (#2502)
This is not safe -- another caller could modify a std::string field
while logging which could read an invalid pointer.  References #2490.
2024-07-21 16:14:22 +09:00
Andrew Gaul
1c2f61e2a5
Remove unneeded lock utility functions (#2500)
std::mutex RAII removes the need for these.

Co-authored-by: Takeshi Nakatani <ggtakec@gmail.com>
2024-07-15 15:32:39 +09:00
Andrew Gaul
23efccbe39
Disable thread safety analysis on conditional locks (#2498)
Clang does not support this:

https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#conditional-locks

Co-authored-by: Takeshi Nakatani <ggtakec@gmail.com>
2024-07-15 15:17:47 +09:00
Andrew Gaul
77ffe7d634
Wrap CURL* in a std::unique_ptr (#2495)
This is safer and clarifies the ownership of pointers.

Co-authored-by: Takeshi Nakatani <ggtakec@gmail.com>
2024-07-15 15:15:03 +09:00
Andrew Gaul
60b871e0ae
Simplify has_mp_stat (#2499)
This is unnecessary since we moved from pthread_mutex_t to
std::atomic.
2024-07-15 15:04:28 +09:00
Takeshi Nakatani
44d5b5e1c9 Continued Github Actions(CI) execution after CentOS 7 EOL 2024-07-13 10:30:27 +05:30
Andrew Gaul
03651a30ea
Add infrastructure for clang static lock checking (#2492)
Co-authored-by: Takeshi Nakatani <ggtakec@gmail.com>
2024-07-13 09:48:43 +09:00
Andrew Gaul
db80fa2eb0 Upgrade CI to Alpine 3.20 2024-07-11 23:14:07 +05:30
Andrew Gaul
6f90c6918f
Fix incorrect locking annotations (#2494)
Co-authored-by: Takeshi Nakatani <ggtakec@gmail.com>
2024-07-11 23:13:44 +09:00
Andrew Gaul
437bf7ec95
Convert pthread_t to C++11 std::thread (#2481)
This has better cross-platform support and stronger type-safety.
2024-07-11 22:37:25 +09:00
Andrew Gaul
50d5a73f84
Simplify curl progress tracking (#2486)
Use a struct with named fields instead of a pair for clarity and use a
single map to store the structs for efficiency.
2024-07-06 16:35:25 +09:00
Takeshi Nakatani
ec183d0d9a Dropped Github Actions(CI) for CentOS 7 and Debian 10(Buster) 2024-07-01 23:46:18 +05:30
Andrew Gaul
ae28a110ab
Remove unused function (#2484)
Also clean up some function prototypes.

Co-authored-by: Takeshi Nakatani <ggtakec@gmail.com>
2024-07-01 23:30:32 +09:00
Andrew Gaul
a6637b29e6
Opt in to all clang-tidy checks by default (#2477)
Opt out of the noisy checks.  Disable clang-tidy on Debian bullseye
and buster and Ubuntu 20.04 due to segfaults.
2024-07-01 22:29:34 +09:00
Takeshi Nakatani
1a50b9a04a Fixed a deadlock in the FdManager::ChangeEntityToTempPath method call 2024-06-30 20:29:01 +05:30
Andrew Gaul
585f137cf0
Remove unused headers found by clang-tidy (#2480)
Found via misc-include-cleaner but this requires more work.
2024-06-25 23:32:46 +09:00
Andrew Gaul
1449905fe5
Make deleted constructors and operators public (#2479)
Deleting them better conveys the intent.
2024-06-24 08:26:24 +09:00
Andrew Gaul
622dc0a815
Convert pthread_mutex to std::mutex (#2476)
This simplifies resource management and improve Windows compatibility.
2024-06-24 00:48:01 +09:00
Andrew Gaul
86b353511a
Replace memset with C++11 value initialization (#2471)
This generates the same code but is safer due to using an implicit
length and allowing member initialization.
2024-06-24 00:24:49 +09:00
Takeshi Nakatani
a3a0ae523f Changed the display format of the Git commit hash in the version display 2024-06-23 16:01:33 +05:30
Viktor Szépe
fa807a56fb
Fix typos (#2473) 2024-06-23 15:33:46 +09:00
Andrew Gaul
254d717a4a
Address clang-tidy 19 warnings (#2474) 2024-06-23 12:21:51 +09:00
Andrew Gaul
86e6bdaf4d
Apply clang-tidy to headers (#2470) 2024-06-23 11:49:59 +09:00
Andrew Gaul
2841601ad5
Remove uses of AutoLock::ALREADY_LOCKED (#2466)
Instead annotate the methods with REQUIRES so that the caller knows if
they should lock.  For public interfaces, introduce HasLock wrappers.
This simplifies control flow, allows migration to std::mutex, and
eventually will enable use of static lock checking.
2024-06-23 11:24:51 +09:00
Viktor Szépe
39c2d8b2a7 Improve CI workflow 2024-06-14 16:22:12 +09:00
Andrew Gaul
683452a9be
Remove unnecessary copy constructors and operator= (#2468) 2024-06-10 23:37:53 +09:00
Andrew Gaul
ebae5a302f
Prefer std::string::clear where possible (#2467)
This is somewhat more clear and is declared noexcept.
2024-06-10 23:36:49 +09:00
Andrew Gaul
ba7b2ef9f0
Return boolean as bool not int (#2465) 2024-06-04 22:38:30 +09:00
Andrew Gaul
f3946a2310
Keep cache path parameters as std::string (#2464)
While some of these originate as char *, eventually they convert to
std::string in the std::map lookup.
2024-06-04 22:37:48 +09:00
Andrew Gaul
a4f694c345
Pass const std::string by reference (#2461)
This is more idiomatic than by pointer.
2024-05-28 09:17:45 +09:00
Takeshi Nakatani
2c532e8b79 Fixed error reports of failure in cppcheck 2.14.0 2024-05-28 07:29:03 +09:00
Andrew Gaul
5c1932f702
Upgrade CI to Ubuntu 24.04 LTS (#2456) 2024-05-12 11:12:25 +09:00
LiuBingrun
ccdcccd44c
Fix DeadLock in FdManager::ChangeEntityToTempPath (#2455)
commit e3b50ad introduce smart pointer to manage FdEntity

But in ChangeEntityToTempPath, we should not destroy the entity.

We should move the entry to the temp ky

Signed-off-by: liubingrun <liubr1@chinatelecom.cn>
2024-05-11 11:29:40 +09:00
Andrew Gaul
3864f58c22
Upgrade CI to Fedora 40 (#2451) 2024-05-11 09:25:05 +09:00
Takeshi Nakatani
c36827d1de
Fixed README.md for Github Action Badge URL (#2449) 2024-04-28 20:10:53 +09:00
Takeshi Nakatani
e2cc36a37f
Updated COMPILATION.md about compilation on linux (#2445) 2024-04-28 14:31:01 +09:00
Takeshi Nakatani
cf6102f91b
Changed due to s3fs-fuse logo change (#2448) 2024-04-28 14:28:24 +09:00
Sébastien Brochet
dd6815b90f retry request on HTTP 429 error 2024-04-14 12:09:26 +09:00
Takeshi Nakatani
95026804e9 Support SSL client cert and added ssl_client_cert option 2024-04-14 10:21:48 +09:00
Takeshi Nakatani
9ab5a2ea73 Fixed configure error for GHA:sanitize_thread 2024-03-19 21:37:19 +09:00
Takeshi Nakatani
a5cdd05c25 Added ipresolve option 2024-03-13 22:29:17 +09:00
Andrew Gaul
31676f6201
Convert thpoolman_param to value (#2430)
This simplifies memory management.
2024-03-13 21:27:12 +09:00
Andrew Gaul
c97f7a2a13
Address clang-tidy 18 warnings (#2428) 2024-03-07 01:04:22 +09:00
Andrew Gaul
be54c34ecb
Remove unneeded XML macros (#2427) 2024-03-07 00:45:34 +09:00
Andrew Gaul
79597c7960
Upgrade CI to Alpine 3.19 (#2429) 2024-03-07 00:23:00 +09:00
Andrew Gaul
70a30d6e26 Update ChangeLog and configure.ac for 1.94
Fixes #2420.
2024-02-25 13:08:43 +09:00
Takeshi Nakatani
b97fd470a5 Abort for SSE-KMS encryption type and not SSL/TLS specified 2024-02-23 13:11:56 +09:00
Andrew Gaul
4d7fd60305
Call abort instead of exit in tests (#2416)
This can give useful core dumps.
2024-02-23 12:28:29 +09:00