Takeshi Nakatani
632578f328
Merge pull request #247 from andrewgaul/base64
...
Base64 cleanup
2015-08-22 00:45:26 +09:00
Andrew Gaul
bcfadbe1a8
Unlock during early return in TruncateCache
...
Found via Coverity. Regression from
dfa63345ed
2015-08-19 13:54:14 -07:00
Andrew Gaul
b5c027f15d
Add unit tests for base64 encoding and decoding
2015-08-19 13:49:10 -07:00
Andrew Gaul
15db80b459
NUL terminate decoded base64 string
...
For consistency with encoded strings.
2015-08-19 13:48:07 -07:00
Andrew Gaul
76c0ef86e4
Move base64 and hex functions to string_util
2015-08-19 13:47:26 -07:00
Takeshi Nakatani
a3e820e733
Merge pull request #245 from andrewgaul/map-duplicate-lookups
...
Elide duplicate lookups of std::map via iterators
2015-08-20 01:22:06 +09:00
Takeshi Nakatani
4ad57bdea5
Merge pull request #240 from andrewgaul/md5
...
Enable Content-MD5 during multipart upload part
2015-08-20 01:19:01 +09:00
Takeshi Nakatani
085733d7c9
Merge pull request #239 from andrewgaul/google-code
...
Update stale Google Code reference in --help
2015-08-20 01:08:00 +09:00
Takeshi Nakatani
fcb58aec3c
Merge pull request #238 from andrewgaul/cppcheck
...
Enable all cppcheck rules
2015-08-20 01:06:50 +09:00
Takeshi Nakatani
026a9f2bdc
Merge pull request #235 from andrewgaul/complete-mpu-leak
...
Plug leak during complete multipart upload
2015-08-20 00:40:00 +09:00
Takeshi Nakatani
fd04b9a437
Merge pull request #233 from andrewgaul/remove-inttostr
...
Remove IntToStr
2015-08-20 00:34:21 +09:00
Takeshi Nakatani
ea99603b58
Merge pull request #232 from andrewgaul/stat-cache-locking
...
Always hold stat_cache_lock when using stat_cache
2015-08-20 00:28:57 +09:00
Andrew Gaul
67d1576dfb
Elide duplicate lookups of std::map via iterators
...
Also remove use of C++11 std::map::at.
2015-08-18 14:00:42 -07:00
Andrew Gaul
a157ac59ca
Enable Content-MD5 during multipart upload part
...
This allows retries of multi-part uploads instead of discovering a
fatal error during complete multipart upload. Also enable Content-MD5
for integration tests and refactor hexadecimal code.
2015-08-18 02:54:00 -07:00
Andrew Gaul
32520fd1fb
Update stale Google Code reference in --help
2015-08-16 23:30:41 -07:00
Andrew Gaul
c0b21d8808
Enable all cppcheck rules
2015-08-16 17:13:24 -07:00
Andrew Gaul
9c5bf0bb66
Plug leak during complete multipart upload
2015-08-15 22:38:24 -07:00
Andrew Gaul
dfa63345ed
Always hold stat_cache_lock when using stat_cache
...
We could further improve this code by holding stat_cache_lock before
calls to DelStat instead of unlocking then relocking it.
2015-08-14 20:14:12 -07:00
Andrew Gaul
3f59b8da01
Rewrite AutoLock
...
Previously AutoLock::Lock allowed subsequent callers to proceed
without the lock. Further is_locked was not always protected by
auto_mutex. Finally AutoLock eagerly released auto_mutex when
recursively unlocking. s3fs does not need recursive locks so we
rewrite and simplify AutoLock. Partially surfaced by Coverity.
2015-08-14 20:00:56 -07:00
Andrew Gaul
0ea88a73c7
Remove IntToStr
...
str duplicates this functionality. Also add unit test.
2015-08-12 08:25:09 -07:00
Takeshi Nakatani
756d1e5e81
Configure cppcheck #224
2015-08-12 15:04:16 +00:00
Takeshi Nakatani
2482aada43
Merge pull request #222 from andrewgaul/explicit
...
Annotate constructors as explicit
2015-08-12 23:42:03 +09:00
Takeshi Nakatani
64146f69a4
Merge pull request #221 from andrewgaul/compare
...
Compare idiomatically
2015-08-12 23:41:24 +09:00
Takeshi Nakatani
49e32967ec
Merge pull request #219 from andrewgaul/coverity
...
Address Coverity errors
2015-08-12 23:40:47 +09:00
Takeshi Nakatani
09dff484e1
Merge pull request #215 from RobbKistler/memleak
...
Fix mem leak in openssl_auth.cpp:s3fs_sha256hexsum
2015-08-12 23:38:51 +09:00
Andrew Gaul
ff8a0c2eea
Parse ETag from copy multipart correctly
...
Previously s3fs misparsed this, preventing renames of files larger
than 5 GB. Integration test disabled until S3Proxy 1.5.0 is released.
2015-08-11 14:43:35 -07:00
Robb Kistler
fcb55c2109
Fix mem leaks in openssl_auth.cpp, nss_auth.cpp
...
Fix memory leaks in openssl_auth.cpp:s3fs_sha256hexsum and
nss_auth.cpp:s3fs_sha256hexsum. Leaks occur every time a file
is created.
2015-08-06 12:45:40 -07:00
Andrew Gaul
b6fa2deb9f
Annotate constructors as explicit
...
This prevents implicit conversions.
2015-08-05 23:41:53 -07:00
Andrew Gaul
801ca0c2d3
Compare idiomatically
2015-08-05 23:35:08 -07:00
Andrew Gaul
8ee71caabb
Address Coverity errors
...
Fixed an uninitialized member, misordered NULL check, resource leak,
and unconsumed return value.
2015-08-05 23:28:06 -07:00
Jamie Alessio
912bc58df0
Fixed a few small spelling issues.
2015-07-10 11:50:40 -07:00
Nate Rosenblum
9b3c87ec97
Specialize {set,get}xattr for OS X
...
These system calls take an extra 'position' parameter on OS X. A
non-zero position value is only valid for resource forks (the Darwin
VFS layer will reject anything else with EINVAL); this patch simply
adds and ignores the parameter on Apple platforms.
Allows building against OSXFUSE.
2015-06-25 12:56:15 -07:00
Takeshi Nakatani
966d229787
fixed fallback to sigv2 for bucket create and GCS
2015-06-20 04:34:32 +00:00
Takeshi Nakatani
4d49ace06b
Merge pull request #192 from andrewgaul/special-characters
...
Simplify URL encoding
2015-06-20 11:47:22 +09:00
Takeshi Nakatani
ad8c64104e
Merge pull request #199 from s3fs-fuse/xattr
...
Supported extended attributes(retry)
2015-06-20 11:46:47 +09:00
Takeshi Nakatani
fe3abed9f0
Chaged codes about iterator etc
2015-06-13 03:27:07 +00:00
Takeshi Nakatani
0ecf4aa6b4
Chaged codes about iterator
2015-06-13 03:08:56 +00:00
Andrew Gaul
4e03acf17a
Simplify URL encoding
...
This also encodes asterisk and tilde correctly when listing a file
with a V4 auth endpoint. Also add tests for special characters
although s3proxy does not yet support V4 auth.
Fixes #188 . Fixes #194 .
2015-06-10 13:15:58 -07:00
Takeshi Nakatani
84fb3d83d8
Fixed xattr for binary value
2015-06-06 16:39:39 +00:00
Bartlomiej Palmowski
3522e5eda3
Add no_check_certificate option which allows to ignore issues with self signed certs.
2015-05-20 17:32:36 +02:00
Takeshi Nakatani
3056644969
Merge pull request #185 from andrewgaul/typos
...
Correct obvious typos in usage and README
2015-05-06 22:37:22 +09:00
Andrew Gaul
8a73d9fff0
Correct obvious typos in usage and README
2015-05-04 16:25:05 -07:00
Andrew Gaul
28ee9f27b9
Add usage information for multipart_size
...
Also improve error message.
2015-05-04 16:21:58 -07:00
Dan Moore
5b11ac0f4c
Moved __APPLE__ #endif to correct position
2015-04-27 12:14:09 -07:00
Dan Moore
adb5a35097
configure.ac: detect target, if target is darwin (OSX), then
...
change the minimum version of fuse required. Change the
checkers to use a variable for the minimum fuse version
instead of it being hardcoded in four different places.
src/s3fs.cpp: Use __APPLE__ define around fuse code that
is offensive to osxfuse. Not including the code doesn't
seem to matter.
2015-04-25 17:13:20 -07:00
Takeshi Nakatani
aac92bd6c0
Fixed wrong owner checking and return codes
2015-04-21 16:18:05 +00:00
Takeshi Nakatani
f258a14070
Supported extended attributes, initial commit
2015-04-20 17:24:57 +00:00
Peter A. Bigot
92fcee824b
curl: use pathrequeststyle option when constructing Host endpoint
...
Buckets with mixed-case names can't be accessed with the virtual-hosted
style API due to DNS limitations. S3FS has an option for
pathrequeststyle which is used for the URL, but it was not applied when
building the endpoint passed through the Host header. Fix this, and
relax the validation on bucket names when using this style.
See: http://docs.aws.amazon.com/AmazonS3/latest/dev/UsingBucket.html#access-bucket-intro
Signed-off-by: Peter A. Bigot <pab@pabigot.com>
2015-04-19 08:31:40 -05:00
Takeshi Nakatani
490ed8f689
Reviewed and fixed response codes print in curl.cpp - #157
2015-04-18 13:32:04 +00:00
Ka-Hing Cheung
70097709b2
switch to use region specific endpoints to compute correct v4 signature
...
fix #133
2015-04-14 16:25:17 -07:00
