Merge remote-tracking branch 'origin/pr/1081'

* origin/pr/1081:
  Revisit -no-console option for Windows
This commit is contained in:
Jakob Borg 2014-12-06 12:17:46 +01:00
commit 43d569741b
3 changed files with 21 additions and 0 deletions

View File

@ -188,6 +188,7 @@ var (
doUpgrade bool doUpgrade bool
doUpgradeCheck bool doUpgradeCheck bool
noBrowser bool noBrowser bool
noConsole bool
generateDir string generateDir string
logFile string logFile string
noRestart = os.Getenv("STNORESTART") != "" noRestart = os.Getenv("STNORESTART") != ""
@ -214,6 +215,9 @@ func main() {
logFile = filepath.Join(defConfDir, "syncthing.log") logFile = filepath.Join(defConfDir, "syncthing.log")
flag.StringVar(&logFile, "logfile", logFile, "Log file name (blank for stdout)") flag.StringVar(&logFile, "logfile", logFile, "Log file name (blank for stdout)")
// We also add an option to hide the console window
flag.BoolVar(&noConsole, "no-console", false, "Hide console window")
} }
flag.StringVar(&generateDir, "generate", "", "Generate key and config in specified dir, then exit") flag.StringVar(&generateDir, "generate", "", "Generate key and config in specified dir, then exit")
@ -232,6 +236,10 @@ func main() {
flag.Usage = usageFor(flag.CommandLine, usage, fmt.Sprintf(extraUsage, defConfDir)) flag.Usage = usageFor(flag.CommandLine, usage, fmt.Sprintf(extraUsage, defConfDir))
flag.Parse() flag.Parse()
if noConsole {
osutil.HideConsole()
}
if confDir == "" { if confDir == "" {
// Not set as default above because the string can be really long. // Not set as default above because the string can be really long.
confDir = defConfDir confDir = defConfDir

View File

@ -24,3 +24,5 @@ func HideFile(path string) error {
func ShowFile(path string) error { func ShowFile(path string) error {
return nil return nil
} }
func HideConsole() {}

View File

@ -48,3 +48,14 @@ func ShowFile(path string) error {
attrs &^= syscall.FILE_ATTRIBUTE_HIDDEN attrs &^= syscall.FILE_ATTRIBUTE_HIDDEN
return syscall.SetFileAttributes(p, attrs) return syscall.SetFileAttributes(p, attrs)
} }
func HideConsole() {
getConsoleWindow := syscall.NewLazyDLL("kernel32.dll").NewProc("GetConsoleWindow")
showWindow := syscall.NewLazyDLL("user32.dll").NewProc("ShowWindow")
if getConsoleWindow.Find() == nil && showWindow.Find() == nil {
hwnd, _, _ := getConsoleWindow.Call()
if hwnd != 0 {
showWindow.Call(hwnd, 0)
}
}
}