octoleo/syncthing
1
0
Fork 0
mirror of https://github.com/octoleo/syncthing.git synced 2024-11-09 23:00:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/syncthing, lib/config: Log errors replacing or saving config (ref #3567)

Browse Source
This commit is contained in:
Jakob Borg 2016-09-24 09:58:17 +02:00
parent 3cabecda04
commit 467c1b26fb
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/syncthing/gui.go
View File

@ -765,11 +765,13 @@ func (s *apiService) postSystemConfig(w http.ResponseWriter, r *http.Request) {
// Activate and save // Activate and save
if err := s.cfg.Replace(to); err != nil { if err := s.cfg.Replace(to); err != nil {
l.Warnln("Replacing config:", err)
http.Error(w, err.Error(), http.StatusInternalServerError) http.Error(w, err.Error(), http.StatusInternalServerError)
return return
} }
if err := s.cfg.Save(); err != nil { if err := s.cfg.Save(); err != nil {
l.Warnln("Saving config:", err)
http.Error(w, err.Error(), http.StatusInternalServerError) http.Error(w, err.Error(), http.StatusInternalServerError)
return return
} }

3
lib/config/wrapper.go
View File

@ -304,15 +304,18 @@ func (w *Wrapper) Device(id protocol.DeviceID) (DeviceConfiguration, bool) {
func (w *Wrapper) Save() error { func (w *Wrapper) Save() error {
fd, err := osutil.CreateAtomic(w.path, 0600) fd, err := osutil.CreateAtomic(w.path, 0600)
if err != nil { if err != nil {
l.Debugln("CreateAtomic:", err)
return err return err
} }
if err := w.cfg.WriteXML(fd); err != nil { if err := w.cfg.WriteXML(fd); err != nil {
l.Debugln("WriteXML:", err)
fd.Close() fd.Close()
return err return err
} }
if err := fd.Close(); err != nil { if err := fd.Close(); err != nil {
l.Debugln("Close:", err)
return err return err
} }