From 479c0d3f169c3f949786bc487f05364999e10c6a Mon Sep 17 00:00:00 2001
From: Alex Ionescu <github@ionescu.sh>
Date: Sun, 8 Dec 2024 21:20:31 +0100
Subject: [PATCH] fix(gui): reflect folder password visibility by changing
 button icon (#9857)

Make the "toggle password visibility" button on encrypted
folders change its icon from `fa-eye` to `fa-eye-slash` while the
password is visible.
---
 gui/default/syncthing/core/editShareTemplate.html | 2 +-
 gui/default/syncthing/core/syncthingController.js | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/gui/default/syncthing/core/editShareTemplate.html b/gui/default/syncthing/core/editShareTemplate.html
index 701451dde..29b07026d 100644
--- a/gui/default/syncthing/core/editShareTemplate.html
+++ b/gui/default/syncthing/core/editShareTemplate.html
@@ -36,7 +36,7 @@
     </span>
     <span ng-switch="selected[id] && folderType !== 'receiveencrypted'" class="input-group-addon">
       <span ng-switch-when='true'>
-        <span class="button fas fa-fw fa-eye" ng-click="togglePasswordVisibility()"></span>
+        <span class="button fas fa-fw {{plain ? 'fa-eye-slash' : 'fa-eye'}}" ng-click="togglePasswordVisibility()"></span>
       </span>
       <span ng-switch-default>
         <span class="button fas fa-fw fa-eye" disabled></span>
diff --git a/gui/default/syncthing/core/syncthingController.js b/gui/default/syncthing/core/syncthingController.js
index 6f11e81e3..a7ac07d5d 100644
--- a/gui/default/syncthing/core/syncthingController.js
+++ b/gui/default/syncthing/core/syncthingController.js
@@ -3703,7 +3703,6 @@ angular.module('syncthing.core')
                 untrusted: '=',
             },
             link: function (scope, elem, attrs) {
-                var plain = false;
                 scope.togglePasswordVisibility = function() {
                     scope.plain = !scope.plain;
                 };