octoleo/syncthing
1
0
Fork 0
mirror of https://github.com/octoleo/syncthing.git synced 2025-01-03 07:12:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't consider prereleases for -upgrade (fixes #436)

Browse Source
This commit is contained in:
Jakob Borg 2014-07-24 12:59:51 +02:00
parent 58cc108c0c
commit 6065b6cb93
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
cmd/syncthing/upgrade_supported.go
View File

@ -27,9 +27,9 @@ import (
) )
type githubRelease struct { type githubRelease struct {
Tag string `json:"tag_name"` Tag string `json:"tag_name"`
Prelease bool `json:"prerelease"` Prerelease bool `json:"prerelease"`
Assets []githubAsset `json:"assets"` Assets []githubAsset `json:"assets"`
} }
type githubAsset struct { type githubAsset struct {
@ -49,7 +49,7 @@ func upgrade() error {
return err return err
} }
resp, err := http.Get("https://api.github.com/repos/calmh/syncthing/releases?per_page=1") resp, err := http.Get("https://api.github.com/repos/calmh/syncthing/releases?per_page=10")
if err != nil { if err != nil {
return err return err
} }
@ -58,10 +58,17 @@ func upgrade() error {
json.NewDecoder(resp.Body).Decode(&rels) json.NewDecoder(resp.Body).Decode(&rels)
resp.Body.Close() resp.Body.Close()
if len(rels) != 1 { var rel githubRelease
return fmt.Errorf("Unexpected number of releases: %d", len(rels)) for _, trel := range rels {
if !trel.Prerelease {
rel = trel
break
}
}
if len(rel.Tag) == 0 {
return errors.New("no suitable release found")
} }
rel := rels[0]
switch compareVersions(rel.Tag, Version) { switch compareVersions(rel.Tag, Version) {
case -1: case -1: