octoleo/syncthing
1
0
Fork 0
mirror of https://github.com/octoleo/syncthing.git synced 2024-11-09 14:50:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/syncthing: Be more explicit about how assets should be cached (fixes #3182)

Browse Source 
With the previous setup, browsers were free to use a local cache for any
length of time they pleased: we didn't set an 'Expires' header (or max-age
directive), and Cache-Control just said "you're free to cache this".

Therefore be more explicit: we don't mind if browsers cache things, but they
MUST revalidate everything on every request.

GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3221
This commit is contained in:
Antony Male 2016-05-30 13:54:55 +00:00 committed by Jakob Borg
parent 56b6383407
commit 6361172bea
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cmd/syncthing/gui.go
View File

@ -1267,7 +1267,10 @@ func (s embeddedStatic) ServeHTTP(w http.ResponseWriter, r *http.Request) {
}
w.Header().Set("Content-Length", fmt.Sprintf("%d", len(bs)))
w.Header().Set("Last-Modified", modified.UTC().Format(http.TimeFormat))
w.Header().Set("Cache-Control", "public")
// Strictly, no-cache means the same as this. However FF and IE treat no-cache as
// "don't hold a local cache at all", whereas everyone seems to treat this as
// you can hold a local cache, but you must revalidate it before using it.
w.Header().Set("Cache-Control", "max-age=0, must-revalidate")
w.Write(bs)
}