octoleo/syncthing
1
0
Fork 0
mirror of https://github.com/octoleo/syncthing.git synced 2025-02-02 11:58:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: Enable gometalinter "staticcheck" check

Browse Source
This commit is contained in:
Jakob Borg 2016-12-17 15:27:44 +01:00 committed by Jakob Borg
parent ead7281c20
commit 744c2e82b5
4 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
build.go
View File

@ -300,6 +300,7 @@ func runCommand(cmd string, target target) {
ok = gometalinter("varcheck", dirs) && ok ok = gometalinter("varcheck", dirs) && ok
ok = gometalinter("ineffassign", dirs) && ok ok = gometalinter("ineffassign", dirs) && ok
ok = gometalinter("unused", dirs) && ok ok = gometalinter("unused", dirs) && ok
ok = gometalinter("staticcheck", dirs) && ok
if !ok { if !ok {
os.Exit(1) os.Exit(1)
} }
@ -370,6 +371,7 @@ func setup() {
"github.com/tsenart/deadcode", "github.com/tsenart/deadcode",
"golang.org/x/net/html", "golang.org/x/net/html",
"golang.org/x/tools/cmd/cover", "golang.org/x/tools/cmd/cover",
"honnef.co/go/staticcheck/cmd/staticcheck",
"honnef.co/go/unused/cmd/unused", "honnef.co/go/unused/cmd/unused",
} }
for _, pkg := range packages { for _, pkg := range packages {

2
cmd/strelaysrv/status.go
View File

@ -42,7 +42,7 @@ func getStatus(w http.ResponseWriter, r *http.Request) {
status["goMaxProcs"] = runtime.GOMAXPROCS(-1) status["goMaxProcs"] = runtime.GOMAXPROCS(-1)
status["goNumRoutine"] = runtime.NumGoroutine() status["goNumRoutine"] = runtime.NumGoroutine()
status["kbps10s1m5m15m30m60m"] = []int64{ status["kbps10s1m5m15m30m60m"] = []int64{
rc.rate(10/10) * 8 / 1000, rc.rate(1) * 8 / 1000, // each interval is 10s
rc.rate(60/10) * 8 / 1000, rc.rate(60/10) * 8 / 1000,
rc.rate(5*60/10) * 8 / 1000, rc.rate(5*60/10) * 8 / 1000,
rc.rate(15*60/10) * 8 / 1000, rc.rate(15*60/10) * 8 / 1000,

2
lib/model/rwfolder.go
View File

@ -494,7 +494,7 @@ nextFile:
select { select {
case <-f.stop: case <-f.stop:
// Stop processing files if the puller has been told to stop. // Stop processing files if the puller has been told to stop.
break break nextFile
default: default:
} }

2
lib/sync/sync_test.go
View File

@ -157,6 +157,7 @@ func TestRWMutex(t *testing.T) {
}() }()
mut.Lock() mut.Lock()
_ = 1 // skip empty critical section check
mut.Unlock() mut.Unlock()
if len(messages) != 2 { if len(messages) != 2 {
@ -170,6 +171,7 @@ func TestRWMutex(t *testing.T) {
mut.RLock() mut.RLock()
mut.RLock() mut.RLock()
mut.RLock() mut.RLock()
_ = 1 // skip empty critical section check
mut.RUnlock() mut.RUnlock()
mut.RUnlock() mut.RUnlock()
mut.RUnlock() mut.RUnlock()