From 79ae24df7688c37a7a897218c87bff412a887b9d Mon Sep 17 00:00:00 2001 From: Jakob Borg Date: Thu, 11 Apr 2024 13:23:29 +0200 Subject: [PATCH] lib/nat: Don't crash on empty address list (fixes #9503) (#9504) --- lib/nat/service.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/nat/service.go b/lib/nat/service.go index 8ff66a380..d0644c319 100644 --- a/lib/nat/service.go +++ b/lib/nat/service.go @@ -233,9 +233,8 @@ func (s *Service) verifyExistingLocked(ctx context.Context, mapping *Mapping, na default: } - // Delete addresses for NATDevice's that do not exist anymore - nat, ok := nats[id] - if !ok { + if nat, ok := nats[id]; !ok || len(extAddrs) == 0 { + // Delete addresses for NATDevice's that do not exist anymore mapping.removeAddressLocked(id) change = true continue