From 896f9725ec184702e2cfb6fde7eefe5dda198953 Mon Sep 17 00:00:00 2001 From: Jakob Borg Date: Tue, 12 Nov 2024 10:50:19 +0100 Subject: [PATCH] chore: update policy to allow approvals by contributors (#9818) This adds `allow_contributor: true` which allows approvals by contributors to the PR (but still not the author themself, which is a different thing). This allows things like pushing minor fixups while also approving. The `ignore_update_merges: true` option makes it so that someone is not considered a "contributor" just because they push the merge button to update the branch. In principle this is not needed given the above, but I like it for clarity. --- .policy.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.policy.yml b/.policy.yml index 0878594ee..58c101e8b 100644 --- a/.policy.yml +++ b/.policy.yml @@ -48,6 +48,9 @@ approval_rules: count: 1 teams: - syncthing/maintainers + options: + ignore_update_merges: true + allow_contributor: true # Regular pull requests require approval by an active contributor - name: is approved by a syncthing contributor @@ -55,6 +58,9 @@ approval_rules: count: 1 teams: - syncthing/contributors + options: + ignore_update_merges: true + allow_contributor: true # Changes to some files (translations, dependencies, compatibility) do not # require approval if they were proposed by a contributor and have a