lib/model: Create root directory for paused folders (fixes #4094)

GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4095

cmd/syncthing/main.go

@@ -815,6 +815,7 @@ func syncthingMain(runtimeOptions RuntimeOptions) {
 	// Add and start folders
 	for _, folderCfg := range cfg.Folders() {
 		if folderCfg.Paused {
+			folderCfg.CreateRoot()
 			continue
 		}
 		m.AddFolder(folderCfg)

lib/config/folderconfiguration.go

@@ -104,6 +104,26 @@ func (f *FolderConfiguration) HasMarker() bool {
 	return err == nil
 }
 
+func (f *FolderConfiguration) CreateRoot() (err error) {
+	// Directory permission bits. Will be filtered down to something
+	// sane by umask on Unixes.
+	permBits := os.FileMode(0777)
+	if runtime.GOOS == "windows" {
+		// Windows has no umask so we must chose a safer set of bits to
+		// begin with.
+		permBits = 0700
+	}
+
+	if _, err = os.Stat(f.Path()); os.IsNotExist(err) {
+		if err = osutil.MkdirAll(f.Path(), permBits); err != nil {
+			l.Warnf("Creating directory for %v: %v",
+				f.Description(), err)
+		}
+	}
+
+	return err
+}
+
 func (f FolderConfiguration) Description() string {
 	if f.Label == "" {
 		return f.ID

lib/model/model.go

@@ -231,18 +231,9 @@ func (m *Model) startFolderLocked(folder string) config.FolderType {
 
 		// Directory permission bits. Will be filtered down to something
 		// sane by umask on Unixes.
-		permBits := os.FileMode(0777)
-		if runtime.GOOS == "windows" {
-			// Windows has no umask so we must chose a safer set of bits to
-			// begin with.
-			permBits = 0700
-		}
 
-		if _, err := os.Stat(cfg.Path()); os.IsNotExist(err) {
+		cfg.CreateRoot()
-			if err := osutil.MkdirAll(cfg.Path(), permBits); err != nil {
+
-				l.Warnln("Creating folder:", err)
-			}
-		}
 		if err := cfg.CreateMarker(); err != nil {
 			l.Warnln("Creating folder marker:", err)
 		}
@@ -2385,6 +2376,7 @@ func (m *Model) CommitConfiguration(from, to config.Configuration) bool {
 			// A folder was added.
 			if cfg.Paused {
 				l.Infoln(m, "Paused folder", cfg.Description())
+				cfg.CreateRoot()
 			} else {
 				l.Infoln(m, "Adding folder", cfg.Description())
 				m.AddFolder(cfg)