diff --git a/README.md b/README.md index 796e2406d..1ab81a2c9 100644 --- a/README.md +++ b/README.md @@ -111,3 +111,4 @@ All code is licensed under the [MPLv2 License][7]. [13]: https://github.com/syncthing/syncthing/blob/master/GOALS.md [14]: assets/logo-text-128.png [15]: https://syncthing.net/ + diff --git a/lib/model/model.go b/lib/model/model.go index f86676b4b..5ecaeb648 100644 --- a/lib/model/model.go +++ b/lib/model/model.go @@ -382,12 +382,12 @@ func (m *Model) RestartFolder(cfg config.FolderConfiguration) { m.pmut.Lock() m.tearDownFolderLocked(cfg.ID) - if !cfg.Paused { + if cfg.Paused { + l.Infoln("Paused folder", cfg.Description()) + } else { m.addFolderLocked(cfg) folderType := m.startFolderLocked(cfg.ID) l.Infoln("Restarted folder", cfg.Description(), fmt.Sprintf("(%s)", folderType)) - } else { - l.Infoln("Paused folder", cfg.Description()) } m.pmut.Unlock() @@ -1222,17 +1222,17 @@ func (m *Model) handleAutoAccepts(deviceCfg config.DeviceConfiguration, folder p return false } - // Folder already exists. - if !m.folderSharedWith(folder.ID, deviceCfg.DeviceID) { - m.fmut.Lock() - w := m.shareFolderWithDeviceLocked(deviceCfg.DeviceID, folder.ID, protocol.DeviceID{}) - m.fmut.Unlock() - w.Wait() - l.Infof("Shared %s with %s due to auto-accept", folder.ID, deviceCfg.DeviceID) - return true + // Folder does not exist yet. + if m.folderSharedWith(folder.ID, deviceCfg.DeviceID) { + return false } - return false + m.fmut.Lock() + w := m.shareFolderWithDeviceLocked(deviceCfg.DeviceID, folder.ID, protocol.DeviceID{}) + m.fmut.Unlock() + w.Wait() + l.Infof("Shared %s with %s due to auto-accept", folder.ID, deviceCfg.DeviceID) + return true } func (m *Model) introduceDevice(device protocol.Device, introducerCfg config.DeviceConfiguration) { @@ -2560,7 +2560,6 @@ func (m *Model) checkDeviceFolderConnectedLocked(device protocol.DeviceID, folde if !m.folderDevices.has(device, folder) { return errors.New("folder is not shared with device") } - return nil }