From a2f51c85c2748fa392193b31c2734b92198ed7d0 Mon Sep 17 00:00:00 2001 From: Simon Frei Date: Thu, 10 May 2018 21:39:33 +0200 Subject: [PATCH] lib/osutil: Add test for IsDeleted (ref #4925) (#4936) --- lib/osutil/osutil_test.go | 64 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 64 insertions(+) diff --git a/lib/osutil/osutil_test.go b/lib/osutil/osutil_test.go index 82e41ffe2..c6ee2d487 100644 --- a/lib/osutil/osutil_test.go +++ b/lib/osutil/osutil_test.go @@ -8,7 +8,9 @@ package osutil_test import ( "os" + "path/filepath" "runtime" + "strings" "testing" "github.com/syncthing/syncthing/lib/fs" @@ -204,3 +206,65 @@ func TestInWritableDirWindowsRename(t *testing.T) { } } } + +func TestIsDeleted(t *testing.T) { + type tc struct { + path string + isDel bool + } + cases := []tc{ + {"del", true}, + {"del.file", false}, + {"del/del", true}, + {"file", false}, + {"linkToFile", false}, + {"linkToDel", false}, + {"linkToDir", false}, + {"linkToDir/file", true}, + {"file/behindFile", true}, + {"dir", false}, + {"dir.file", false}, + {"dir/file", false}, + {"dir/del", true}, + {"dir/del/del", true}, + {"del/del/del", true}, + } + + testFs := fs.NewFilesystem(fs.FilesystemTypeBasic, "testdata") + + testFs.MkdirAll("dir", 0777) + for _, f := range []string{"file", "del.file", "dir.file", "dir/file"} { + fd, err := testFs.Create(f) + if err != nil { + t.Fatal(err) + } + fd.Close() + } + if runtime.GOOS != "windows" { + // Can't create unreadable dir on windows + testFs.MkdirAll("inacc", 0777) + if err := testFs.Chmod("inacc", 0000); err == nil { + if _, err := testFs.Lstat("inacc/file"); fs.IsPermission(err) { + // May fail e.g. if tests are run as root -> just skip + cases = append(cases, tc{"inacc", false}, tc{"inacc/file", false}) + } + } + } + for _, n := range []string{"Dir", "File", "Del"} { + if err := osutil.DebugSymlinkForTestsOnly(filepath.Join(testFs.URI(), strings.ToLower(n)), filepath.Join(testFs.URI(), "linkTo"+n)); err != nil { + if runtime.GOOS == "windows" { + t.Skip("Symlinks aren't working") + } + t.Fatal(err) + } + } + + for _, c := range cases { + if osutil.IsDeleted(testFs, c.path) != c.isDel { + t.Errorf("IsDeleted(%v) != %v", c.path, c.isDel) + } + } + + testFs.Chmod("inacc", 0777) + os.RemoveAll("testdata") +}