octoleo/syncthing
1
0
Fork 0
mirror of https://github.com/octoleo/syncthing.git synced 2025-01-03 07:12:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

build: Tests should run with Go 1.20 on Windows (#8924)

Browse Source 
Tests should run with Go 1.20 on Windows
This commit is contained in:
Jakob Borg 2023-06-05 10:19:47 +02:00 committed by GitHub
parent 2b17db8aa3
commit ae176ea9cd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/build-syncthing.yaml vendored
View File

@ -67,10 +67,6 @@ jobs:
go run build.go go run build.go
- name: Test - name: Test
# Our Windows tests currently don't work on Go 1.20
# https://github.com/syncthing/syncthing/issues/8779
# https://github.com/syncthing/syncthing/issues/8778
if: "!(matrix.go == '1.20' && matrix.runner == 'windows-latest')"
run: | run: |
go run build.go test go run build.go test

9
lib/fs/basicfs_windows_test.go
View File

@ -12,7 +12,6 @@ package fs
import ( import (
"os" "os"
"path/filepath" "path/filepath"
"runtime"
"strings" "strings"
"syscall" "syscall"
"testing" "testing"
@ -37,14 +36,6 @@ func TestWindowsPaths(t *testing.T) {
{`\\192.0.2.22\network\share`, `\\192.0.2.22\network\share`, `\\192.0.2.22\network\share`}, {`\\192.0.2.22\network\share`, `\\192.0.2.22\network\share`, `\\192.0.2.22\network\share`},
} }
if runtime.Version() >= "go1.20" {
testCases = append(testCases,
testCase{`\\.\e:`, `\\.\e:\`, `e:\`},
testCase{`\\.\e:\`, `\\.\e:\`, `e:\`},
testCase{`\\.\e:\\`, `\\.\e:\`, `e:\`},
)
}
for i, testCase := range testCases { for i, testCase := range testCases {
fs := newBasicFilesystem(testCase.input) fs := newBasicFilesystem(testCase.input)
if fs.root != testCase.expectedRoot { if fs.root != testCase.expectedRoot {