From afeb606b5b473c2be0c63a3399336e22db66cc5f Mon Sep 17 00:00:00 2001
From: Jonas Thelemann <e-mail@jonas-thelemann.de>
Date: Tue, 23 Apr 2019 19:33:40 +0200
Subject: [PATCH] gui: Use of AngularJS markup in URL-valued attribute (#5667)

Using AngularJS markup (that is, AngularJS expressions enclosed in double curly braces) in HTML attributes that reference URLs is not recommended: the browser may attempt to fetch the URL before the AngularJS compiler evaluates the markup, resulting in a request for an invalid URL.
---
 gui/default/syncthing/core/majorUpgradeModalView.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gui/default/syncthing/core/majorUpgradeModalView.html b/gui/default/syncthing/core/majorUpgradeModalView.html
index 162eabe6b..91ae54526 100644
--- a/gui/default/syncthing/core/majorUpgradeModalView.html
+++ b/gui/default/syncthing/core/majorUpgradeModalView.html
@@ -6,7 +6,7 @@
       <span translate>Please consult the release notes before performing a major upgrade.</span>
     </p>
     <p>
-      <a href="https://github.com/syncthing/syncthing/releases/tag/{{upgradeInfo.latest}}" target="_blank" translate>Release Notes</a>
+      <a ng-href="https://github.com/syncthing/syncthing/releases/tag/{{upgradeInfo.latest}}" target="_blank" translate>Release Notes</a>
     </p>
   </div>
   <div class="modal-footer">