octoleo/syncthing
1
0
Fork 0
mirror of https://github.com/octoleo/syncthing.git synced 2024-11-10 07:11:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

lib/api: Fix data race in TestCSRFRequired (#9006)

Browse Source
This commit is contained in:
Emil Lundberg 2023-07-26 23:33:45 +02:00 committed by GitHub
parent f565df628c
commit b08b99e284
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/api/api_test.go
View File

@ -773,7 +773,7 @@ func TestCSRFRequired(t *testing.T) {
t.Run("/rest without a token should fail", func(t *testing.T) { t.Run("/rest without a token should fail", func(t *testing.T) {
t.Parallel() t.Parallel()
resp, err = cli.Get(baseURL + "/rest/system/config") resp, err := cli.Get(baseURL + "/rest/system/config")
if err != nil { if err != nil {
t.Fatal("Unexpected error from getting /rest/system/config:", err) t.Fatal("Unexpected error from getting /rest/system/config:", err)
} }
@ -787,7 +787,7 @@ func TestCSRFRequired(t *testing.T) {
t.Parallel() t.Parallel()
req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil) req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
req.Header.Set("X-"+csrfTokenName, csrfTokenValue) req.Header.Set("X-"+csrfTokenName, csrfTokenValue)
resp, err = cli.Do(req) resp, err := cli.Do(req)
if err != nil { if err != nil {
t.Fatal("Unexpected error from getting /rest/system/config:", err) t.Fatal("Unexpected error from getting /rest/system/config:", err)
} }
@ -801,7 +801,7 @@ func TestCSRFRequired(t *testing.T) {
t.Parallel() t.Parallel()
req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil) req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
req.Header.Set("X-API-Key", testAPIKey+"X") req.Header.Set("X-API-Key", testAPIKey+"X")
resp, err = cli.Do(req) resp, err := cli.Do(req)
if err != nil { if err != nil {
t.Fatal("Unexpected error from getting /rest/system/config:", err) t.Fatal("Unexpected error from getting /rest/system/config:", err)
} }
@ -815,7 +815,7 @@ func TestCSRFRequired(t *testing.T) {
t.Parallel() t.Parallel()
req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil) req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
req.Header.Set("Authorization", "Bearer "+testAPIKey+"X") req.Header.Set("Authorization", "Bearer "+testAPIKey+"X")
resp, err = cli.Do(req) resp, err := cli.Do(req)
if err != nil { if err != nil {
t.Fatal("Unexpected error from getting /rest/system/config:", err) t.Fatal("Unexpected error from getting /rest/system/config:", err)
} }
@ -829,7 +829,7 @@ func TestCSRFRequired(t *testing.T) {
t.Parallel() t.Parallel()
req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil) req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
req.Header.Set("X-API-Key", testAPIKey) req.Header.Set("X-API-Key", testAPIKey)
resp, err = cli.Do(req) resp, err := cli.Do(req)
if err != nil { if err != nil {
t.Fatal("Unexpected error from getting /rest/system/config:", err) t.Fatal("Unexpected error from getting /rest/system/config:", err)
} }
@ -843,7 +843,7 @@ func TestCSRFRequired(t *testing.T) {
t.Parallel() t.Parallel()
req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil) req, _ := http.NewRequest("GET", baseURL+"/rest/system/config", nil)
req.Header.Set("Authorization", "Bearer "+testAPIKey) req.Header.Set("Authorization", "Bearer "+testAPIKey)
resp, err = cli.Do(req) resp, err := cli.Do(req)
if err != nil { if err != nil {
t.Fatal("Unexpected error from getting /rest/system/config:", err) t.Fatal("Unexpected error from getting /rest/system/config:", err)
} }