octoleo/syncthing
1
0
Fork 0
mirror of https://github.com/octoleo/syncthing.git synced 2025-01-03 15:17:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

FetchLatestReleases: just log the error here

Browse Source 
Since the return value is being ignored by the caller.
This commit is contained in:
Michael Ploujnikov 2015-11-23 18:41:50 -05:00
parent f12bf8c09a
commit bd4a14519c
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/upgrade/upgrade_supported.go
View File

@ -49,20 +49,22 @@ var insecureHTTP = &http.Client{
// FetchLatestReleases returns the latest releases, including prereleases or // FetchLatestReleases returns the latest releases, including prereleases or
// not depending on the argument // not depending on the argument
func FetchLatestReleases(releasesURL, version string) ([]Release, error) { func FetchLatestReleases(releasesURL, version string) ([]Release) {
resp, err := insecureHTTP.Get(releasesURL) resp, err := insecureHTTP.Get(releasesURL)
if err != nil { if err != nil {
return nil, err l.Infoln("Couldn't fetch release information:", err)
return nil
} }
if resp.StatusCode > 299 { if resp.StatusCode > 299 {
return nil, fmt.Errorf("API call returned HTTP error: %s", resp.Status) l.Infoln("API call returned HTTP error: %s", resp.Status)
return nil
} }
var rels []Release var rels []Release
json.NewDecoder(resp.Body).Decode(&rels) json.NewDecoder(resp.Body).Decode(&rels)
resp.Body.Close() resp.Body.Close()
return rels, nil return rels
} }
type SortByRelease []Release type SortByRelease []Release
@ -78,7 +80,7 @@ func (s SortByRelease) Less(i, j int) bool {
} }
func LatestRelease(releasesURL, version string) (Release, error) { func LatestRelease(releasesURL, version string) (Release, error) {
rels, _ := FetchLatestReleases(releasesURL, version) rels := FetchLatestReleases(releasesURL, version)
return SelectLatestRelease(version, rels) return SelectLatestRelease(version, rels)
} }