octoleo/syncthing
1
0
Fork 0
mirror of https://github.com/octoleo/syncthing.git synced 2025-01-03 15:17:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

lib/protocol: Use sha256.Sum256 in NewDeviceID (#6775)

Browse Source 
This is shorter, skips two allocations, makes the function inlineable
and is safer, since the compiler now check whether
DeviceIDLength == sha256.Size.
This commit is contained in:
greatroar 2020-06-21 20:38:06 +02:00 committed by GitHub
parent d985aa9e4b
commit dc145bfad7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/protocol/deviceid.go
View File

@ -33,11 +33,7 @@ func repeatedDeviceID(v byte) (d DeviceID) {
// NewDeviceID generates a new device ID from the raw bytes of a certificate // NewDeviceID generates a new device ID from the raw bytes of a certificate
func NewDeviceID(rawCert []byte) DeviceID { func NewDeviceID(rawCert []byte) DeviceID {
var n DeviceID return DeviceID(sha256.Sum256(rawCert))
hf := sha256.New()
hf.Write(rawCert)
hf.Sum(n[:0])
return n
} }
func DeviceIDFromString(s string) (DeviceID, error) { func DeviceIDFromString(s string) (DeviceID, error) {