59 Commits

Author	SHA1	Message	Date
greatroar	d00a30069a	lib/db: Constant/unused args and return values, double it.Release (#8259)	2022-04-27 20:32:44 +02:00
greatroar	7fa141ea39	all: Unused args, retvals, assignments (#7926)	2021-09-08 00:11:16 +02:00
Simon Frei	69ce121267	lib/db: Missing event-logger in write-transaction (#7793)	2021-06-27 08:43:49 +02:00
Simon Frei	23a0e18292	lib/db: Fix accounting bug when dropping indexes (#7774)	2021-06-17 10:15:11 +02:00
Simon Frei	1a22689328	lib/db: Add failure reports to failures iterating over hashes (#7755)	2021-06-07 23:10:35 +02:00
Jakob Borg	ce65aea0ab	lib/db: Use a more concurrent GC (fixes #7722) (#7750) ... This changes the GC mechanism so that the first pass (which reads all FileInfos to populate bloom filters with block & version hashes) can happen concurrently with normal database operations. The big gcMut still exists, and we grab it temporarily to block all other modifications while we set up the bloom filters. We then release the lock and let other things happen, with those other things also updating the bloom filters as required. Once the first phase is done we again grab the gcMut, knowing that we are the sole modifier of the database, and do the cleanup. I also removed the final compaction step.	2021-06-07 10:52:06 +02:00
Simon Frei	dd39556759	lib: Revert needing invalid files (fixes #7608, ref #7476) (#7609)	2021-04-29 22:01:46 +02:00
Simon Frei	f30f9c50f8	lib/db: Handle indirection error repairing sequences (fixes #7026) (#7525)	2021-04-05 10:24:16 +02:00
Simon Frei	273ee09925	lib/db, lib/model: Allow needing invalid files (fixes #7474) (#7476)	2021-03-15 07:58:01 +01:00
Simon Frei	46bbc78e82	lib/db: Fix and improve removing entries from global (ref #6501) (#7336)	2021-02-08 08:38:41 +01:00
Simon Frei	78bd0341a8	all: Handle errors opening db/creating file-set (ref #5907) (#7150)	2020-12-21 12:59:22 +01:00
Simon Frei	bd0c9913cf	lib/db: Remove index ids when dropping folder (#7200)	2020-12-21 11:10:59 +01:00
Simon Frei	27c91c57d5	lib/db: Remove need for the right dev removing globals (fixes #7036) (#7044)	2020-10-21 08:26:10 +02:00
Jakob Borg	674fca3868	lib/db, lib/protocol: Never need empty-version entries (fixes #6961) (#6962) ... Avoid havoc when discovering locally-deleted-upgraded files during repair / need calculation... Co-authored-by: Simon Frei <freisim93@gmail.com>	2020-09-07 20:18:25 +02:00
Simon Frei	52d1681fe6	lib/db: Copy returned, old FileVersion (#6952)	2020-09-04 14:13:38 +02:00
Simon Frei	7b821d2550	lib/db: Add local need check&repair (#6950)	2020-09-04 14:01:46 +02:00
Simon Frei	0e3e0a7c9e	cmd/stindex, lib/db: Use same condition to check for needed files (#6954)	2020-09-04 13:59:04 +02:00
Simon Frei	8f5215878b	lib/db: Don't put truncated files (ref #6855, ref #6501) (#6888)	2020-08-18 09:20:12 +02:00
Simon Frei	850dd4cd25	lib/db: Don't count invalid items to global state (ref #6850) (#6863)	2020-07-30 13:49:14 +02:00
Simon Frei	08e0f938a9	lib/db: Update global meta even if unchanged (fixes #6850) (#6852)	2020-07-24 12:36:16 +02:00
Audrius Butkevicius	55147f5901	lib/db: Rework flush hooks (#6838)	2020-07-19 08:55:27 +02:00
André Colomb	46536509d7	lib/protocol: Avoid panic in DeviceIDFromBytes (#6714)	2020-06-07 10:31:12 +02:00
Simon Frei	1f8e6c55f6	lib/db: Refactor to use global list by version (fixes #6372) (#6638) ... Group the global list of files by version, instead of having one flat list for all devices. This removes lots of duplicate protocol.Vectors. Co-authored-by: Jakob Borg <jakob@kastelo.net>	2020-05-30 09:50:23 +02:00
Jakob Borg	94beed5c10	lib/db: Add Badger backend (fixes #5910) (#6250)	2020-05-29 13:43:02 +02:00
Simon Frei	5b34c31cb3	lib/db: Don't panic on seq. coruption when debugging (#6662)	2020-05-18 10:42:51 +02:00
Jakob Borg	531ceb2b0f	Add indirection for large version vectors. (#6376) ... This adds indirection of large version vectors in the same manner as we already to block lists. The effect is the same: less duplicated data in some situations. To mitigate the impact for when this indirection wouldn't be needed I've added an indirection cutoff for both blocks and the new version vector stuff: we don't do the indirection at all for small block lists or small version vectors, instead storing it directly like we used to do. This is faster for small files and small setups.	2020-05-13 14:28:42 +02:00
Simon Frei	ba4462a70b	lib/db: Fix updating/removing from global (ref #6413) (#6635)	2020-05-13 12:56:49 +02:00
Audrius Butkevicius	decb967969	all: Reorder sequences for better rename detection (#6574)	2020-05-11 20:15:11 +02:00
Simon Frei	a94951becd	lib/db, lib/model: Keep need stats in metadata (ref #5899) (#6413)	2020-05-11 15:07:06 +02:00
Audrius Butkevicius	da99203dcd	lib/db: Fix non-truncated fileinfo loading (#6621)	2020-05-08 20:31:43 +01:00
Simon Frei	22242d51be	lib/db: Refactor getting global lists (#6529) ... * lib/db: Refactor getting global lists * VL -> Versions * keyBuf * don't touch db migration	2020-05-01 08:30:20 +01:00
Simon Frei	df318ed370	lib/db: Don't get blocklists on drop and missing continue (ref #6457) (#6502)	2020-04-07 13:13:18 +02:00
Jakob Borg	c4abe6f815	lib/db: Don't whack blocks when putting truncated file (#6434) ... As of the latest database checker we are again putting files without blocks. I'm not 100% convinced that's a great idea, but we also do it for ignored files apparently so it looks like we probably should support it. This adds an escape hatch that must be manually enabled...	2020-03-20 12:07:14 +01:00
Simon Frei	cf11fa4327	lib/db: Fix removeFromGlobal and no filenames in error (fixes #6427) (#6428)	2020-03-19 14:32:22 +01:00
Simon Frei	40580d8b9b	lib/db: Remove emptied global list in checkGlobals (fixes #6425) (#6426)	2020-03-19 14:30:20 +01:00
Simon Frei	1bd4ea0cbb	lib/db: Don't ignore failures unmarshaling version lists (#6411)	2020-03-16 10:09:27 +01:00
Simon Frei	a1cb1d70c4	lib/db: Use need func in withNeed and simplify (#6412)	2020-03-16 08:45:45 +01:00
Jakob Borg	4f7a77597e	lib/db: Slightly improve indirection (ref #6372) (#6373) ... I was working on indirecting version vectors, and that resulted in some refactoring and improving the existing block indirection stuff. We may or may not end up doing the version vector indirection, but I think these changes are reasonable anyhow and will simplify the diff significantly if we do go there. The main points are: - A bunch of renaming to make the indirection and GC not about "blocks" but about "indirection". - Adding a cutoff so that we don't actually indirect for small block lists. This gets us better performance when handling small files as it cuts out the indirection for quite small loss in space efficiency. - Being paranoid and always recalculating the hash on put. This costs some CPU, but the consequences if a buggy or malicious implementation silently substituted the block list by lying about the hash would be bad.	2020-02-27 11:19:21 +01:00
Jakob Borg	10cb14fcb8	lib/db: Allow put partial FileInfo without blocks (ref #6353)	2020-02-22 17:44:34 +01:00
Simon Frei	32e12abb43	lib/db: Don't panic on incorrect BlocksHash (fixes #6353) (#6355)	2020-02-22 16:51:23 +01:00
Simon Frei	fae7425bbf	lib: Modify FileInfos consistently (ref #6321) (#6349)	2020-02-19 16:58:09 +01:00
Simon Frei	05e23f1991	lib/db: Don't call backend.Commit twice (ref #6337) (#6342)	2020-02-14 08:11:24 +01:00
Jakob Borg	a728743c86	lib/db: Use Commit() instead of commit() (#6330) ... The readWriteTransaction offered both commit() (the one to use) and Commit() (via embedding) where the latter didn't close the read transaction. This removes the lower cased variant in order to prevent the mistake. The only place where the mistake was made was the new gc runner, where it would leave a read snapshot open forever.	2020-02-12 11:59:55 +01:00
Jakob Borg	04e648fee6	lib/db: Handle missing block lists as missing file (ref #6321) (#6322) ... Also explicitly handle non-nil but empty block lists (if they should ever pop up as an effect of unmarshalling changes or whatnot).	2020-02-11 15:37:22 +01:00
Jakob Borg	8fc2dfad0c	lib/db: Deduplicate block lists in database (fixes #5898) (#6283) ... * lib/db: Deduplicate block lists in database (fixes #5898) This moves the block list in the database out from being just a field on the FileInfo to being an object of its own. When putting a FileInfo we marshal the block list separately and store it keyed by the sha256 of the marshalled block list. When getting, if we are not doing a "truncated" get, we do an extra read and unmarshal for the block list. Old block lists are cleared out by a periodic GC sweep. The alternative would be to use refcounting, but: - There is a larger risk of getting that wrong and either dropping a block list in error or keeping them around forever. - It's tricky with our current database, as we don't have dirty reads. This means that if we update two FileInfos with identical block lists in the same transaction we can't just do read/modify/write for the ref counters as we wouldn't see our own first update. See above about tracking this and risks about getting it wrong. GC uses a bloom filter for keys to avoid heavy RAM usage. GC can't run concurrently with FileInfo updates so there is a new lock around those operation at the lowlevel. The end result is a much more compact database, especially for setups with many peers where files get duplicated many times. This is per-key-class stats for a large database I'm currently working with, under the current schema: ``` 0x00: 9138161 items, 870876 KB keys + 7397482 KB data, 95 B + 809 B avg, 1637651 B max 0x01: 185656 items, 10388 KB keys + 1790909 KB data, 55 B + 9646 B avg, 924525 B max 0x02: 916890 items, 84795 KB keys + 3667 KB data, 92 B + 4 B avg, 192 B max 0x03: 384 items, 27 KB keys + 5 KB data, 72 B + 15 B avg, 87 B max 0x04: 1109 items, 17 KB keys + 17 KB data, 15 B + 15 B avg, 69 B max 0x06: 383 items, 3 KB keys + 0 KB data, 9 B + 2 B avg, 18 B max 0x07: 510 items, 4 KB keys + 12 KB data, 9 B + 24 B avg, 41 B max 0x08: 1349 items, 12 KB keys + 10 KB data, 9 B + 8 B avg, 17 B max 0x09: 194 items, 0 KB keys + 123 KB data, 5 B + 634 B avg, 11484 B max 0x0a: 3 items, 0 KB keys + 0 KB data, 14 B + 7 B avg, 30 B max 0x0b: 181836 items, 2363 KB keys + 10694 KB data, 13 B + 58 B avg, 173 B max Total 10426475 items, 968490 KB keys + 9202925 KB data. ``` Note 7.4 GB of data in class 00, total size 9.2 GB. After running the migration we get this instead: ``` 0x00: 9138161 items, 870876 KB keys + 2611392 KB data, 95 B + 285 B avg, 4788 B max 0x01: 185656 items, 10388 KB keys + 1790909 KB data, 55 B + 9646 B avg, 924525 B max 0x02: 916890 items, 84795 KB keys + 3667 KB data, 92 B + 4 B avg, 192 B max 0x03: 384 items, 27 KB keys + 5 KB data, 72 B + 15 B avg, 87 B max 0x04: 1109 items, 17 KB keys + 17 KB data, 15 B + 15 B avg, 69 B max 0x06: 383 items, 3 KB keys + 0 KB data, 9 B + 2 B avg, 18 B max 0x07: 510 items, 4 KB keys + 12 KB data, 9 B + 24 B avg, 41 B max 0x09: 194 items, 0 KB keys + 123 KB data, 5 B + 634 B avg, 11484 B max 0x0a: 3 items, 0 KB keys + 0 KB data, 14 B + 17 B avg, 51 B max 0x0b: 181836 items, 2363 KB keys + 10694 KB data, 13 B + 58 B avg, 173 B max 0x0d: 44282 items, 1461 KB keys + 61081 KB data, 33 B + 1379 B avg, 1637399 B max Total 10469408 items, 969939 KB keys + 4477905 KB data. ``` Class 00 is now down to 2.6 GB, with just 61 MB added in class 0d. There will be some additional reads in some cases which theoretically hurts performance, but this will be more than compensated for by smaller writes and better compaction. On my own home setup which just has three devices and a handful of folders the difference is smaller in absolute numbers of course, but still less than half the old size: ``` 0x00: 297122 items, 20894 KB keys + 306860 KB data, 70 B + 1032 B avg, 103237 B max 0x01: 115299 items, 7738 KB keys + 17542 KB data, 67 B + 152 B avg, 419 B max 0x02: 1430537 items, 121223 KB keys + 5722 KB data, 84 B + 4 B avg, 253 B max ... Total 1947412 items, 151268 KB keys + 337485 KB data. ``` to: ``` 0x00: 297122 items, 20894 KB keys + 37038 KB data, 70 B + 124 B avg, 520 B max 0x01: 115299 items, 7738 KB keys + 17542 KB data, 67 B + 152 B avg, 419 B max 0x02: 1430537 items, 121223 KB keys + 5722 KB data, 84 B + 4 B avg, 253 B max ... 0x0d: 18041 items, 595 KB keys + 71964 KB data, 33 B + 3988 B avg, 101109 B max Total 1965447 items, 151863 KB keys + 139628 KB data. ``` * wip * wip * wip * wip	2020-01-24 08:35:44 +01:00
Simon Frei	08f0e125ef	all: Transactionalize db.FileSet (fixes #5952) (#6239)	2020-01-21 18:23:08 +01:00
Simon Frei	0bec01b827	lib/db: Remove *instance by making everything *Lowlevel (#6204)	2019-12-02 08:18:04 +01:00
Jakob Borg	c71116ee94	Implement database abstraction, error checking (ref #5907) (#6107) ... This PR does two things, because one lead to the other: - Move the leveldb specific stuff into a small "backend" package that defines a backend interface and the leveldb implementation. This allows, potentially, in the future, switching the db implementation so another KV store should we wish to do so. - Add proper error handling all along the way. The db and backend packages are now errcheck clean. However, I drew the line at modifying the FileSet API in order to keep this manageable and not continue refactoring all of the rest of Syncthing. As such, the FileSet methods still panic on database errors, except for the "database is closed" error which is instead handled by silently returning as quickly as possible, with the assumption that we're anyway "on the way out".	2019-11-29 09:11:52 +01:00
Simon Frei	fe4daf242b	cmd, lib/db: Actually close goleveldb (fixes #5505) (#5671)	2019-05-02 11:15:00 +02:00
Simon Frei	ca3ae64bbf	lib/db: Flush batch based on size and refactor (fixes #5531) (#5536) ... Flush the batch when exceeding a certain size, instead of when reaching a number of batched operations. Move batch to lowlevel to be able to use it in NamespacedKV. Increase the leveldb memory buffer from 4 to 16 MiB.	2019-02-14 23:15:13 +00:00