Jakob Borg
c0d02a65c3
Reduce allocations during iteration
...
Reuses key byte slices to reduce allocations:
benchmark old allocs new allocs delta
Benchmark10kReplace 178112 168615 -5.33%
Benchmark10kUpdateChg 567954 561557 -1.13%
Benchmark10kUpdateSme 238691 228680 -4.19%
Benchmark10kNeed2k 105382 103383 -1.90%
Benchmark10kHaveFullList 60230 60230 +0.00%
Benchmark10kGlobal 237484 227493 -4.21%
benchmark old bytes new bytes delta
Benchmark10kReplace 8725368 7661788 -12.19%
Benchmark10kUpdateChg 58155152 57441025 -1.23%
Benchmark10kUpdateSme 16130875 14996717 -7.03%
Benchmark10kNeed2k 6561685 6338283 -3.40%
Benchmark10kHaveFullList 7611112 7611135 +0.00%
Benchmark10kGlobal 21415056 20300723 -5.20%
2015-05-24 13:08:14 +02:00
Audrius Butkevicius
3a203b8d83
Merge pull request #1861 from calmh/fix-1860
...
Be more lenient against errors when deleting (fixes #1860 )
2015-05-24 00:58:46 +01:00
Audrius Butkevicius
feecdcc7a4
Merge pull request #1854 from calmh/eventmemallocs
...
Reuse a timer instead of allocating a new one in subscription.Poll
2015-05-23 23:23:46 +01:00
Audrius Butkevicius
51ad533be6
Merge pull request #1859 from calmh/fix-1858
...
UPnP discovery results must not be collected in a background goroutine (fixes #1858 )
2015-05-23 22:58:09 +01:00
Jakob Borg
29da0bc8f5
Be more lenient against errors when deleting ( fixes #1860 )
2015-05-23 23:57:41 +02:00
Jakob Borg
bccf7fc2a8
Merge pull request #1857 from calmh/testhax
...
Refactor integration tests to be a little cleaner and more stable, I hope
2015-05-23 23:57:21 +02:00
Jakob Borg
7b6b5981c4
UPnP discovery results must not be collected in a background goroutine ( fixes #1858 )
2015-05-23 23:27:02 +02:00
Jakob Borg
9463192224
Refactor integration tests to be a little cleaner and more stable, I hope
2015-05-23 23:26:23 +02:00
Audrius Butkevicius
d1689f0012
Merge pull request #1855 from calmh/dboptsagain
...
Reduce db write cache to (2*) 4 MiB
2015-05-23 20:38:41 +01:00
Jakob Borg
8ed67fe349
Reduce db write cache to (2*) 4 MiB
...
I haven't been able to reproduce any performance advantage of having it
set higher and it reduces the memory footprint a bit.
2015-05-23 21:05:52 +02:00
Jakob Borg
90a1d99785
Reuse a timer instead of allocating a new one in subscription.Poll
...
This is surprisingly memory expensive when Poll gets called a lot, such
as when syncing lots of small files generating itemstarted/itemfinished
events. It's line number three in this heap profile on the
TestBenchmarkManyFiles test:
jb@syno:~/src/github.com/syncthing/syncthing/test (master) $ go tool pprof ../bin/syncthing heap-13194.pprof
Entering interactive mode (type "help" for commands)
(pprof) top
80.91MB of 83.05MB total (97.42%)
Dropped 1024 nodes (cum <= 0.42MB)
Showing top 10 nodes out of 85 (cum >= 1.75MB)
flat flat% sum% cum cum%
32MB 38.53% 38.53% 32.01MB 38.54% github.com/syndtr/goleveldb/leveldb/memdb.New
22.16MB 26.68% 65.21% 22.16MB 26.68% github.com/syndtr/goleveldb/leveldb/util.(*BufferPool).Get
13.02MB 15.68% 80.89% 13.02MB 15.68% time.NewTimer
6.94MB 8.35% 89.24% 6.94MB 8.35% github.com/syndtr/goleveldb/leveldb/memdb.(*DB).Put
3.18MB 3.82% 93.06% 3.18MB 3.82% github.com/calmh/xdr.(*Reader).ReadBytesMaxInto
With this change the allocation is removed entirely.
2015-05-23 20:38:41 +02:00
Jakob Borg
e215cf6fb8
Add some REST API benchmarks
2015-05-23 20:15:54 +02:00
Jakob Borg
e827c0bd94
Run benchmarks in docker-all instead
2015-05-23 15:17:19 +02:00
Jakob Borg
8dd7e4e6b5
Run benchmarks when running tests
2015-05-23 15:08:17 +02:00
Jakob Borg
a2b94f4e06
Build Debian armhf and armel
2015-05-23 13:10:33 +02:00
Jakob Borg
8b0037ffab
Make check-contribs a little more generous in recognizing a copyright header
2015-05-21 21:42:46 +02:00
Jakob Borg
4ab03f3bef
Update CONTRIBUTING to not encourage changing AUTHORS
2015-05-21 20:58:17 +02:00
Jakob Borg
3c3db52f49
Merge pull request #1842 from Zillode/fix-1822
...
Support the creation of top-level folders on Windows (fixes #1822 )
2015-05-21 20:50:52 +02:00
Jakob Borg
5b1e884659
Merge pull request #1847 from Zillode/fix-1833
...
Show date and time for web GUI notification (fixes #1833 )
2015-05-21 20:49:04 +02:00
Lode Hoste
7ec6740e26
Show date and time for web GUI notification ( fixes #1833 )
2015-05-21 19:44:45 +02:00
Lode Hoste
f12b8c19be
Support the creation of top-level folders on Windows ( fixes #1822 )
2015-05-21 19:21:19 +02:00
Jakob Borg
76174d31ce
Merge pull request #1843 from Zillode/fix-1831
...
Set permanent UPnP lease when required
2015-05-21 12:50:48 +02:00
Lode Hoste
5042248260
Set permanent UPnP lease when required ( fixes #1831 )
2015-05-21 10:48:40 +02:00
Lode Hoste
1df6589533
Add status code to SOAP response
2015-05-21 09:54:39 +02:00
Jakob Borg
12f76b448c
Merge pull request #1826 from AudriusButkevicius/screwflags
...
Don't check interface flags on Windows
2015-05-19 14:59:16 +02:00
Audrius Butkevicius
f112ef34f6
Don't check interface flags on Windows
2015-05-17 16:42:26 +01:00
Jakob Borg
e4b57a978f
Translation update
2015-05-15 10:46:47 +02:00
Audrius Butkevicius
b51e09e0e8
Merge pull request #1811 from calmh/bc
...
Further reduce maximum db block cache
2015-05-15 11:12:25 +03:00
Jakob Borg
a3ba3f895c
Further reduce maximum db block cache
2015-05-14 20:59:59 +02:00
Jakob Borg
947a129e12
Use updateLocals to ensure event generation
2015-05-14 08:56:42 +02:00
Jakob Borg
f3fe6a6cbd
Assure existence of a folder marker in the test
2015-05-14 08:46:00 +02:00
Jakob Borg
9d150bef9f
Refactor GetMtime for early return
2015-05-14 08:26:21 +02:00
Jakob Borg
65be18cc93
Merge pull request #1804 from cdhowie/virtual-mtimes
...
Implement virtual mtime support for Android
2015-05-14 08:14:29 +02:00
Jakob Borg
e27ea63900
Add cdhowie
2015-05-14 08:11:02 +02:00
Chris Howie
aa96f7b660
Virtual mtime support for environments that don't support altering mtimes ( fixes #831 )
2015-05-13 14:57:29 +00:00
Jakob Borg
053690d885
Don't attempt reschedule with zero interval
...
Can happen on manual rescans of folders with zero interval.
2015-05-13 16:51:08 +02:00
Jakob Borg
b9fc6397a3
Merge pull request #1791 from Zillode/test-master
...
Add unit test for overriding ignored files (fixes #1701 )
2015-05-13 14:50:12 +02:00
Audrius Butkevicius
19b9f15da3
Merge pull request #1803 from calmh/kvspaceclear
...
Reset a namespaced kv-store
2015-05-13 15:43:52 +03:00
Jakob Borg
0b9441e1a4
Reset a namespaced kv-store
2015-05-13 14:41:47 +02:00
Audrius Butkevicius
2324d7420c
Merge pull request #1800 from calmh/ursvc
...
Break out usage reporting into a service
2015-05-13 15:41:44 +03:00
Jakob Borg
c6b2ca8b19
Break out usage reporting into a service
2015-05-13 14:39:27 +02:00
Audrius Butkevicius
83ea8dc577
Merge pull request #1801 from calmh/fix-1799
...
Only restart global discovery on UPnP change if it was enabled to start with (fixes #1799 )
2015-05-12 18:49:24 +03:00
Jakob Borg
d898277f62
stindex: add some missing newlines
2015-05-12 11:47:30 +02:00
Jakob Borg
a289cfb986
Only restart global discovery on UPnP change if it was enabled to start with ( fixes #1799 )
2015-05-12 09:48:55 +02:00
Jakob Borg
d603998617
Debian maintainer is release team
2015-05-11 21:59:40 +02:00
Jakob Borg
8bf9f4f5ab
Build debian skeleton
2015-05-11 21:34:43 +02:00
Jakob Borg
2c4e6f2926
wip
2015-05-11 19:04:39 +02:00
Jakob Borg
21fbbc50cd
hax
2015-05-11 18:39:53 +02:00
Audrius Butkevicius
99512418da
Merge pull request #1796 from calmh/adaptive-cache-tweak
...
Tweak the database block cache size, and add config for it
2015-05-11 11:06:31 +03:00
Jakob Borg
c2f2d8771f
Tweak the database block cache size, and add config for it
2015-05-11 09:08:25 +02:00