Jakob Borg
f0684d83e9
Add osutil.AtomicWriter
...
This captures the common pattern of writing to a temp file and moving it
to it's real name only if everything went well. It reduces the amount of
code in some places where we do this, but maybe not as much as I
expected because the upgrade thing is still a special snowflake...
2015-07-20 14:27:14 +02:00
Jakob Borg
909d60464e
Revert "Merge pull request #2053 from calmh/atomicwriter" ( fixes #2058 )
...
This reverts commit b611f72e08
, reversing
changes made to a04b005e93
.
2015-07-13 12:47:32 +02:00
Jakob Borg
44e3bec42e
Add osutil.AtomicWriter
...
This captures the common pattern of writing to a temp file and moving it
to it's real name only if everything went well. It reduces the amount of
code in some places where we do this, but maybe not as much as I
expected because the upgrade thing is still a special snowflake...
2015-07-12 14:28:59 +10:00
Jakob Borg
a04b005e93
Revert "Let suture logging bubble upwards"
...
This reverts commit 1b837116e6
.
2015-07-11 11:12:20 +10:00
Jakob Borg
1b837116e6
Let suture logging bubble upwards
2015-07-11 10:52:57 +10:00
Jakob Borg
0c28216ee5
Make sure connection is added to m.protoConn and m.rawConn before it's Start()ed ( fixes #2034 )
2015-07-10 16:43:41 +10:00
Jakob Borg
b78c515724
Debug output on request errors
2015-07-10 16:01:10 +10:00
Daniel Bergmann
3fe1673ce9
Preserve setgid bit on local directores ( fixes #2012 )
...
When setting the permissions on directories with ignore permissions off,
preserve the setgid bit to it's original value instead of setting it
off.
2015-07-04 09:01:34 +01:00
Jakob Borg
2d9fcf6828
Collect puller errors, send FolderErrors event
2015-06-30 14:41:47 +02:00
Jakob Borg
2b0c33f74d
Merge pull request #1996 from AudriusButkevicius/checkrace
...
Potential race between folder being added and scan (fixes #1986 )
2015-06-26 12:56:07 +02:00
Audrius Butkevicius
31cd0b943c
Potential race between folder being added and scan (potentially fixes #1986 )
2015-06-24 21:59:03 +01:00
Jakob Borg
070eced2f6
Merge pull request #1985 from calmh/fix-reset
...
Fix reset DB
2015-06-24 14:07:15 +02:00
Audrius Butkevicius
986f8dfb2e
Remove dead variable
2015-06-24 08:43:33 +01:00
Jakob Borg
2b2cae2d50
Fix reset DB
...
The reset of all folders failed when there was no data for a given
folder, as it was not returned by db.ListFolders then. But we don't
really care about that, we can "reset" it anyway...
2015-06-21 09:35:41 +02:00
Jakob Borg
f73d5a9ab2
Serialize scans and pulls ( fixes #1391 )
2015-06-20 23:01:40 +02:00
Jakob Borg
1d2235abe7
Model must be running for tests
2015-06-20 23:00:33 +02:00
Jakob Borg
d347e54acb
Don't start model until services have been added ( fixes #1969 )
2015-06-20 20:04:47 +02:00
Audrius Butkevicius
69af77a3bd
Merge pull request #1967 from calmh/woops
...
Incorrect error condition on shortcuts
2015-06-18 11:07:07 +01:00
Jakob Borg
7767746d3e
Incorrect error condition on shortcuts
2015-06-18 11:55:43 +02:00
Jakob Borg
7af1863e81
Generate LocalIndexUpdated events in Override
...
The override should look like we detected the changes locally, or the
GUI and other things won't update correctly.
This is/was caught by the Override integration test, on my newly
refactored integration test suite which is soon ready for prime time, so
a test is coming. :)
2015-06-18 10:49:24 +02:00
Audrius Butkevicius
12a3086a9e
Add label next to "Last file received" ( fixes #1952 )
2015-06-16 12:12:34 +01:00
Jakob Borg
127b0c3332
Add version to LocalIndexUpdate event.
...
Allows correlating LocalIndexUpdate events on one device with RemoteIndexUpdated on another to make sure the cluster has converged.
2015-06-16 08:30:15 +02:00
Audrius Butkevicius
6a6593c656
Merge pull request #1948 from calmh/symwarning
...
Dont warn about irrelevant symlinks, print path to culprit (ref #1945 )
2015-06-15 10:41:51 +01:00
Jakob Borg
ad220d61f9
Merge pull request #1951 from AudriusButkevicius/voodoo
...
Voodoo
2015-06-15 11:31:03 +02:00
Audrius Butkevicius
c8457ab005
Voodoo
2015-06-15 10:22:44 +01:00
Jakob Borg
070a308217
Dont warn about irrelevant symlinks, print path to culprit (ref #1945 )
...
This skips the warning about "unsupported symlinks" for invalid or
deleted symlinks (and as a side effect also accepts them into the index,
which should be fine). It also prints the affected file paths to the
log. This should be in the hypothetical list of "errored files" we
should present instead of the cryptic "puller stopped" message in the
future...
2015-06-15 00:47:13 +02:00
Jakob Borg
c1f4477376
ItemStarted can be map[string]string
2015-06-14 22:59:21 +02:00
Jakob Borg
d728320ece
New ItemStart/Finished type 'metadata' for shortcut updates
2015-06-14 22:56:41 +02:00
Audrius Butkevicius
1d856b4723
Correctly set and clear errors for missing folders ( fixes #1937 )
2015-06-13 23:45:54 +01:00
Jakob Borg
a778763851
Add trash can file versioning ( fixes #1931 )
2015-06-12 13:30:49 +02:00
Jakob Borg
76ad925842
Refactor config commit stuff to support restartless updates better
...
Includes restartless updates of the GUI settings (listening port etc) as
a proof of concept.
2015-06-09 15:41:22 +02:00
Audrius Butkevicius
567f19bf68
Do not overwrite error value
2015-06-06 08:30:01 +01:00
Audrius Butkevicius
11cb040ad1
Merge pull request #1880 from calmh/itemfinished-err
...
Fix ItemFinished
2015-06-03 16:50:33 +01:00
Jakob Borg
c1761cab49
Trigger ItemFinished when temp file creation fails instead of failing silently
2015-06-03 16:28:31 +02:00
Audrius Butkevicius
f0e58fa804
Additional cases for detecting folders disappearing
2015-05-27 22:46:10 +01:00
Jakob Borg
7d48115b90
Reduce db writes for small files
...
We introduced the dbUpdater routine to handle many small files
efficiently, but the folder stats call is almost equally expensive as it
results in two distinct write transactions to the database. This moves
it to the same routine.
(Doesn't make a *huge* difference with leveldb actually, but reduces the
50k-files benchmark time by 25% on my experimental bolt branch...)
2015-05-27 18:36:26 +02:00
Bart De Vries
d2205228fb
Make syncthing honor both the ignorePerms and FlagNoPermBits settings ( fixes #1871 )
2015-05-26 16:27:26 +02:00
Jakob Borg
3f59d6daff
Add validation cache
2015-05-25 13:19:18 +02:00
Bart De Vries
badfc77339
Change permissions of newly created files and directories ( fixes #1339 )
2015-05-25 00:12:51 +02:00
Jakob Borg
29da0bc8f5
Be more lenient against errors when deleting ( fixes #1860 )
2015-05-23 23:57:41 +02:00
Jakob Borg
8dd7e4e6b5
Run benchmarks when running tests
2015-05-23 15:08:17 +02:00
Lode Hoste
f12b8c19be
Support the creation of top-level folders on Windows ( fixes #1822 )
2015-05-21 19:21:19 +02:00
Jakob Borg
947a129e12
Use updateLocals to ensure event generation
2015-05-14 08:56:42 +02:00
Jakob Borg
f3fe6a6cbd
Assure existence of a folder marker in the test
2015-05-14 08:46:00 +02:00
Chris Howie
aa96f7b660
Virtual mtime support for environments that don't support altering mtimes ( fixes #831 )
2015-05-13 14:57:29 +00:00
Jakob Borg
053690d885
Don't attempt reschedule with zero interval
...
Can happen on manual rescans of folders with zero interval.
2015-05-13 16:51:08 +02:00
Lode Hoste
a7482a3644
Added simple unit test for temporary filenames
2015-05-10 18:57:27 +02:00
Lode Hoste
a692348336
Retain meaningful names for temporary files
2015-05-10 18:57:27 +02:00
Jakob Borg
285dcc30cf
Use md5 hash of filename for temporary file ( fixes #1786 )
2015-05-10 18:57:27 +02:00
Jakob Borg
1133192a86
Merge remote-tracking branch 'syncthing/pr/1779'
...
* syncthing/pr/1779:
Remove stray VIM swap file
2015-05-08 20:32:02 +02:00