luzpaz
837ffcfab5
all: Fix various user-facing and non-user-facing typos ( #8509 )
...
Found via `codespell -q 3 -S lang,./gui/default/vendor -L benchs,bu,inflight,ro`
2022-08-23 15:44:11 +02:00
Jakob Borg
a3c724f2c3
all: Add build constants for runtime.GOOS comparisons ( #8442 )
...
all: Add package runtimeos for runtime.GOOS comparisons
I grew tired of hand written string comparisons. This adds generated
constants for the GOOS values, and predefined Is$OS constants that can
be iffed on. In a couple of places I rewrote trivial switch:es to if:s,
and added Illumos where we checked for Solaris (because they are
effectively the same, and if we're going to target one of them that
would be Illumos...).
2022-07-28 19:36:39 +02:00
Eng Zer Jun
bc27aa12cd
all: use T.TempDir to create temporary test directory ( #8280 )
...
This commit replaces `os.MkdirTemp` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `os.MkdirTemp`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-04-15 07:44:06 +04:00
Simon Frei
db72579f0e
lib: Get rid of buggy filesystem wrapping ( #8257 )
2022-04-10 20:55:05 +02:00
Jakob Borg
4b750b6dc3
all: Remove usage of deprecated io/ioutil ( #7971 )
...
As of Go 1.16 io/ioutil is deprecated. This replaces usage with the
corresponding functions in package os and package io.
2021-11-22 08:59:47 +01:00
Simon Frei
591e4d8af1
gui, lib: Fix tracking deleted locally-changed on encrypted ( fixes #7715 ) ( #7726 )
2021-11-10 09:46:21 +01:00
Simon Frei
df48276300
lib/model: Ensure indexes are only received after checking IDs (ref #7649 ) ( #7689 )
2021-06-03 14:58:50 +02:00
Simon Frei
22e09334ec
lib/model: Fix incoming request on receive-enc ( fixes #7699 ) ( #7702 )
2021-05-22 21:38:49 +02:00
Simon Frei
5b90a98650
lib/model: Fix addFakeConn and other test improvements ( #7684 )
2021-05-16 17:23:27 +02:00
Simon Frei
dd39556759
lib: Revert needing invalid files ( fixes #7608 , ref #7476 ) ( #7609 )
2021-04-29 22:01:46 +02:00
Simon Frei
273ee09925
lib/db, lib/model: Allow needing invalid files ( fixes #7474 ) ( #7476 )
2021-03-15 07:58:01 +01:00
Simon Frei
3d91f7c975
lib: Use counterfeiter to mock interfaces in tests ( #7375 )
2021-03-03 08:53:50 +01:00
Simon Frei
d842197931
lib/model: Disable tests involving scrypt with -short ( fixes #7344 ) ( #7346 )
2021-02-08 17:13:28 +01:00
Simon Frei
11e9d575c8
lib/model: Refactor folder.scanSubdirs into smaller parts ( #7321 )
2021-02-08 08:40:57 +01:00
Simon Frei
f63cdbfcfa
lib: Apply config changes sequentially (ref #5298 ) ( #7188 )
2021-01-15 15:43:34 +01:00
Simon Frei
78bd0341a8
all: Handle errors opening db/creating file-set (ref #5907 ) ( #7150 )
2020-12-21 12:59:22 +01:00
Simon Frei
7919310dc6
lib/model: Unflake TestIgnoreDeleteUnignore ( #7208 )
2020-12-18 18:42:09 +01:00
Simon Frei
240ae0c14f
lib/model: Unflake TestRequestReceiveEncryptedLocalNoSend ( #7167 )
2020-11-27 20:53:03 +01:00
Simon Frei
a9764fc16c
lib: Skip deleted, locally changed on recv-enc folders ( fixes #7153 ) ( #7154 )
2020-11-27 11:26:36 +01:00
Simon Frei
100ef10d84
lib/model: Don't send locally changed on recv-enc ( fixes #7137 ) ( #7147 )
2020-11-24 21:49:45 +01:00
Simon Frei
db1f20603a
lib/model: Retain index info for new folders/devs (ref #7100 ) ( #7133 )
2020-11-20 15:53:13 +01:00
Simon Frei
2d3a535ced
lib/model: Handle cluster-config before folder start ( fixes #7122 ) ( #7123 )
2020-11-17 15:30:21 +01:00
Simon Frei
b8051fb37e
lib/model: Prevent test deadlock ( #7110 )
2020-11-10 12:32:07 +01:00
Simon Frei
31559e908b
all: Add untrusted folders behind feature flag (ref #62 ) ( #7055 )
2020-11-09 15:33:32 +01:00
Simon Frei
5c91723ef2
lib/model: Handle index sender lifetime ( fixes #7034 ) ( #7038 )
2020-10-21 11:51:53 +02:00
Simon Frei
932d8c69de
lib/fs: Properly handle case insensitive systems ( fixes #1787 , fixes #2739 , fixes #5708 )
...
With this change we emulate a case sensitive filesystem on top of
insensitive filesystems. This means we correctly pick up case-only renames
and throw a case conflict error when there would be multiple files differing
only in case.
This safety check has a small performance hit (about 20% more filesystem
operations when scanning for changes). The new advanced folder option
`caseSensitiveFS` can be used to disable the safety checks, retaining the
previous behavior on systems known to be fully case sensitive.
Co-authored-by: Jakob Borg <jakob@kastelo.net>
2020-07-28 11:15:11 +02:00
Simon Frei
299b9d8883
lib/model: Adjust remote-rename-test to timer-based versions ( fixes #6625 ) ( #6644 )
2020-05-14 00:31:05 +02:00
Jakob Borg
876609a0f0
lib/model: Fix test after version vector changes ( #6607 )
2020-05-06 21:19:33 +02:00
Simon Frei
b5fc332782
lib/model: Merge add and start folder funcs and related refactor ( #6594 )
2020-05-06 08:34:54 +02:00
Simon Frei
08753ccabe
lib/model: Reset queue after all pulling is done ( fixes #5867 ) ( #6256 )
2020-01-08 12:21:22 +01:00
Simon Frei
4d368a37e2
lib/model, lib/protocol: Add contexts sending indexes and download-progress ( #6176 )
2019-11-25 11:07:36 +01:00
Simon Frei
0d14ee4142
lib/model: Don't info log repeat pull errors ( #6149 )
2019-11-19 09:56:53 +01:00
Simon Frei
85e6a77f25
lib/model: Remove some testing deadlocks ( #6138 )
2019-11-08 18:53:51 +01:00
Simon Frei
bee7cce081
lib/model: Add folders on start in model ( #6135 )
2019-11-08 10:56:16 +01:00
Simon Frei
a2a14c8424
lib/model: Set empty version when unignoring deleted files (fixes 6038) ( #6039 )
2019-10-01 15:34:59 +02:00
Simon Frei
b1c74860e8
all: Remove global events.Default (ref #4085 ) ( #5886 )
2019-08-15 16:29:37 +02:00
Simon Frei
8a06cf0973
lib/model: Unflake TestPullInvalidIgnored ( #5918 )
2019-08-01 11:07:41 +02:00
Simon Frei
df522576ac
lib/model: Don't call t.Fatal in goroutines ( fixes #5901 ) ( #5903 )
2019-07-30 17:50:51 +02:00
Simon Frei
fd847d4efe
lib/model: Fix flakyness of TestRequestRemoteRenameChanged ( #5904 )
2019-07-28 22:29:31 +02:00
Simon Frei
1cb55904bc
lib/model: Prevent panic in NeedFolderFiles ( fixes #5872 ) ( #5875 )
2019-07-19 19:39:52 +02:00
Simon Frei
cea5962417
lib/model: Unflake TestPullInvalidIgnoredSR/SO ( fixes #5796 ) ( #5799 )
2019-06-17 15:23:28 +03:00
Simon Frei
5b306510a0
lib/model: Consistently cleanup model in tests ( #5724 )
2019-05-19 14:29:07 +02:00
Simon Frei
5ffbb7668d
lib/model: Fix test flakyness regression (ref #5592 ) ( #5718 )
2019-05-18 08:52:50 +02:00
Simon Frei
2b246eeb52
lib/model: Move test utilities to separate files ( #5694 )
2019-05-10 13:33:45 +02:00
Simon Frei
fe4daf242b
cmd, lib/db: Actually close goleveldb ( fixes #5505 ) ( #5671 )
2019-05-02 11:15:00 +02:00
Simon Frei
395e524e2d
lib/model: Update db on scan/pull in folder ( #5608 )
2019-04-07 13:29:17 +02:00
Simon Frei
e7ae851900
lib/model: Debug and test fixes ( #5613 )
2019-03-22 14:43:47 +01:00
Simon Frei
189e44488e
lib/model: Introduce must test utility ( #5586 )
...
* lib/model: Introduce must test utility
* nice
2019-03-09 18:45:36 +00:00
Simon Frei
b1564e53e4
lib/model: Improve test utilities ( #5584 )
2019-03-08 20:29:09 +00:00
Simon Frei
722b3fce6a
all: Hide implementations behind interfaces for mocked testing ( #5548 )
...
* lib/model: Hide implementations behind interfaces for mocked testing
* review
2019-02-26 08:09:25 +00:00