mirror of
https://github.com/octoleo/syncthing.git
synced 2024-12-22 10:58:57 +00:00
2f15670094
This is an extract from PR #9175, which can be reviewed in isolation to reduce the volume of changes to review all at once in #9175. There are about to be several services and API handlers that read and set cookies and session state, so this abstraction will prove helpful. In particular a motivating cause for this is that with the current architecture in PR #9175, in `api.go` the [`webauthnService` needs to access the session](https://github.com/syncthing/syncthing/pull/9175/files#diff-e2e14f22d818b8e635572ef0ee7718dee875c365e07225d760a6faae8be7772dR309-R310) for authentication purposes but needs to be instantiated before the `configMuxBuilder` for config purposes, because the WebAuthn additions to config management need to perform WebAuthn registration ceremonies, but currently the session management is embedded in the `basicAuthAndSessionMiddleware` which is [instantiated much later](https://github.com/syncthing/syncthing/pull/9175/files#diff-e2e14f22d818b8e635572ef0ee7718dee875c365e07225d760a6faae8be7772dL371-R380) and only if authentication is enabled in `guiCfg`. This refactorization extracts the session management out from `basicAuthAndSessionMiddleware` so that `basicAuthAndSessionMiddleware` and `webauthnService` can both use the same shared session management service to perform session management logic. ### Testing This is a refactorization intended to not change any externally observable behaviour, so existing tests (e.g., `api_auth_test.go`) should cover this where appropriate. I have manually verified that: - Appending `+ "foo"` to the cookie name in `createSession` causes `TestHtmlFormLogin/invalid_URL_returns_403_before_auth_and_404_after_auth` and `TestHtmlFormLogin/UTF-8_auth_works` to fail - Inverting the return value of `hasValidSession` cases a whole bunch of tests in `TestHTTPLogin` and `TestHtmlFormLogin` to fail - (Fixed) Changing the cookie to `MaxAge: 1000` in `destroySession` does NOT cause any tests to fail! - Added tests `TestHtmlFormLogin/Logout_removes_the_session_cookie`, `TestHTTPLogin/*/Logout_removes_the_session_cookie`, `TestHtmlFormLogin/Session_cookie_is_invalid_after_logout` and `TestHTTPLogin/200_path#01/Session_cookie_is_invalid_after_logout` to cover this. - Manually verified that these tests pass both before and after the changes in this PR, and that changing the cookie to `MaxAge: 1000` or not calling `m.tokens.Delete(cookie.Value)` in `destroySession` makes the respective pair of tests fail.
310 lines
9.3 KiB
Go
310 lines
9.3 KiB
Go
// Copyright (C) 2014 The Syncthing Authors.
|
|
//
|
|
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
// You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
package api
|
|
|
|
import (
|
|
"crypto/tls"
|
|
"fmt"
|
|
"net"
|
|
"net/http"
|
|
"slices"
|
|
"strings"
|
|
"time"
|
|
|
|
ldap "github.com/go-ldap/ldap/v3"
|
|
"github.com/syncthing/syncthing/lib/config"
|
|
"github.com/syncthing/syncthing/lib/events"
|
|
"github.com/syncthing/syncthing/lib/rand"
|
|
)
|
|
|
|
const (
|
|
maxSessionLifetime = 7 * 24 * time.Hour
|
|
maxActiveSessions = 25
|
|
randomTokenLength = 64
|
|
)
|
|
|
|
func emitLoginAttempt(success bool, username, address string, evLogger events.Logger) {
|
|
evLogger.Log(events.LoginAttempt, map[string]interface{}{
|
|
"success": success,
|
|
"username": username,
|
|
"remoteAddress": address,
|
|
})
|
|
if !success {
|
|
l.Infof("Wrong credentials supplied during API authorization from %s", address)
|
|
}
|
|
}
|
|
|
|
func antiBruteForceSleep() {
|
|
time.Sleep(time.Duration(rand.Intn(100)+100) * time.Millisecond)
|
|
}
|
|
|
|
func unauthorized(w http.ResponseWriter, shortID string) {
|
|
w.Header().Set("WWW-Authenticate", fmt.Sprintf(`Basic realm="Authorization Required (%s)"`, shortID))
|
|
http.Error(w, "Not Authorized", http.StatusUnauthorized)
|
|
}
|
|
|
|
func forbidden(w http.ResponseWriter) {
|
|
http.Error(w, "Forbidden", http.StatusForbidden)
|
|
}
|
|
|
|
func isNoAuthPath(path string) bool {
|
|
// Local variable instead of module var to prevent accidental mutation
|
|
noAuthPaths := []string{
|
|
"/",
|
|
"/index.html",
|
|
"/modal.html",
|
|
"/rest/svc/lang", // Required to load language settings on login page
|
|
}
|
|
|
|
// Local variable instead of module var to prevent accidental mutation
|
|
noAuthPrefixes := []string{
|
|
// Static assets
|
|
"/assets/",
|
|
"/syncthing/",
|
|
"/vendor/",
|
|
"/theme-assets/", // This leaks information from config, but probably not sensitive
|
|
|
|
// No-auth API endpoints
|
|
"/rest/noauth",
|
|
}
|
|
|
|
return slices.Contains(noAuthPaths, path) ||
|
|
slices.ContainsFunc(noAuthPrefixes, func(prefix string) bool {
|
|
return strings.HasPrefix(path, prefix)
|
|
})
|
|
}
|
|
|
|
type basicAuthAndSessionMiddleware struct {
|
|
tokenCookieManager *tokenCookieManager
|
|
guiCfg config.GUIConfiguration
|
|
ldapCfg config.LDAPConfiguration
|
|
next http.Handler
|
|
evLogger events.Logger
|
|
}
|
|
|
|
func newBasicAuthAndSessionMiddleware(tokenCookieManager *tokenCookieManager, guiCfg config.GUIConfiguration, ldapCfg config.LDAPConfiguration, next http.Handler, evLogger events.Logger) *basicAuthAndSessionMiddleware {
|
|
return &basicAuthAndSessionMiddleware{
|
|
tokenCookieManager: tokenCookieManager,
|
|
guiCfg: guiCfg,
|
|
ldapCfg: ldapCfg,
|
|
next: next,
|
|
evLogger: evLogger,
|
|
}
|
|
}
|
|
|
|
func (m *basicAuthAndSessionMiddleware) ServeHTTP(w http.ResponseWriter, r *http.Request) {
|
|
if hasValidAPIKeyHeader(r, m.guiCfg) {
|
|
m.next.ServeHTTP(w, r)
|
|
return
|
|
}
|
|
|
|
if m.tokenCookieManager.hasValidSession(r) {
|
|
m.next.ServeHTTP(w, r)
|
|
return
|
|
}
|
|
|
|
// Fall back to Basic auth if provided
|
|
if username, ok := attemptBasicAuth(r, m.guiCfg, m.ldapCfg, m.evLogger); ok {
|
|
m.tokenCookieManager.createSession(username, false, w, r)
|
|
m.next.ServeHTTP(w, r)
|
|
return
|
|
}
|
|
|
|
// Exception for static assets and REST calls that don't require authentication.
|
|
if isNoAuthPath(r.URL.Path) {
|
|
m.next.ServeHTTP(w, r)
|
|
return
|
|
}
|
|
|
|
// Some browsers don't send the Authorization request header unless prompted by a 401 response.
|
|
// This enables https://user:pass@localhost style URLs to keep working.
|
|
if m.guiCfg.SendBasicAuthPrompt {
|
|
unauthorized(w, m.tokenCookieManager.shortID)
|
|
return
|
|
}
|
|
|
|
forbidden(w)
|
|
}
|
|
|
|
func (m *basicAuthAndSessionMiddleware) passwordAuthHandler(w http.ResponseWriter, r *http.Request) {
|
|
var req struct {
|
|
Username string
|
|
Password string
|
|
StayLoggedIn bool
|
|
}
|
|
if err := unmarshalTo(r.Body, &req); err != nil {
|
|
l.Debugln("Failed to parse username and password:", err)
|
|
http.Error(w, "Failed to parse username and password.", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
if auth(req.Username, req.Password, m.guiCfg, m.ldapCfg) {
|
|
m.tokenCookieManager.createSession(req.Username, req.StayLoggedIn, w, r)
|
|
w.WriteHeader(http.StatusNoContent)
|
|
return
|
|
}
|
|
|
|
emitLoginAttempt(false, req.Username, r.RemoteAddr, m.evLogger)
|
|
antiBruteForceSleep()
|
|
forbidden(w)
|
|
}
|
|
|
|
func attemptBasicAuth(r *http.Request, guiCfg config.GUIConfiguration, ldapCfg config.LDAPConfiguration, evLogger events.Logger) (string, bool) {
|
|
username, password, ok := r.BasicAuth()
|
|
if !ok {
|
|
return "", false
|
|
}
|
|
|
|
l.Debugln("Sessionless HTTP request with authentication; this is expensive.")
|
|
|
|
if auth(username, password, guiCfg, ldapCfg) {
|
|
return username, true
|
|
}
|
|
|
|
usernameFromIso := string(iso88591ToUTF8([]byte(username)))
|
|
passwordFromIso := string(iso88591ToUTF8([]byte(password)))
|
|
if auth(usernameFromIso, passwordFromIso, guiCfg, ldapCfg) {
|
|
return usernameFromIso, true
|
|
}
|
|
|
|
emitLoginAttempt(false, username, r.RemoteAddr, evLogger)
|
|
antiBruteForceSleep()
|
|
return "", false
|
|
}
|
|
|
|
func (m *basicAuthAndSessionMiddleware) handleLogout(w http.ResponseWriter, r *http.Request) {
|
|
m.tokenCookieManager.destroySession(w, r)
|
|
w.WriteHeader(http.StatusNoContent)
|
|
}
|
|
|
|
func auth(username string, password string, guiCfg config.GUIConfiguration, ldapCfg config.LDAPConfiguration) bool {
|
|
if guiCfg.AuthMode == config.AuthModeLDAP {
|
|
return authLDAP(username, password, ldapCfg)
|
|
} else {
|
|
return authStatic(username, password, guiCfg)
|
|
}
|
|
}
|
|
|
|
func authStatic(username string, password string, guiCfg config.GUIConfiguration) bool {
|
|
return guiCfg.CompareHashedPassword(password) == nil && username == guiCfg.User
|
|
}
|
|
|
|
func authLDAP(username string, password string, cfg config.LDAPConfiguration) bool {
|
|
address := cfg.Address
|
|
hostname, _, err := net.SplitHostPort(address)
|
|
if err != nil {
|
|
hostname = address
|
|
}
|
|
var connection *ldap.Conn
|
|
if cfg.Transport == config.LDAPTransportTLS {
|
|
connection, err = ldap.DialTLS("tcp", address, &tls.Config{
|
|
ServerName: hostname,
|
|
InsecureSkipVerify: cfg.InsecureSkipVerify,
|
|
})
|
|
} else {
|
|
connection, err = ldap.Dial("tcp", address)
|
|
}
|
|
|
|
if err != nil {
|
|
l.Warnln("LDAP Dial:", err)
|
|
return false
|
|
}
|
|
|
|
if cfg.Transport == config.LDAPTransportStartTLS {
|
|
err = connection.StartTLS(&tls.Config{InsecureSkipVerify: cfg.InsecureSkipVerify})
|
|
if err != nil {
|
|
l.Warnln("LDAP Start TLS:", err)
|
|
return false
|
|
}
|
|
}
|
|
|
|
defer connection.Close()
|
|
|
|
bindDN := formatOptionalPercentS(cfg.BindDN, escapeForLDAPDN(username))
|
|
err = connection.Bind(bindDN, password)
|
|
if err != nil {
|
|
l.Warnln("LDAP Bind:", err)
|
|
return false
|
|
}
|
|
|
|
if cfg.SearchFilter == "" && cfg.SearchBaseDN == "" {
|
|
// We're done here.
|
|
return true
|
|
}
|
|
|
|
if cfg.SearchFilter == "" || cfg.SearchBaseDN == "" {
|
|
l.Warnln("LDAP configuration: both searchFilter and searchBaseDN must be set, or neither.")
|
|
return false
|
|
}
|
|
|
|
// If a search filter and search base is set we do an LDAP search for
|
|
// the user. If this matches precisely one user then we are good to go.
|
|
// The search filter uses the same %s interpolation as the bind DN.
|
|
|
|
searchString := formatOptionalPercentS(cfg.SearchFilter, escapeForLDAPFilter(username))
|
|
const sizeLimit = 2 // we search for up to two users -- we only want to match one, so getting any number >1 is a failure.
|
|
const timeLimit = 60 // Search for up to a minute...
|
|
searchReq := ldap.NewSearchRequest(cfg.SearchBaseDN, ldap.ScopeWholeSubtree, ldap.DerefFindingBaseObj, sizeLimit, timeLimit, false, searchString, nil, nil)
|
|
|
|
res, err := connection.Search(searchReq)
|
|
if err != nil {
|
|
l.Warnln("LDAP Search:", err)
|
|
return false
|
|
}
|
|
if len(res.Entries) != 1 {
|
|
l.Infof("Wrong number of LDAP search results, %d != 1", len(res.Entries))
|
|
return false
|
|
}
|
|
|
|
return true
|
|
}
|
|
|
|
// escapeForLDAPFilter escapes a value that will be used in a filter clause
|
|
func escapeForLDAPFilter(value string) string {
|
|
// https://social.technet.microsoft.com/wiki/contents/articles/5392.active-directory-ldap-syntax-filters.aspx#Special_Characters
|
|
// Backslash must always be first in the list so we don't double escape them.
|
|
return escapeRunes(value, []rune{'\\', '*', '(', ')', 0})
|
|
}
|
|
|
|
// escapeForLDAPDN escapes a value that will be used in a bind DN
|
|
func escapeForLDAPDN(value string) string {
|
|
// https://social.technet.microsoft.com/wiki/contents/articles/5312.active-directory-characters-to-escape.aspx
|
|
// Backslash must always be first in the list so we don't double escape them.
|
|
return escapeRunes(value, []rune{'\\', ',', '#', '+', '<', '>', ';', '"', '=', ' ', 0})
|
|
}
|
|
|
|
func escapeRunes(value string, runes []rune) string {
|
|
for _, e := range runes {
|
|
value = strings.ReplaceAll(value, string(e), fmt.Sprintf("\\%X", e))
|
|
}
|
|
return value
|
|
}
|
|
|
|
func formatOptionalPercentS(template string, username string) string {
|
|
var replacements []any
|
|
nReps := strings.Count(template, "%s") - strings.Count(template, "%%s")
|
|
if nReps < 0 {
|
|
nReps = 0
|
|
}
|
|
for i := 0; i < nReps; i++ {
|
|
replacements = append(replacements, username)
|
|
}
|
|
return fmt.Sprintf(template, replacements...)
|
|
}
|
|
|
|
// Convert an ISO-8859-1 encoded byte string to UTF-8. Works by the
|
|
// principle that ISO-8859-1 bytes are equivalent to unicode code points,
|
|
// that a rune slice is a list of code points, and that stringifying a slice
|
|
// of runes generates UTF-8 in Go.
|
|
func iso88591ToUTF8(s []byte) []byte {
|
|
runes := make([]rune, len(s))
|
|
for i := range s {
|
|
runes[i] = rune(s[i])
|
|
}
|
|
return []byte(string(runes))
|
|
}
|