mirror of
https://github.com/octoleo/syncthing.git
synced 2024-11-09 14:50:56 +00:00
c71116ee94
This PR does two things, because one lead to the other: - Move the leveldb specific stuff into a small "backend" package that defines a backend interface and the leveldb implementation. This allows, potentially, in the future, switching the db implementation so another KV store should we wish to do so. - Add proper error handling all along the way. The db and backend packages are now errcheck clean. However, I drew the line at modifying the FileSet API in order to keep this manageable and not continue refactoring all of the rest of Syncthing. As such, the FileSet methods still panic on database errors, except for the "database is closed" error which is instead handled by silently returning as quickly as possible, with the assumption that we're anyway "on the way out".
264 lines
7.6 KiB
Go
264 lines
7.6 KiB
Go
// Copyright (C) 2016 The Syncthing Authors.
|
|
//
|
|
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
// You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
package fs
|
|
|
|
import (
|
|
"errors"
|
|
"io/ioutil"
|
|
"os"
|
|
"path/filepath"
|
|
"runtime"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestMtimeFS(t *testing.T) {
|
|
os.RemoveAll("testdata")
|
|
defer os.RemoveAll("testdata")
|
|
os.Mkdir("testdata", 0755)
|
|
ioutil.WriteFile("testdata/exists0", []byte("hello"), 0644)
|
|
ioutil.WriteFile("testdata/exists1", []byte("hello"), 0644)
|
|
ioutil.WriteFile("testdata/exists2", []byte("hello"), 0644)
|
|
|
|
// a random time with nanosecond precision
|
|
testTime := time.Unix(1234567890, 123456789)
|
|
|
|
mtimefs := NewMtimeFS(newBasicFilesystem("."), make(mapStore))
|
|
|
|
// Do one Chtimes call that will go through to the normal filesystem
|
|
mtimefs.chtimes = os.Chtimes
|
|
if err := mtimefs.Chtimes("testdata/exists0", testTime, testTime); err != nil {
|
|
t.Error("Should not have failed:", err)
|
|
}
|
|
|
|
// Do one call that gets an error back from the underlying Chtimes
|
|
mtimefs.chtimes = failChtimes
|
|
if err := mtimefs.Chtimes("testdata/exists1", testTime, testTime); err != nil {
|
|
t.Error("Should not have failed:", err)
|
|
}
|
|
|
|
// Do one call that gets struck by an exceptionally evil Chtimes
|
|
mtimefs.chtimes = evilChtimes
|
|
if err := mtimefs.Chtimes("testdata/exists2", testTime, testTime); err != nil {
|
|
t.Error("Should not have failed:", err)
|
|
}
|
|
|
|
// All of the calls were successful, so an Lstat on them should return
|
|
// the test timestamp.
|
|
|
|
for _, file := range []string{"testdata/exists0", "testdata/exists1", "testdata/exists2"} {
|
|
if info, err := mtimefs.Lstat(file); err != nil {
|
|
t.Error("Lstat shouldn't fail:", err)
|
|
} else if !info.ModTime().Equal(testTime) {
|
|
t.Errorf("Time mismatch; %v != expected %v", info.ModTime(), testTime)
|
|
}
|
|
}
|
|
|
|
// The two last files should certainly not have the correct timestamp
|
|
// when looking directly on disk though.
|
|
|
|
for _, file := range []string{"testdata/exists1", "testdata/exists2"} {
|
|
if info, err := os.Lstat(file); err != nil {
|
|
t.Error("Lstat shouldn't fail:", err)
|
|
} else if info.ModTime().Equal(testTime) {
|
|
t.Errorf("Unexpected time match; %v == %v", info.ModTime(), testTime)
|
|
}
|
|
}
|
|
|
|
// Changing the timestamp on disk should be reflected in a new Lstat
|
|
// call. Choose a time that is likely to be able to be on all reasonable
|
|
// filesystems.
|
|
|
|
testTime = time.Now().Add(5 * time.Hour).Truncate(time.Minute)
|
|
os.Chtimes("testdata/exists0", testTime, testTime)
|
|
if info, err := mtimefs.Lstat("testdata/exists0"); err != nil {
|
|
t.Error("Lstat shouldn't fail:", err)
|
|
} else if !info.ModTime().Equal(testTime) {
|
|
t.Errorf("Time mismatch; %v != expected %v", info.ModTime(), testTime)
|
|
}
|
|
}
|
|
|
|
func TestMtimeFSWalk(t *testing.T) {
|
|
dir, err := ioutil.TempDir("", "")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer func() { _ = os.RemoveAll(dir) }()
|
|
|
|
underlying := NewFilesystem(FilesystemTypeBasic, dir)
|
|
mtimefs := NewMtimeFS(underlying, make(mapStore))
|
|
mtimefs.chtimes = failChtimes
|
|
|
|
if err := ioutil.WriteFile(filepath.Join(dir, "file"), []byte("hello"), 0644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
oldStat, err := mtimefs.Lstat("file")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
newTime := time.Now().Add(-2 * time.Hour)
|
|
|
|
if err := mtimefs.Chtimes("file", newTime, newTime); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if newStat, err := mtimefs.Lstat("file"); err != nil {
|
|
t.Fatal(err)
|
|
} else if !newStat.ModTime().Equal(newTime) {
|
|
t.Errorf("expected time %v, lstat time %v", newTime, newStat.ModTime())
|
|
}
|
|
|
|
if underlyingStat, err := underlying.Lstat("file"); err != nil {
|
|
t.Fatal(err)
|
|
} else if !underlyingStat.ModTime().Equal(oldStat.ModTime()) {
|
|
t.Errorf("expected time %v, lstat time %v", oldStat.ModTime(), underlyingStat.ModTime())
|
|
}
|
|
|
|
found := false
|
|
_ = mtimefs.Walk("", func(path string, info FileInfo, err error) error {
|
|
if path == "file" {
|
|
found = true
|
|
if !info.ModTime().Equal(newTime) {
|
|
t.Errorf("expected time %v, lstat time %v", newTime, info.ModTime())
|
|
}
|
|
}
|
|
return nil
|
|
})
|
|
|
|
if !found {
|
|
t.Error("did not find")
|
|
}
|
|
}
|
|
|
|
func TestMtimeFSOpen(t *testing.T) {
|
|
dir, err := ioutil.TempDir("", "")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer func() { _ = os.RemoveAll(dir) }()
|
|
|
|
underlying := NewFilesystem(FilesystemTypeBasic, dir)
|
|
mtimefs := NewMtimeFS(underlying, make(mapStore))
|
|
mtimefs.chtimes = failChtimes
|
|
|
|
if err := ioutil.WriteFile(filepath.Join(dir, "file"), []byte("hello"), 0644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
oldStat, err := mtimefs.Lstat("file")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
newTime := time.Now().Add(-2 * time.Hour)
|
|
|
|
if err := mtimefs.Chtimes("file", newTime, newTime); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if newStat, err := mtimefs.Lstat("file"); err != nil {
|
|
t.Fatal(err)
|
|
} else if !newStat.ModTime().Equal(newTime) {
|
|
t.Errorf("expected time %v, lstat time %v", newTime, newStat.ModTime())
|
|
}
|
|
|
|
if underlyingStat, err := underlying.Lstat("file"); err != nil {
|
|
t.Fatal(err)
|
|
} else if !underlyingStat.ModTime().Equal(oldStat.ModTime()) {
|
|
t.Errorf("expected time %v, lstat time %v", oldStat.ModTime(), underlyingStat.ModTime())
|
|
}
|
|
|
|
fd, err := mtimefs.Open("file")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
info, err := fd.Stat()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !info.ModTime().Equal(newTime) {
|
|
t.Errorf("expected time %v, lstat time %v", newTime, info.ModTime())
|
|
}
|
|
}
|
|
|
|
func TestMtimeFSInsensitive(t *testing.T) {
|
|
switch runtime.GOOS {
|
|
case "darwin", "windows":
|
|
// blatantly assume file systems here are case insensitive. Might be
|
|
// a spurious failure on oddly configured systems.
|
|
default:
|
|
t.Skip("need case insensitive FS")
|
|
}
|
|
|
|
theTest := func(t *testing.T, fs *MtimeFS, shouldSucceed bool) {
|
|
os.RemoveAll("testdata")
|
|
defer os.RemoveAll("testdata")
|
|
os.Mkdir("testdata", 0755)
|
|
ioutil.WriteFile("testdata/FiLe", []byte("hello"), 0644)
|
|
|
|
// a random time with nanosecond precision
|
|
testTime := time.Unix(1234567890, 123456789)
|
|
|
|
// Do one call that gets struck by an exceptionally evil Chtimes, with a
|
|
// different case from what is on disk.
|
|
fs.chtimes = evilChtimes
|
|
if err := fs.Chtimes("testdata/fIlE", testTime, testTime); err != nil {
|
|
t.Error("Should not have failed:", err)
|
|
}
|
|
|
|
// Check that we get back the mtime we set, if we were supposed to succed.
|
|
info, err := fs.Lstat("testdata/FILE")
|
|
if err != nil {
|
|
t.Error("Lstat shouldn't fail:", err)
|
|
} else if info.ModTime().Equal(testTime) != shouldSucceed {
|
|
t.Errorf("Time mismatch; got %v, comparison %v, expected equal=%v", info.ModTime(), testTime, shouldSucceed)
|
|
}
|
|
}
|
|
|
|
// The test should fail with a case sensitive mtimefs
|
|
t.Run("with case sensitive mtimefs", func(t *testing.T) {
|
|
theTest(t, NewMtimeFS(newBasicFilesystem("."), make(mapStore)), false)
|
|
})
|
|
|
|
// And succeed with a case insensitive one.
|
|
t.Run("with case insensitive mtimefs", func(t *testing.T) {
|
|
theTest(t, NewMtimeFS(newBasicFilesystem("."), make(mapStore), WithCaseInsensitivity(true)), true)
|
|
})
|
|
}
|
|
|
|
// The mapStore is a simple database
|
|
|
|
type mapStore map[string][]byte
|
|
|
|
func (s mapStore) PutBytes(key string, data []byte) error {
|
|
s[key] = data
|
|
return nil
|
|
}
|
|
|
|
func (s mapStore) Bytes(key string) (data []byte, ok bool) {
|
|
data, ok = s[key]
|
|
return
|
|
}
|
|
|
|
func (s mapStore) Delete(key string) error {
|
|
delete(s, key)
|
|
return nil
|
|
}
|
|
|
|
// failChtimes does nothing, and fails
|
|
func failChtimes(name string, mtime, atime time.Time) error {
|
|
return errors.New("no")
|
|
}
|
|
|
|
// evilChtimes will set an mtime that's 300 days in the future of what was
|
|
// asked for, and truncate the time to the closest hour.
|
|
func evilChtimes(name string, mtime, atime time.Time) error {
|
|
return os.Chtimes(name, mtime.Add(300*time.Hour).Truncate(time.Hour), atime.Add(300*time.Hour).Truncate(time.Hour))
|
|
}
|