syncthing/lib/nat
Jakob Borg 2111386ee4
all: Fix some linter errors (#5499)
I'm working through linter complaints, these are some fixes. Broad
categories:

1) Ignore errors where we can ignore errors: add "_ = ..." construct.
you can argue that this is annoying noise, but apart from silencing the
linter it *does* serve the purpose of highlighting that an error is
being ignored. I think this is OK, because the linter highlighted some
error cases I wasn't aware of (starting CPU profiles, for example).

2) Untyped constants where we though we had set the type.

3) A real bug where we ineffectually assigned to a shadowed err.

4) Some dead code removed.

There'll be more of these, because not all packages are fixed, but the
diff was already large enough.
2019-02-02 10:11:42 +01:00
..
debug.go all: Update license url to https (ref #3976) 2017-02-09 08:04:16 +01:00
interface.go all: Fix some linter errors (#5499) 2019-02-02 10:11:42 +01:00
registry.go gui, lib/config, lib/model: Support auto-accepting folders (fixes #2299) 2017-12-07 07:08:24 +00:00
service.go all: Fix some linter errors (#5499) 2019-02-02 10:11:42 +01:00
structs_test.go lib/nat: Fix clearAddresses/notify deadlock (ref #4601) (#4829) 2018-03-21 08:02:32 +01:00
structs.go lib/nat: Fix clearAddresses/notify deadlock (ref #4601) (#4829) 2018-03-21 08:02:32 +01:00