syncthing/lib/upgrade
Jakob Borg 2111386ee4
all: Fix some linter errors (#5499)
I'm working through linter complaints, these are some fixes. Broad
categories:

1) Ignore errors where we can ignore errors: add "_ = ..." construct.
you can argue that this is annoying noise, but apart from silencing the
linter it *does* serve the purpose of highlighting that an error is
being ignored. I think this is OK, because the linter highlighted some
error cases I wasn't aware of (starting CPU profiles, for example).

2) Untyped constants where we though we had set the type.

3) A real bug where we ineffectually assigned to a shadowed err.

4) Some dead code removed.

There'll be more of these, because not all packages are fixed, but the
diff was already large enough.
2019-02-02 10:11:42 +01:00
..
debug.go all: Update license url to https (ref #3976) 2017-02-09 08:04:16 +01:00
signingkey.go all: Update license url to https (ref #3976) 2017-02-09 08:04:16 +01:00
upgrade_common.go all: Fix some linter errors (#5499) 2019-02-02 10:11:42 +01:00
upgrade_supported.go all: Mac OS X is now called macOS 2018-01-27 09:07:19 +00:00
upgrade_test.go lib/upgrade: Tests should pass on darwin-386 2018-06-06 09:47:13 +02:00
upgrade_unsupp.go all: Update license url to https (ref #3976) 2017-02-09 08:04:16 +01:00