mirror of
https://github.com/octoleo/syncthing.git
synced 2024-12-23 11:28:59 +00:00
d507126101
This is in preparation for future changes, but also improves the
handling when talking to pre-v0.13 clients. It breaks out the Hello
message and magic from the rest of the protocol implementation, with the
intention that this small part of the protocol will survive future
changes.
To enable this, and future testing, the new ExchangeHello function takes
an interface that can be implemented by future Hello versions and
returns a version indendent result type. It correctly detects pre-v0.13
protocols and returns a "too old" error message which gets logged to the
user at warning level:
[I6KAH] 09:21:36 WARNING: Connecting to [...]:
the remote device speaks an older version of the protocol (v0.12) not
compatible with this version
Conversely, something entirely unknown will generate:
[I6KAH] 09:40:27 WARNING: Connecting to [...]:
the remote device speaks an unknown (newer?) version of the protocol
The intention is that in future iterations the Hello exchange will
succeed on at least one side and ExchangeHello will return the actual
data from the Hello together with ErrTooOld and an even more precise
message can be generated.
GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/3289
25 lines
560 B
Go
25 lines
560 B
Go
// Copyright (C) 2016 The Protocol Authors.
|
|
|
|
//go:generate -command genxdr go run ../../vendor/github.com/calmh/xdr/cmd/genxdr/main.go
|
|
//go:generate genxdr -o hello_v0.13_xdr.go hello_v0.13.go
|
|
|
|
package protocol
|
|
|
|
var (
|
|
Version13HelloMagic uint32 = 0x9F79BC40
|
|
)
|
|
|
|
type Version13HelloMessage struct {
|
|
DeviceName string // max:64
|
|
ClientName string // max:64
|
|
ClientVersion string // max:64
|
|
}
|
|
|
|
func (m Version13HelloMessage) Magic() uint32 {
|
|
return Version13HelloMagic
|
|
}
|
|
|
|
func (m Version13HelloMessage) Marshal() ([]byte, error) {
|
|
return m.MarshalXDR()
|
|
}
|