mirror of
https://github.com/octoleo/syncthing.git
synced 2024-12-22 19:08:58 +00:00
bc27aa12cd
This commit replaces `os.MkdirTemp` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `os.MkdirTemp`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
96 lines
2.0 KiB
Go
96 lines
2.0 KiB
Go
// Copyright (C) 2014 The Syncthing Authors.
|
|
//
|
|
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
// You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
package versioner
|
|
|
|
import (
|
|
"math"
|
|
"path/filepath"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/syncthing/syncthing/lib/config"
|
|
|
|
"github.com/syncthing/syncthing/lib/fs"
|
|
)
|
|
|
|
func TestTaggedFilename(t *testing.T) {
|
|
cases := [][3]string{
|
|
{filepath.Join("foo", "bar.baz"), "tag", filepath.Join("foo", "bar~tag.baz")},
|
|
{"bar.baz", "tag", "bar~tag.baz"},
|
|
{"bar", "tag", "bar~tag"},
|
|
{"~$ufheft2.docx", "20140612-200554", "~$ufheft2~20140612-200554.docx"},
|
|
{"alle~4.mgz", "20141106-094415", "alle~4~20141106-094415.mgz"},
|
|
|
|
// Parsing test only
|
|
{"", "tag-only", "foo/bar.baz~tag-only"},
|
|
{"", "tag-only", "bar.baz~tag-only"},
|
|
{"", "20140612-200554", "~$ufheft2.docx~20140612-200554"},
|
|
{"", "20141106-094415", "alle~4.mgz~20141106-094415"},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
if tc[0] != "" {
|
|
// Test tagger
|
|
tf := TagFilename(tc[0], tc[1])
|
|
if tf != tc[2] {
|
|
t.Errorf("%s != %s", tf, tc[2])
|
|
}
|
|
}
|
|
|
|
// Test parser
|
|
tag := extractTag(tc[2])
|
|
if tag != tc[1] {
|
|
t.Errorf("%s != %s", tag, tc[1])
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSimpleVersioningVersionCount(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("Test takes some time, skipping.")
|
|
}
|
|
|
|
dir := t.TempDir()
|
|
|
|
cfg := config.FolderConfiguration{
|
|
FilesystemType: fs.FilesystemTypeBasic,
|
|
Path: dir,
|
|
Versioning: config.VersioningConfiguration{
|
|
Params: map[string]string{
|
|
"keep": "2",
|
|
},
|
|
},
|
|
}
|
|
fs := cfg.Filesystem(nil)
|
|
|
|
v := newSimple(cfg)
|
|
|
|
path := "test"
|
|
|
|
for i := 1; i <= 3; i++ {
|
|
f, err := fs.Create(path)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
f.Close()
|
|
if err := v.Archive(path); err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
n, err := fs.DirNames(".stversions")
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
if float64(len(n)) != math.Min(float64(i), 2) {
|
|
t.Error("Wrong count")
|
|
}
|
|
|
|
time.Sleep(time.Second)
|
|
}
|
|
}
|