mirror of
https://github.com/octoleo/syncthing.git
synced 2024-12-23 11:28:59 +00:00
db03562d43
It turns out that ZFS doesn't do any normalization when storing files, but does do normalization "as part of any comparison process". In practice, this seems to mean that if you LStat a normalized filename, ZFS will return the FileInfo for the un-normalized version of that filename. This meant that our test to see whether a separate file with a normalized version of the filename already exists was failing, as we were detecting the same file. The fix is to use os.SameFile, to see whether we're getting the same FileInfo from the normalized and un-normalized versions of the same filename. One complication is that ZFS also seems to apply its magic to os.Rename, meaning that we can't use it to rename an un-normalized file to its normalized filename. Instead we have to move via a temporary object. If the move to the temporary object fails, that's OK, we can skip it and move on. If the move from the temporary object fails however, I'm not sure of the best approach: the current one is to leave the temporary file name as-is, and get Syncthing to syncronize it, so at least we don't lose the file. I'm not sure if there are any implications of this however. As part of reworking normalizePath, I spotted that it appeared to be returning the wrong thing: the doc and the surrounding code expecting it to return the normalized filename, but it was returning the un-normalized one. I fixed this, but it seems suspicious that, if the previous behaviour was incorrect, noone ever ran afoul of it. Maybe all filesystems will do some searching and give you a normalized filename if you request an unnormalized one. As part of this, I found that TestNormalization was broken: it was passing, when in fact one of the files it should have verified was present was missing. Maybe this was related to the above issue with normalizePath's return value, I'm not sure. Fixed en route. Kindly tested by @khinsen on the forum, and it appears to work. GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4646 |
||
|---|---|---|
| .. | ||
| basicfs_test.go | ||
| basicfs_unix.go | ||
| basicfs_watch_errors_linux.go | ||
| basicfs_watch_errors_others.go | ||
| basicfs_watch_eventtypes_fen.go | ||
| basicfs_watch_eventtypes_inotify.go | ||
| basicfs_watch_eventtypes_kqueue.go | ||
| basicfs_watch_eventtypes_other.go | ||
| basicfs_watch_eventtypes_readdcw.go | ||
| basicfs_watch_test.go | ||
| basicfs_watch_unsupported.go | ||
| basicfs_watch.go | ||
| basicfs_windows.go | ||
| basicfs.go | ||
| debug.go | ||
| errorfs.go | ||
| filesystem_test.go | ||
| filesystem.go | ||
| folding_test.go | ||
| folding.go | ||
| fsfileinfo_unix.go | ||
| fsfileinfo_windows.go | ||
| logfs.go | ||
| lstat_broken.go | ||
| lstat_regular.go | ||
| mtimefs_test.go | ||
| mtimefs.go | ||
| tempname_test.go | ||
| tempname.go | ||
| types.go | ||
| util.go | ||
| walkfs.go | ||