mirror of
https://github.com/octoleo/syncthing.git
synced 2025-01-22 14:48:30 +00:00
7023d3ca2b
Upgrading to bootstrap 3.3.5 meant that checkboxes inside a div with column-count:3 set would be unclickable in Chrome: in fact, the entire div appears to sit on top of its contents, making interaction impossible. This affected both the 'show folder with these devices' and 'these devices can access this folder' sections of the UI. I'm not sure what the the underlying cause is, but moving to Bootstrap's grid system appears work around the issue. Devices/folders have to be explicitly split out into rows, otherwise the final element appears offset. To do this grouping by row, a new filter (groupFilter) has been added, which turns an input of e.g. [1, 2, 3, 4, 5] with a groupSize of 3 into [[1, 2, 3], [4, 5]]. However altering the collection in this way throws Angular into an infinite watch loop, terminating in infdig. m59peacemaker's pmkr.filterStabilize (MIT) was added to work around this issue. This also has the nice side-effect of wrapping the list of devices/folders when the screen width decreases. See also: - #2027 (bootstrap update which triggered this issue) - #1121 (last time it happened)